comodojo / rpcserver

src/RpcServer.php

Indentation +1 added lines, -1 removed lines

@@ -566,4 +566,4 @@
 
     }
 
- }
+    }

Spacing +8 added lines, -8 removed lines

@@ -322,7 +322,7 @@ 
 
             $payload = $this->uncan($this->payload);
 
-            $this->logger->debug("Decoded payload", (array)$payload);
+            $this->logger->debug("Decoded payload", (array) $payload);
 
             if ( $this->protocol == self::XMLRPC ) $result = XmlProcessor::process($payload, $parameters_object, $this->logger);
 
@@ -486,30 +486,30 @@ 
      */
     private static function setIntrospectionMethods($methods) {
 
-        $methods->add( RpcMethod::create("system.getCapabilities", '\Comodojo\RpcServer\Reserved\GetCapabilities::execute')
+        $methods->add(RpcMethod::create("system.getCapabilities", '\Comodojo\RpcServer\Reserved\GetCapabilities::execute')
             ->setDescription("This method lists all the capabilites that the RPC server has: the (more or less standard) extensions to the RPC spec that it adheres to")
             ->setReturnType('struct')
         );
 
-        $methods->add( RpcMethod::create("system.listMethods", '\Comodojo\RpcServer\Introspection\ListMethods::execute')
+        $methods->add(RpcMethod::create("system.listMethods", '\Comodojo\RpcServer\Introspection\ListMethods::execute')
             ->setDescription("This method lists all the methods that the RPC server knows how to dispatch")
             ->setReturnType('array')
         );
 
-        $methods->add( RpcMethod::create("system.methodHelp", '\Comodojo\RpcServer\Introspection\MethodHelp::execute')
+        $methods->add(RpcMethod::create("system.methodHelp", '\Comodojo\RpcServer\Introspection\MethodHelp::execute')
             ->setDescription("Returns help text if defined for the method passed, otherwise returns an empty string")
             ->setReturnType('string')
             ->addParameter('string', 'method')
         );
 
-        $methods->add( RpcMethod::create("system.methodSignature", '\Comodojo\RpcServer\Introspection\MethodSignature::execute')
+        $methods->add(RpcMethod::create("system.methodSignature", '\Comodojo\RpcServer\Introspection\MethodSignature::execute')
             ->setDescription("Returns an array of known signatures (an array of arrays) for the method name passed.".
                 "If no signatures are known, returns a none-array (test for type != array to detect missing signature)")
             ->setReturnType('array')
             ->addParameter('string', 'method')
         );
 
-        $methods->add( RpcMethod::create("system.multicall", '\Comodojo\RpcServer\Reserved\Multicall::execute')
+        $methods->add(RpcMethod::create("system.multicall", '\Comodojo\RpcServer\Reserved\Multicall::execute')
             ->setDescription("Boxcar multiple RPC calls in one request. See http://www.xmlrpc.com/discuss/msgReader\$1208 for details")
             ->setReturnType('array')
             ->addParameter('array', 'requests')
@@ -533,7 +533,7 @@ 
             'json-rpc' => array('http://www.jsonrpc.org/specification', 2)
         );
 
-        foreach ($supported_capabilities as $capability => $values) {
+        foreach ( $supported_capabilities as $capability => $values ) {
 
             $capabilities->add($capability, $values[0], $values[1]);
 
@@ -564,7 +564,7 @@ 
             -31001 => "Recursive system.multicall forbidden"
         );
 
-        foreach ($std_rpc_errors as $code => $message) {
+        foreach ( $std_rpc_errors as $code => $message ) {
 
             $errors->add($code, $message);
 

src/Request/JsonProcessor.php

Spacing +1 added lines, -1 removed lines

@@ -468,7 +468,7 @@
 
             $index = 0;
 
-            foreach ($requested as $parameter => $type) {
+            foreach ( $requested as $parameter => $type ) {
 
                 if ( !DataValidator::validate($type, $provided[$index]) ) return false;
 

src/Request/XmlProcessor.php

Spacing +1 added lines, -1 removed lines

@@ -243,7 +243,7 @@
 
             $index = 0;
 
-            foreach ($signature["PARAMETERS"] as $parameter => $type) {
+            foreach ( $signature["PARAMETERS"] as $parameter => $type ) {
 
                 if ( !DataValidator::validate($type, $provided_parameters[$index]) ) continue 2;
 

src/Util/DataValidator.php

Spacing +3 added lines, -3 removed lines

@@ -30,7 +30,7 @@ 
      */
     public static function validate($kind, $value) {
 
-        $subfunction = "self::validate".ucfirst(strtolower(str_replace(".","",$kind)));
+        $subfunction = "self::validate".ucfirst(strtolower(str_replace(".", "", $kind)));
 
         return call_user_func($subfunction, $value);
 
@@ -82,7 +82,7 @@ 
 
         if ( !is_array($value) ) return false;
 
-        return ( array() === $value || !self::validateStruct($value) );
+        return (array() === $value || !self::validateStruct($value));
 
     }
 
@@ -110,7 +110,7 @@ 
 
             $timestring = strtotime($value);
 
-            if ($timestring === false) return false;
+            if ( $timestring === false ) return false;
 
             return $timestring == $time;
 

src/RpcMethod.php

Doc Comments +3 added lines, -5 removed lines

@@ -94,8 +94,7 @@ 
      * Class constructor
      *
      * @param string $name
-     * @param mixed  $callback
-     * @param string $method
+     * @param callable  $callback
      *
      * @throws Exception
      */
@@ -170,7 +169,7 @@ 
     /**
      * Get additional arguments to forward to callback
      *
-     * @return array
+     * @return callable
      */
     public function getArguments() {
 
@@ -379,8 +378,7 @@ 
      * Static class constructor - create an RpcMethod object
      *
      * @param string            $name
-     * @param string|function   $callback
-     * @param string|null       $method
+     * @param string   $callback
      *
      * @return RpcMethod
      * @throws Exception