comodojo / comodojo-installer

src/Comodojo/Installer/Drivers/TaskDriver.php

Spacing +4 added lines, -4 removed lines

@@ -100,7 +100,7 @@ 
 
         foreach ($package_extra as $name => $specs) {
 
-            if ( array_key_exists($name, $config) ) {
+            if (array_key_exists($name, $config)) {
                 $io->write("<error>Duplicate task found!</error>");
                 $io->write("<error>----------------------------</error>");
                 $io->write("<error>Task $name in $package_name is already provided by ".$config[$name]["package_name"]."</error>");
@@ -108,7 +108,7 @@ 
                 continue;
             }
 
-            if ( !self::validate($specs) ) {
+            if (!self::validate($specs)) {
                 $io->write("<error>Invalid task definition in $package_name</error>");
                 $io->write("<error>----------------------------</error>");
                 $io->write("<error>$name => ".var_export($specs, true)."</error>");
@@ -134,10 +134,10 @@ 
 
             $exists = array_key_exists($name, $config);
 
-            if ( $exists && $config[$name]["package_name"] == $package_name) {
+            if ($exists && $config[$name]["package_name"] == $package_name) {
                 unset($config[$name]);
                 $io->write(" <info>-</info> Task [$name] removed");
-            } else if ( $exists ) {
+            } else if ($exists) {
                 $io->write("<error>Task [$name] does not belong to $package_name and cannot be removed</error>");
                 $io->write("<error>----------------------------</error>");
                 $io->write("<error>Found existing task $name that belongs to ".$config[$name]["package_name"]);

src/Comodojo/Installer/Drivers/PluginDriver.php

Spacing +2 added lines, -2 removed lines

@@ -119,7 +119,7 @@ 
 
                 foreach ($package_extra as $plugin) {
 
-                    if ( !self::validate($plugin) ) {
+                    if (!self::validate($plugin)) {
                         $io->write("<error>Invalid plugin definition in $package_name</error>");
                         $io->write("<error>----------------------------</error>");
                         $io->write("<error>".var_export($plugin, true)."</error>");
@@ -147,7 +147,7 @@ 
     }
 
     protected static function validate(array $extra) {
-        return !( empty($extra["class"]) || empty($extra["event"]) );
+        return !(empty($extra["class"]) || empty($extra["event"]));
     }
 
 }

src/Comodojo/Installer/Drivers/CommandDriver.php

Spacing +1 added lines, -1 removed lines

@@ -122,7 +122,7 @@
 
                 foreach ($package_extra as $command) {
 
-                    if ( !self::validate($command) ) {
+                    if (!self::validate($command)) {
                         $io->write("<error>Invalid command definition in $package_name</error>");
                         $io->write("<error>----------------------------</error>");
                         $io->write("<error>".var_export($command, true)."</error>");

src/Comodojo/Installer/Drivers/RouteDriver.php

Spacing +4 added lines, -4 removed lines

@@ -116,7 +116,7 @@ 
 
         foreach ($package_extra as $route => $specs) {
 
-            if ( array_key_exists($route, $config) ) {
+            if (array_key_exists($route, $config)) {
                 $io->write("<error>Duplicate route found!</error>");
                 $io->write("<error>----------------------------</error>");
                 $io->write("<error>Route $route in $package_name is already provided by ".$config[$route]["package_name"]."</error>");
@@ -124,7 +124,7 @@ 
                 continue;
             }
 
-            if ( !self::validate($specs) ) {
+            if (!self::validate($specs)) {
                 $io->write("<error>Invalid route definition in $package_name</error>");
                 $io->write("<error>----------------------------</error>");
                 $io->write("<error>$route => ".var_export($specs, true)."</error>");
@@ -150,10 +150,10 @@ 
 
             $exists = array_key_exists($route, $config);
 
-            if ( $exists && $config[$route]["package_name"] == $package_name) {
+            if ($exists && $config[$route]["package_name"] == $package_name) {
                 unset($config[$route]);
                 $io->write(" <info>-</info> route [$route] removed");
-            } else if ( $exists ) {
+            } else if ($exists) {
                 $io->write("<error>Route [$route] does not belong to $package_name and cannot be removed</error>");
                 $io->write("<error>----------------------------</error>");
                 $io->write("<error>Found existing route $route that belongs to ".$config[$route]["package_name"]);

src/Comodojo/Installer/Plugin.php

Indentation +4 added lines, -4 removed lines

@@ -34,15 +34,15 @@
     protected $comodojo_configuration_persistence;
     
     /**
-    * {@inheritDoc}
-    */
+     * {@inheritDoc}
+     */
     public function deactivate(Composer $composer, IOInterface $io){
     
     }
     
     /**
-    * {@inheritDoc}
-    */
+     * {@inheritDoc}
+     */
     public function uninstall(Composer $composer, IOInterface $io){
     
     }

Spacing +5 added lines, -5 removed lines

@@ -36,14 +36,14 @@ 
     /**
     * {@inheritDoc}
     */
-    public function deactivate(Composer $composer, IOInterface $io){
+    public function deactivate(Composer $composer, IOInterface $io) {
     
     }
     
     /**
     * {@inheritDoc}
     */
-    public function uninstall(Composer $composer, IOInterface $io){
+    public function uninstall(Composer $composer, IOInterface $io) {
     
     }
     
@@ -83,7 +83,7 @@ 
         $io = $event->getIO();
 
         // If a script is in queue, start it now
-        if ( $script !== null ) {
+        if ($script !== null) {
             $io->write("<info>Starting post-install-script</info>");
             $post_install_script = new $script($io, $configuration);
             $io->write("<info>Post-install-script ends</info>");
@@ -100,14 +100,14 @@ 
 
         // check if "real" configuration object is already in, and eventually load it
         $configuration = $this->comodojo_configuration_persistence->load();
-        if ( !empty($configuration) ) {
+        if (!empty($configuration)) {
             $io->write('<comment>Global configuration object found ad loaded</comment>');
             return new Configuration($configuration);
         }
 
         // if not, load it from root composer.json
         $field = $this->installer_configuration->getGlobalConfig()->getExtraField();
-        if ( isset($extra[$field]) && is_array($extra[$field]) ) {
+        if (isset($extra[$field]) && is_array($extra[$field])) {
             $io->write('<comment>Global configuration retrieved from composer.json</comment>');
             $configuration = new Configuration($extra[$field]);
             // overwrite base-path with real one

src/Comodojo/Installer/Persistence/JsonPersistence.php

Spacing +4 added lines, -4 removed lines

@@ -29,9 +29,9 @@ 
 
         $name = $this->getParameters()->get('config-file');
 
-        if ( $name === null ) throw new InstallerException("No config-file name specified");
+        if ($name === null) throw new InstallerException("No config-file name specified");
 
-        if ( file_exists($name) && is_readable($name) ) return json_decode(file_get_contents($name), true);
+        if (file_exists($name) && is_readable($name)) return json_decode(file_get_contents($name), true);
 
         return [];
 
@@ -44,12 +44,12 @@ 
 
         $name = $this->getParameters()->get('config-file');
 
-        if ( $name === null ) throw new InstallerException("No config-file name specified");
+        if ($name === null) throw new InstallerException("No config-file name specified");
 
         $filedata = json_encode($data);
 
         if (
-            ( file_exists($name) && is_writable($name) ) ||
+            (file_exists($name) && is_writable($name)) ||
             is_writeable(pathinfo($name, PATHINFO_DIRNAME))
         ) return file_put_contents($name, $filedata, LOCK_EX);
 

Braces +12 added lines, -4 removed lines

@@ -29,9 +29,13 @@ 
 
         $name = $this->getParameters()->get('config-file');
 
-        if ( $name === null ) throw new InstallerException("No config-file name specified");
+        if ( $name === null ) {
+            throw new InstallerException("No config-file name specified");
+        }
 
-        if ( file_exists($name) && is_readable($name) ) return json_decode(file_get_contents($name), true);
+        if ( file_exists($name) && is_readable($name) ) {
+            return json_decode(file_get_contents($name), true);
+        }
 
         return [];
 
@@ -44,14 +48,18 @@ 
 
         $name = $this->getParameters()->get('config-file');
 
-        if ( $name === null ) throw new InstallerException("No config-file name specified");
+        if ( $name === null ) {
+            throw new InstallerException("No config-file name specified");
+        }
 
         $filedata = json_encode($data);
 
         if (
             ( file_exists($name) && is_writable($name) ) ||
             is_writeable(pathinfo($name, PATHINFO_DIRNAME))
-        ) return file_put_contents($name, $filedata, LOCK_EX);
+        ) {
+            return file_put_contents($name, $filedata, LOCK_EX);
+        }
 
         throw new InstallerException("Cannot write to configuration file $name");
 

src/Comodojo/Installer/Persistence/YamlPersistence.php

Spacing +4 added lines, -4 removed lines

@@ -39,9 +39,9 @@ 
 
         $name = $this->getParameters()->get('config-file');
 
-        if ( $name === null ) throw new InstallerException("No config-file name specified");
+        if ($name === null) throw new InstallerException("No config-file name specified");
 
-        if ( file_exists($name) && is_readable($name) ) return Yaml::parse(file_get_contents($name));
+        if (file_exists($name) && is_readable($name)) return Yaml::parse(file_get_contents($name));
 
         return [];
 
@@ -54,7 +54,7 @@ 
 
         $name = $this->getParameters()->get('config-file');
 
-        if ( $name === null ) throw new InstallerException("No config-file name specified");
+        if ($name === null) throw new InstallerException("No config-file name specified");
 
         $config_depth = $this->getParameters()->get('depth');
 
@@ -63,7 +63,7 @@ 
         $filedata = Yaml::dump($data, $depth);
 
         if (
-            ( file_exists($name) && is_writable($name) ) ||
+            (file_exists($name) && is_writable($name)) ||
             is_writeable(pathinfo($name, PATHINFO_DIRNAME))
         ) return file_put_contents($name, $filedata, LOCK_EX);
 

Braces +12 added lines, -4 removed lines

@@ -39,9 +39,13 @@ 
 
         $name = $this->getParameters()->get('config-file');
 
-        if ( $name === null ) throw new InstallerException("No config-file name specified");
+        if ( $name === null ) {
+            throw new InstallerException("No config-file name specified");
+        }
 
-        if ( file_exists($name) && is_readable($name) ) return Yaml::parse(file_get_contents($name));
+        if ( file_exists($name) && is_readable($name) ) {
+            return Yaml::parse(file_get_contents($name));
+        }
 
         return [];
 
@@ -54,7 +58,9 @@ 
 
         $name = $this->getParameters()->get('config-file');
 
-        if ( $name === null ) throw new InstallerException("No config-file name specified");
+        if ( $name === null ) {
+            throw new InstallerException("No config-file name specified");
+        }
 
         $config_depth = $this->getParameters()->get('depth');
 
@@ -65,7 +71,9 @@ 
         if (
             ( file_exists($name) && is_writable($name) ) ||
             is_writeable(pathinfo($name, PATHINFO_DIRNAME))
-        ) return file_put_contents($name, $filedata, LOCK_EX);
+        ) {
+            return file_put_contents($name, $filedata, LOCK_EX);
+        }
 
         throw new InstallerException("Cannot write to configuration file $name");
 

src/Comodojo/Installer/Components/InstallerConfigurationExtraParser.php

Spacing +5 added lines, -5 removed lines

@@ -46,8 +46,8 @@ 
 
     public function __construct($name, array $content) {
 
-        if ( empty($content['driver']) ) throw new InstallerException("Missing driver for field $name");
-        if ( empty($content['persistence']) ) throw new InstallerException("Missing persistence for field $name");
+        if (empty($content['driver'])) throw new InstallerException("Missing driver for field $name");
+        if (empty($content['persistence'])) throw new InstallerException("Missing persistence for field $name");
 
         $this->properties = [
             "driver" => $content['driver'],
@@ -56,10 +56,10 @@ 
             "persistence-source" => null
         ];
 
-        if ( !empty($content['driver-source']) ) $this->properties['driver-source'] = $content['driver-source'];
-        if ( !empty($content['persistence-source']) ) $this->properties['persistence-source'] = $content['persistence-source'];
+        if (!empty($content['driver-source'])) $this->properties['driver-source'] = $content['driver-source'];
+        if (!empty($content['persistence-source'])) $this->properties['persistence-source'] = $content['persistence-source'];
 
-        $parameters = isset($content['params']) && is_array($content['params']) ? $content['params'] : [] ;
+        $parameters = isset($content['params']) && is_array($content['params']) ? $content['params'] : [];
 
         $this->parameters = new InstallerParameters($parameters);
 

Braces +12 added lines, -4 removed lines

@@ -46,8 +46,12 @@ 
 
     public function __construct($name, array $content) {
 
-        if ( empty($content['driver']) ) throw new InstallerException("Missing driver for field $name");
-        if ( empty($content['persistence']) ) throw new InstallerException("Missing persistence for field $name");
+        if ( empty($content['driver']) ) {
+            throw new InstallerException("Missing driver for field $name");
+        }
+        if ( empty($content['persistence']) ) {
+            throw new InstallerException("Missing persistence for field $name");
+        }
 
         $this->properties = [
             "driver" => $content['driver'],
@@ -56,8 +60,12 @@ 
             "persistence-source" => null
         ];
 
-        if ( !empty($content['driver-source']) ) $this->properties['driver-source'] = $content['driver-source'];
-        if ( !empty($content['persistence-source']) ) $this->properties['persistence-source'] = $content['persistence-source'];
+        if ( !empty($content['driver-source']) ) {
+            $this->properties['driver-source'] = $content['driver-source'];
+        }
+        if ( !empty($content['persistence-source']) ) {
+            $this->properties['persistence-source'] = $content['persistence-source'];
+        }
 
         $parameters = isset($content['params']) && is_array($content['params']) ? $content['params'] : [] ;
 

src/Comodojo/Installer/Components/InstallerDriverManager.php

Spacing +2 added lines, -2 removed lines

@@ -42,12 +42,12 @@
         $parameters = $extra->getParams();
         $base_path = realpath($composer->getConfig()->get('vendor-dir').'/../');
 
-        if ( !class_exists($persistence) && $persistence_source !== null ) {
+        if (!class_exists($persistence) && $persistence_source !== null) {
             include $base_path."/$persistence_source";
         }
         $this->persistence = new $persistence($composer, $io, $configuration, $parameters);
 
-        if ( !class_exists($driver) && $driver_source !== null ) {
+        if (!class_exists($driver) && $driver_source !== null) {
             include $base_path."/$driver_source";
         }
         $this->driver = new $driver($composer, $io, $configuration, $parameters, $this->persistence);