TransactionCollection::getByInteractionId() - Code Metrics - Inspection of "WIP: foo" - commercetools/commercetools-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — php-scrutinizer (0ac9d8)

by Jens

created 2018-02-22 14:23 UTC

TransactionCollection::getByInteractionId() A

↳ Parent: TransactionCollection

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	3
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	1
nc	1
nop	1
crap	2

<?php
/**
 * @author @jenschude <[email protected]>
 */

namespace Commercetools\Core\Model\Payment;

use Commercetools\Core\Model\Common\Collection;

/**
 * @package Commercetools\Core\Model\Payment
 * @link https://docs.commercetools.com/http-api-projects-payments.html#transaction
 * @method TransactionCollection add(Transaction $element)
 * @method Transaction current()
 * @method Transaction getAt($offset)
 * @method Transaction getById($offset)
 */
class TransactionCollection extends Collection
{
    const INTERACTION_ID = 'interactionId';
    protected $type = Transaction::class;


    protected function indexRow($offset, $row)
    {
        if ($row instanceof Transaction) {
            $id = $row->getInteractionId();
        } else {
            $id = isset($row[static::INTERACTION_ID]) ? $row[static::INTERACTION_ID] : null;
        }
        $this->addToIndex(static::INTERACTION_ID, $offset, $id);
    }

    /**
     * @param $id
     * @return Payment
     */
    public function getByInteractionId($id)
    {
        return $this->getBy(static::INTERACTION_ID, $id);

    }
}


1		<?php
2		/**
3		* @author @jenschude <[email protected]>
4		*/
5
6		namespace Commercetools\Core\Model\Payment;
7
8		use Commercetools\Core\Model\Common\Collection;
9
10		/**
11		* @package Commercetools\Core\Model\Payment
12		* @link https://docs.commercetools.com/http-api-projects-payments.html#transaction
13		* @method TransactionCollection add(Transaction $element)
14		* @method Transaction current()
15		* @method Transaction getAt($offset)
16		* @method Transaction getById($offset)
17		*/
18		class TransactionCollection extends Collection
19		{
20		const INTERACTION_ID = 'interactionId';
21		protected $type = Transaction::class;
22
23
24	1	protected function indexRow($offset, $row)
25		{
26	1	if ($row instanceof Transaction) {
27		$id = $row->getInteractionId();
28		} else {
29	1	$id = isset($row[static::INTERACTION_ID]) ? $row[static::INTERACTION_ID] : null;
30		}
31	1	$this->addToIndex(static::INTERACTION_ID, $offset, $id);
32	1	}
33
34		/**
35		* @param $id
36		* @return Payment
37		*/
38		public function getByInteractionId($id)
39		{
40		return $this->getBy(static::INTERACTION_ID, $id);
		0 ignored issues – show Bug Best Practice introduced 2018-02-22 14:32 UTC by Report Bug Copy Issue Report The expression `return $this->getBy(static::INTERACTION_ID, $id)` also could return the type `Commercetools\Core\Model\Payment\Transaction` which is incompatible with the documented return type `Commercetools\Core\Model\Payment\Payment`. Loading history...
41		}
42		}
43

commercetools / commercetools-php-sdk

Branch — php-scrutinizer (0ac9d8)

TransactionCollection::getByInteractionId() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like