Commercetools\Core\Model\Payment\TransactionCollection

Complexity

Total Complexity

4

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Test Coverage

Coverage

62.5%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	indexRow()	0	8	3
A	getByInteractionId()	0	3	1

<?php
/**
 * @author @jenschude <jens.schulze@commercetools.de>
 */

namespace Commercetools\Core\Model\Payment;

use Commercetools\Core\Model\Common\Collection;

/**
 * @package Commercetools\Core\Model\Payment
 * @link https://docs.commercetools.com/http-api-projects-payments.html#transaction
 * @method TransactionCollection add(Transaction $element)
 * @method Transaction current()
 * @method Transaction getAt($offset)
 * @method Transaction getById($offset)
 */
class TransactionCollection extends Collection
{
    const INTERACTION_ID = 'interactionId';
    protected $type = Transaction::class;


    protected function indexRow($offset, $row)
    {
        if ($row instanceof Transaction) {
            $id = $row->getInteractionId();
        } else {
            $id = isset($row[static::INTERACTION_ID]) ? $row[static::INTERACTION_ID] : null;
        }
        $this->addToIndex(static::INTERACTION_ID, $offset, $id);
    }

    /**
     * @param $id
     * @return Payment
     */
    public function getByInteractionId($id)
    {
        return $this->getBy(static::INTERACTION_ID, $id);

The expression return $this->getBy(static::INTERACTION_ID, $id) also could return the type Commercetools\Core\Model\Payment\Transaction which is incompatible with the documented return type Commercetools\Core\Model\Payment\Payment.

    }
}