codingFive0 / octadesk

src/Ticket.php

<?php

namespace codingFive0\octadesk;

class Ticket extends Octadesk
{

    public function __construct($accToken)
    {
        $this->setAccesToken($accToken);
        parent::__construct();
    }

    public function customList()
    {
        $this->request(
            "GET",
            "tickets/custom-lists"
        );

        return $this;
    }

    public function defaultList()
    {
        $this->request(
            "GET",
            "tickets/default-lists"
        );

        return $this;
    }

    public function findByRequesterId($idRequester, $lastNumber = null)
    {
        $params["idRequester"] = $idRequester;

$params was never initialized. Although not strictly required by PHP, it is generally a good practice to add $params = array(); before regardless.

        if ($lastNumber) {
            $params["lastNumber"] = $lastNumber;
        }

        $this->request(
            "GET",
            "tickets",
            $params
        );

        return $this;
    }

    public function findByNumber($number)
    {
        $this->request(
            "GET",
            "tickets/{$number}"
        );

        return $this;
    }

    public function createTicket(array $ticket, array $customField = [])
    {
        $body = [
            "requester" => [
                "email" => ($ticket["requester_email"]),
                "name" => ($ticket["requester_name"])
            ],
            "summary" => ($ticket["summary"] ?? null),
            "comments" => [
                "description" => [
                    "content" => ($ticket["comments_content"] ?? null)
                ]
            ],
            "idProductRelated" => ($ticket["product"] ?? null)
        ];

        if ($customField) {

The expression $customField of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $body = array_merge(["customField" => $customField], $body);
        }

        $this->request(
            "POST",
            "tickets",
            $body,
            null,
            true
        );

        return $this;
    }
}