Ticket::createTicket() - Code Metrics - codingFive0/octadesk - Measure and Improve Code Quality continuously with Scrutinizer

Ticket::createTicket() A
last analyzed 2021-02-24 18:52 UTC

↳ Parent: Ticket

Complexity

Conditions	2
Paths	2

Size

Total Lines	29
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	2

Metric	Value
cc	2
eloc	18
c	3
b	1
f	2
nc	2
nop	2
dl	0
loc	29
rs	9.6666

<?php

namespace codingFive0\octadesk;

class Ticket extends Octadesk
{

    public function __construct($accToken)
    {
        $this->setAccesToken($accToken);
        parent::__construct();
    }

    public function customList()
    {
        $this->request(
            "GET",
            "tickets/custom-lists"
        );

        return $this;
    }

    public function defaultList()
    {
        $this->request(
            "GET",
            "tickets/default-lists"
        );

        return $this;
    }

    public function findByRequesterId($idRequester, $lastNumber = null)
    {
        $params["idRequester"] = $idRequester;


        if ($lastNumber) {
            $params["lastNumber"] = $lastNumber;
        }

        $this->request(
            "GET",
            "tickets",
            $params
        );

        return $this;
    }

    public function findByNumber($number)
    {
        $this->request(
            "GET",
            "tickets/{$number}"
        );

        return $this;
    }

    public function createTicket(array $ticket, array $customField = [])
    {
        $body = [
            "requester" => [
                "email" => ($ticket["requester_email"]),
                "name" => ($ticket["requester_name"])
            ],
            "summary" => ($ticket["summary"] ?? null),
            "comments" => [
                "description" => [
                    "content" => ($ticket["comments_content"] ?? null)
                ]
            ],
            "idProductRelated" => ($ticket["product"] ?? null)
        ];

        if ($customField) {

            $body = array_merge(["customField" => $customField], $body);
        }

        $this->request(
            "POST",
            "tickets",
            $body,
            null,
            true
        );

        return $this;
    }
}

1			<?php
2
3			namespace codingFive0\octadesk;
4
5			class Ticket extends Octadesk
6			{
7
8			public function __construct($accToken)
9			{
10			$this->setAccesToken($accToken);
11			parent::__construct();
12			}
13
14			public function customList()
15			{
16			$this->request(
17			"GET",
18			"tickets/custom-lists"
19			);
20
21			return $this;
22			}
23
24			public function defaultList()
25			{
26			$this->request(
27			"GET",
28			"tickets/default-lists"
29			);
30
31			return $this;
32			}
33
34			public function findByRequesterId($idRequester, $lastNumber = null)
35			{
36			$params["idRequester"] = $idRequester;
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-04-16 18:55 UTC by Report Bug Copy Issue Report `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Loading history...
37
38			if ($lastNumber) {
39			$params["lastNumber"] = $lastNumber;
40			}
41
42			$this->request(
43			"GET",
44			"tickets",
45			$params
46			);
47
48			return $this;
49			}
50
51			public function findByNumber($number)
52			{
53			$this->request(
54			"GET",
55			"tickets/{$number}"
56			);
57
58			return $this;
59			}
60
61			public function createTicket(array $ticket, array $customField = [])
62			{
63			$body = [
64			"requester" => [
65			"email" => ($ticket["requester_email"]),
66			"name" => ($ticket["requester_name"])
67			],
68			"summary" => ($ticket["summary"] ?? null),
69			"comments" => [
70			"description" => [
71			"content" => ($ticket["comments_content"] ?? null)
72			]
73			],
74			"idProductRelated" => ($ticket["product"] ?? null)
75			];
76
77			if ($customField) {
			0 ignored issues – show Bug Best Practice introduced 2020-04-29 20:03 UTC by Report Bug Copy Issue Report The expression `$customField` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
78			$body = array_merge(["customField" => $customField], $body);
79			}
80
81			$this->request(
82			"POST",
83			"tickets",
84			$body,
85			null,
86			true
87			);
88
89			return $this;
90			}
91			}

codingFive0 / octadesk

Ticket::createTicket() A last analyzed 2021-02-24 18:52 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Ticket::createTicket() A
last analyzed 2021-02-24 18:52 UTC