ciandt-dev / behat-placeholders-extension

src/Ciandt/Behat/PlaceholdersExtension/Config/PlaceholdersRepository.php

Doc Comments -1 removed lines

@@ -32,7 +32,6 @@
 
   /**
      * 
-     * @param type $config_files
      * @todo user %paths.base% value
      */
     private function loadConfigFiles($configs_mapping){

Indentation +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
 
     public function getFilePath($key)
     {
-         if (key_exists($key, $this->configs)) {
+          if (key_exists($key, $this->configs)) {
             return $this->configs[$key]['path'];
         }
         return null;

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 use Symfony\Component\Yaml\Yaml;
 use Ciandt\Behat\PlaceholdersExtension\Utils\PlaceholderUtils;
-use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainer;
 use Ciandt\Behat\PlaceholdersExtension\Exception\MissingSectionException;
 use Ciandt\Behat\PlaceholdersExtension\Exception\UndefinedPlaceholderException;
 

Spacing +2 added lines, -2 removed lines

@@ -109,9 +109,9 @@
         }
     }
     
-    private function getSectionPlaceholders($configKey, $section){
+    private function getSectionPlaceholders($configKey, $section) {
         $config = $this->getConfig($configKey);
-        if (!key_exists($section, $config)){
+        if (!key_exists($section, $config)) {
             throw new MissingSectionException(
                     $configKey,
                     $this->getFilePath($configKey),

src/Ciandt/Behat/PlaceholdersExtension/Transformation/RuntimePlaceholdersTransformation.php

Doc Comments +3 added lines

@@ -25,6 +25,9 @@
         return self::USER_DEFINED_PLACEHOLDER_REGEX;
     }
 
+    /**
+     * @param string $string
+     */
     private static function replaceStringPlaceholders($string, PlaceholdersRepository $repository, PlaceholderContainerStepNode $container) {
         preg_match_all(self::USER_DEFINED_PLACEHOLDER_REGEX, $string, $matches, PREG_SET_ORDER);
         foreach ($matches as $match) {

Unused Use Statements -2 removed lines

@@ -3,11 +3,9 @@
 
 namespace Ciandt\Behat\PlaceholdersExtension\Transformation;
 
-use Behat\Behat\Definition\Call\DefinitionCall;
 use Behat\Gherkin\Node\TableNode;
 use Behat\Testwork\Call\RuntimeCallee;
 use Ciandt\Behat\PlaceholdersExtension\Config\PlaceholdersRepository;
-use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainer;
 use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainerStepNode;
 
 /**

src/Ciandt/Behat/PlaceholdersExtension/Exception/MissingSectionException.php

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  *
  * @author bwowk
  */
-class MissingSectionException extends RuntimeException{
+class MissingSectionException extends RuntimeException {
     
         
     public function __construct($configKey, $configPath, $section) {

src/Ciandt/Behat/PlaceholdersExtension/Exception/UndefinedPlaceholderException.php

Spacing +1 added lines, -1 removed lines

@@ -8,6 +8,6 @@
  *
  * @author bwowk
  */
-class UndefinedPlaceholderException extends RuntimeException{
+class UndefinedPlaceholderException extends RuntimeException {
     //put your code here
 }

src/Ciandt/Behat/PlaceholdersExtension/Exception/RedundantConfigTagException.php

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  *
  * @author bwowk
  */
-class RedundantConfigTagException extends RuntimeException{
+class RedundantConfigTagException extends RuntimeException {
     public function __construct($tags) {
         $message = "Multiple config tags found. Should have only one: " . implode(', ', $tags);
         parent::__construct($message);

src/Ciandt/Behat/PlaceholdersExtension/Transformer/PlaceholdersTransformer.php

Indentation -1 removed lines

@@ -10,7 +10,6 @@
 
 /**
  * Transforms a single argument value.
-
  */
 class PlaceholdersTransformer implements ArgumentTransformer
 {

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     public function transformArgument(DefinitionCall $definitionCall, $argumentIndex, $argumentValue) {
         $tags = $this->beforeScenarioSubscriber->getScenarioTags();
         $transformedArgument = $argumentValue;
-        if (RuntimePlaceholdersTransformation::supportsDefinitionAndArgument($tags, $argumentValue)){
+        if (RuntimePlaceholdersTransformation::supportsDefinitionAndArgument($tags, $argumentValue)) {
             $transformedArgument = RuntimePlaceholdersTransformation::transformArgument(
                     $transformedArgument,
                     $this->placeholdersRepository,

src/Ciandt/Behat/PlaceholdersExtension/Utils/PlaceholderUtils.php

Spacing +9 added lines, -9 removed lines

@@ -25,9 +25,9 @@ 
         self::$configKeys = $configKeys;
     }
     
-    public static  function getSectionKey($tag){
+    public static  function getSectionKey($tag) {
         $tagParts = explode(':', $tag);
-        if (count($tagParts) == 2){
+        if (count($tagParts) == 2) {
             return $tagParts[1];
         } else {
             return 'default';
@@ -35,8 +35,8 @@ 
         
     }
     
-    public static function getConfigTag($tags){
-        $configTags = self::filterConfigTags($tags,false);
+    public static function getConfigTag($tags) {
+        $configTags = self::filterConfigTags($tags, false);
         if (empty($configTags)) {
             return false;
         }
@@ -47,25 +47,25 @@ 
     }
 
 
-    public static function getConfigKey($tag){
+    public static function getConfigKey($tag) {
         return explode(':', $tag)[0];
     }
     
     
     public static function filterVariantTags($tags, $exclude)
     {   
-        return array_filter($tags, function ($tag) use ($exclude) {
+        return array_filter($tags, function($tag) use ($exclude) {
             return (in_array($tag, self::$variantTags) xor $exclude);
         });
     }
     
-    public static function getVariant($tags){
+    public static function getVariant($tags) {
         $variantTags = self::filterVariantTags($tags, false);
         if (count($variantTags) > 1) {
             throw new \RuntimeException("Scenario should only have one variant tag."
                     . " Multiple found: " . implode(', ', $variantTags));
         }
-        if (empty($variantTags)){
+        if (empty($variantTags)) {
             return 'default';
         }
         return end($variantTags);
@@ -74,7 +74,7 @@ 
 
     public static function filterConfigTags($tags, $exclude)
     {
-        return array_filter($tags, function ($tag) use ($exclude){
+        return array_filter($tags, function($tag) use ($exclude){
             return (in_array(self::getConfigKey($tag), self::$configKeys) xor $exclude);
         });
     }

src/Ciandt/Behat/PlaceholdersExtension/ServiceContainer/PlaceholdersExtension.php

Spacing +2 added lines, -2 removed lines

@@ -98,7 +98,7 @@ 
         $container->setDefinition(self::PLACEHOLDERS_CONTROLLER_ID, $definition);
     }
 
-    protected function initializePlaceholderUtils($variantTags,$configTags){
+    protected function initializePlaceholderUtils($variantTags, $configTags) {
         PlaceholderUtils::setVariantTags($variantTags);
         PlaceholderUtils::setConfigKeys(array_keys($configTags));
     }
@@ -156,7 +156,7 @@ 
         $container->setDefinition(self::STEPS_DECORATOR_ID, $definition);
     }
     
-    protected function loadBeforeScenarioSubscriber(ContainerBuilder $container){
+    protected function loadBeforeScenarioSubscriber(ContainerBuilder $container) {
         $definition = new Definition('Ciandt\Behat\PlaceholdersExtension\Subscriber\BeforeScenarioSubscriber');
         $definition->addTag(EventDispatcherExtension::SUBSCRIBER_TAG, array('priority' => 0));
         $container->setDefinition(self::BEFORE_SCENARIO_SUBSCRIBER_ID, $definition);

src/Ciandt/Behat/PlaceholdersExtension/Subscriber/BeforeScenarioSubscriber.php

Spacing +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
             );
     }
     
-    public function onBeforeScenarioTested($beforeScenario){
+    public function onBeforeScenarioTested($beforeScenario) {
         $featureTags = $beforeScenario->getFeature()->getTags();
         $scenarioTags = $beforeScenario->getNode()->getTags();
         $this->scenarioTags = array_merge($featureTags, $scenarioTags);