ciandt-dev / behat-placeholders-extension

src/Ciandt/Behat/PlaceholdersExtension/Tester/ScenarioBranchingFeatureTester.php

Unused Use Statements -8 removed lines

@@ -3,21 +3,13 @@
 
 namespace Ciandt\Behat\PlaceholdersExtension\Tester;
 
-use Behat\Behat\Tester\OutlineTester;
-use Behat\Behat\Tester\ScenarioTester;
-use Behat\Gherkin\Node\OutlineNode;
 use Behat\Testwork\Environment\Environment;
-use Behat\Testwork\Environment\EnvironmentManager;
-use Behat\Testwork\Tester\Result\IntegerTestResult;
 use Behat\Testwork\Tester\Result\TestResult;
-use Behat\Testwork\Tester\Result\TestResults;
-use Behat\Testwork\Tester\Result\TestWithSetupResult;
 use Behat\Testwork\Tester\Setup\SuccessfulSetup;
 use Behat\Testwork\Tester\Setup\SuccessfulTeardown;
 use Behat\Testwork\Tester\SpecificationTester;
 use Behat\Gherkin\Node\FeatureNode;
 use Behat\Gherkin\Node\ScenarioNode;
-use Behat\Gherkin\Node\StepNode;
 use Ciandt\Behat\PlaceholdersExtension\Config\ConfigsRepository;
 
 /**

Spacing +5 added lines, -5 removed lines

@@ -75,7 +75,7 @@ 
         $scenarios = array();
         
         foreach ($feature->getScenarios() as $scenario) {
-            $scenarios = array_merge($scenarios,$this->splitScenarioPerVariants($scenario,$feature));
+            $scenarios = array_merge($scenarios, $this->splitScenarioPerVariants($scenario, $feature));
         }
 
         return new FeatureNode(
@@ -91,12 +91,12 @@ 
         );
     }
     
-    private function splitScenarioPerVariants(ScenarioNode $scenario, FeatureNode $feature){
+    private function splitScenarioPerVariants(ScenarioNode $scenario, FeatureNode $feature) {
         $scenarioTags = $scenario->getTags();
         $featureTags = $feature->getTags();
-        $tags = array_merge($scenarioTags,$featureTags);
+        $tags = array_merge($scenarioTags, $featureTags);
         
-        $variants = PlaceholderUtils::filterVariantTags($tags,false);
+        $variants = PlaceholderUtils::filterVariantTags($tags, false);
         
             if (count($variants) <= 1) {
                 return array($scenario);
@@ -109,7 +109,7 @@ 
     private function forkScenario(ScenarioNode $scenario, $variants)
     {
         $scenarios = array();
-        $nonVariantTags = PlaceholderUtils::filterVariantTags($scenario->getTags(),true);
+        $nonVariantTags = PlaceholderUtils::filterVariantTags($scenario->getTags(), true);
         foreach ($variants as $variant) {
             $tags = array_merge($nonVariantTags, array($variant));
             $scenarios[] = new ScenarioNode(

src/Ciandt/Behat/PlaceholdersExtension/Config/PlaceholdersRepository.php

Doc Comments -1 removed lines

@@ -32,7 +32,6 @@
 
   /**
      * 
-     * @param type $config_files
      * @todo user %paths.base% value
      */
     private function loadConfigFiles($configs_mapping){

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 namespace Ciandt\Behat\PlaceholdersExtension\Config;
 
 use Symfony\Component\Yaml\Yaml;
-use Ciandt\Behat\PlaceholdersExtension\Utils\PlaceholderUtils;
 use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainer;
 use Ciandt\Behat\PlaceholdersExtension\Exception\MissingSectionException;
 use Ciandt\Behat\PlaceholdersExtension\Exception\UndefinedPlaceholderException;

Indentation +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
 
     public function getFilePath($key)
     {
-         if (key_exists($key, $this->configs)) {
+          if (key_exists($key, $this->configs)) {
             return $this->configs[$key]['path'];
         }
         return null;

Spacing +2 added lines, -2 removed lines

@@ -107,11 +107,11 @@
         }
     }
     
-    private function getSectionPlaceholders(PlaceholderContainer $container){
+    private function getSectionPlaceholders(PlaceholderContainer $container) {
         $configKey = $container->getConfigKey();
         $config = $this->getConfig($configKey);
         $sectionKey = $container->getSectionKey();
-        if (!key_exists($sectionKey, $config)){
+        if (!key_exists($sectionKey, $config)) {
             throw new MissingSectionException(
                     $configKey,
                     $this->getFilePath($configKey),

src/Ciandt/Behat/PlaceholdersExtension/ServiceContainer/PlaceholdersExtension.php

Unused Use Statements -4 removed lines

@@ -2,11 +2,8 @@ 
 namespace Ciandt\Behat\PlaceholdersExtension\ServiceContainer;
 
 use Ciandt\Behat\PlaceholdersExtension\Config\PlaceholdersRepository;
-use Ciandt\Behat\PlaceholdersExtension\Tester\PerVariantScenarioTester;
-use Ciandt\Behat\PlaceholdersExtension\Tester\PlaceholderReplacingStepTester;
 use Ciandt\Behat\PlaceholdersExtension\Utils\PlaceholderUtils;
 use Behat\Testwork\Cli\ServiceContainer\CliExtension;
-use Behat\Testwork\EventDispatcher\ServiceContainer\EventDispatcherExtension;
 use Behat\Testwork\ServiceContainer\Extension;
 use Behat\Testwork\ServiceContainer\ExtensionManager;
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
@@ -14,7 +11,6 @@ 
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Reference;
 use Behat\Behat\Tester\ServiceContainer\TesterExtension;
-use Behat\Testwork\Environment\ServiceContainer\EnvironmentExtension;
 use Behat\Behat\Transformation\ServiceContainer\TransformationExtension;
 
 final class PlaceholdersExtension implements Extension

Spacing +1 added lines, -1 removed lines

@@ -101,7 +101,7 @@
         $container->setDefinition(self::PLACEHOLDERS_CONTROLLER_ID, $definition);
     }
 
-    protected function initializePlaceholderUtils($variantTags,$configTags){
+    protected function initializePlaceholderUtils($variantTags, $configTags) {
         PlaceholderUtils::setVariantTags($variantTags);
         PlaceholderUtils::setConfigKeys(array_keys($configTags));
     }

src/Ciandt/Behat/PlaceholdersExtension/Transformation/RuntimePlaceholdersTransformation.php

Doc Comments +3 added lines

@@ -25,6 +25,9 @@
         return self::USER_DEFINED_PLACEHOLDER_REGEX;
     }
 
+    /**
+     * @param string $string
+     */
     private static function replaceStringPlaceholders($string, PlaceholdersRepository $repository, PlaceholderContainerStepNode $container) {
         preg_match_all(self::USER_DEFINED_PLACEHOLDER_REGEX, $string, $matches, PREG_SET_ORDER);
         foreach ($matches as $match) {

src/Ciandt/Behat/PlaceholdersExtension/Transformer/PlaceholdersTransformer.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Ciandt\Behat\PlaceholdersExtension\Transformer;
 
 use Behat\Behat\Transformation\Transformer\ArgumentTransformer;
-use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainerStepNode;
 use Ciandt\Behat\PlaceholdersExtension\Transformation\RuntimePlaceholdersTransformation;
 use Behat\Behat\Definition\Call\DefinitionCall;
 use Ciandt\Behat\PlaceholdersExtension\Config\PlaceholdersRepository;

Indentation -1 removed lines

@@ -10,7 +10,6 @@
 
 /**
  * Transforms a single argument value.
-
  */
 class PlaceholdersTransformer implements ArgumentTransformer
 {

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 
     public function transformArgument(DefinitionCall $definitionCall, $argumentIndex, $argumentValue) {
         $transformedArgument = $argumentValue;
-        if (RuntimePlaceholdersTransformation::supportsDefinitionAndArgument($definitionCall, $argumentValue)){
+        if (RuntimePlaceholdersTransformation::supportsDefinitionAndArgument($definitionCall, $argumentValue)) {
             $transformedArgument = RuntimePlaceholdersTransformation::transformArgument(
                     $transformedArgument,
                     $this->placeholdersRepository,

src/Ciandt/Behat/PlaceholdersExtension/Exception/MissingSectionException.php

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  *
  * @author bwowk
  */
-class MissingSectionException extends RuntimeException{
+class MissingSectionException extends RuntimeException {
     
         
     public function __construct($configKey, $configPath, $section) {

src/Ciandt/Behat/PlaceholdersExtension/Exception/UndefinedPlaceholderException.php

Spacing +1 added lines, -1 removed lines

@@ -8,6 +8,6 @@
  *
  * @author bwowk
  */
-class UndefinedPlaceholderException extends RuntimeException{
+class UndefinedPlaceholderException extends RuntimeException {
     //put your code here
 }

src/Ciandt/Behat/PlaceholdersExtension/Exception/RedundantConfigTagException.php

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  *
  * @author bwowk
  */
-class RedundantConfigTagException extends RuntimeException{
+class RedundantConfigTagException extends RuntimeException {
     public function __construct($tags) {
         $message = "Multiple config tags found. Should have only one: " . implode(', ', $tags);
         parent::__construct($message);

src/Ciandt/Behat/PlaceholdersExtension/PlaceholderContainer/PlaceholderContainerStepNode.php

Spacing +2 added lines, -2 removed lines

@@ -10,7 +10,7 @@ 
  *
  * @author bwowk
  */
-class PlaceholderContainerStepNode extends StepNode implements PlaceholderContainer{
+class PlaceholderContainerStepNode extends StepNode implements PlaceholderContainer {
     
     private $stepNode;
     
@@ -20,7 +20,7 @@ 
     
     private $sectionKey;
     
-    function __construct($stepNode,$configKey, $sectionKey,  $variant) {
+    function __construct($stepNode, $configKey, $sectionKey, $variant) {
         $this->stepNode = $stepNode;
         $this->configKey = $configKey;
         $this->sectionKey = $sectionKey;