ciandt-dev / behat-placeholders-extension

src/Ciandt/Behat/PlaceholdersExtension/Config/PlaceholdersRepository.php

Doc Comments -1 removed lines

@@ -47,7 +47,6 @@
     /**
      * reads the YAML placeholder definitions and returns an associative array
      *
-     * @param type $config_files
      * @todo use %paths.base% value
      * @return array
      */

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 use Symfony\Component\Yaml\Yaml;
 use Ciandt\Behat\PlaceholdersExtension\Utils\PlaceholderUtils;
-use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainer;
 use Ciandt\Behat\PlaceholdersExtension\Exception\MissingSectionException;
 use Ciandt\Behat\PlaceholdersExtension\Exception\UndefinedPlaceholderException;
 use Exception;

Indentation +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
 
     private function getFilePath($key)
     {
-         if (key_exists($key, $this->configs)) {
+          if (key_exists($key, $this->configs)) {
             return $this->configs[$key]['path'];
         }
         return null;

Spacing +6 added lines, -6 removed lines

@@ -87,14 +87,14 @@ 
         $this->environment = $environment;
     }
     
-    private function getScenarioTags(){
+    private function getScenarioTags() {
         return $this->beforeScenarioSubscriber->getScenarioTags();
     }
 
     public function getReplacement($placeholder, $replaced = array()) {
         
         // if the current placeholder was already replaced before, this is a cyclic dependecy
-        if (in_array($placeholder, $replaced)){
+        if (in_array($placeholder, $replaced)) {
             $tree = implode('>', $replaced);
             throw new Exception("Cyclic placeholder dependecy detected. Trying to replace $placeholder again when already replaced: $tree");
         }
@@ -121,12 +121,12 @@ 
 
         $replacement = $this->recursivePlaceholderSearch($keys, $placeholders, $treePosition);
         
-        if (is_null($replacement)){
+        if (is_null($replacement)) {
             throw new UndefinedPlaceholderException("No $placeholder placeholder was defined on runtime or on $treePosition>$placeholder for variant $variant and environment $environment");
         } 
         
         //if the replaced string doesn't have placeholders itself
-        if (preg_match_all(self::PLACEHOLDER_REGEX, $replacement, $matches, PREG_SET_ORDER) == 0){
+        if (preg_match_all(self::PLACEHOLDER_REGEX, $replacement, $matches, PREG_SET_ORDER) == 0) {
             return $replacement;
         }
         
@@ -160,9 +160,9 @@ 
         return null;
     }
     
-    private function getSectionPlaceholders($configKey, $section){
+    private function getSectionPlaceholders($configKey, $section) {
         $config = $this->getConfig($configKey);
-        if (!isset($config) || !key_exists($section, $config)){
+        if (!isset($config) || !key_exists($section, $config)) {
             throw new MissingSectionException(
                     $configKey,
                     $this->getFilePath($configKey),

src/Ciandt/Behat/PlaceholdersExtension/Transformation/RuntimePlaceholdersTransformation.php

Doc Comments +3 added lines

@@ -34,6 +34,9 @@
         return $string;
     }
 
+    /**
+     * @param PlaceholdersRepository $repository
+     */
     public static function transformArgument($argument, $repository) {
         if (is_string($argument)) {
             return self::replaceStringPlaceholders($argument, $repository);

Unused Use Statements -3 removed lines

@@ -3,13 +3,10 @@
 
 namespace Ciandt\Behat\PlaceholdersExtension\Transformation;
 
-use Behat\Behat\Definition\Call\DefinitionCall;
 use Behat\Gherkin\Node\PyStringNode;
 use Behat\Gherkin\Node\TableNode;
 use Behat\Testwork\Call\RuntimeCallee;
 use Ciandt\Behat\PlaceholdersExtension\Config\PlaceholdersRepository;
-use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainer;
-use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainerStepNode;
 
 /**
  *

Indentation +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
 /**
  *
  */
- class RuntimePlaceholdersTransformation extends RuntimeCallee implements PlaceholdersTransformation {
+  class RuntimePlaceholdersTransformation extends RuntimeCallee implements PlaceholdersTransformation {
 
     public function __toString() {
         return 'UserDefinedPlaceholderTransform';

Spacing +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
 
         if ($argument instanceof PyStringNode) {
             $strings = $argument->getStrings();
-            foreach ($strings as &$string){
+            foreach ($strings as &$string) {
                 self::replaceStringPlaceholders($string, $repository);
             }
             return new PyStringNode($strings, $argument->getLine());
@@ -54,7 +54,7 @@ 
         }
     }
     
-    private static function replaceTablePlaceholders(&$item, $key, $repository){
+    private static function replaceTablePlaceholders(&$item, $key, $repository) {
         $item = self::replaceStringPlaceholders($item, $repository);
     }
     

src/Ciandt/Behat/PlaceholdersExtension/Transformer/PlaceholdersTransformer.php

Spacing +2 added lines, -2 removed lines

@@ -27,8 +27,8 @@
     }
 
     public function transformArgument(DefinitionCall $definitionCall, $argumentIndex, $argumentValue) {
-        if (RuntimePlaceholdersTransformation::supportsArgument($argumentValue)){
-            return RuntimePlaceholdersTransformation::transformArgument($argumentValue,$this->repository);
+        if (RuntimePlaceholdersTransformation::supportsArgument($argumentValue)) {
+            return RuntimePlaceholdersTransformation::transformArgument($argumentValue, $this->repository);
         }
         return $argumentValue;
     }