RuntimePlaceholdersTransformation::transformArgument() - Code Metrics - Inspection of "Adding placeholders chaining and runtime placehold..." - ciandt-dev/behat-placeholders-extension - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5512e8...78b9a3 )

by Bruno

created 2017-09-24 17:33 UTC

transformArgument() B

↳ Parent: RuntimePlaceholdersTransformation

Complexity

Conditions	5
Paths	5

Size

Total Lines	19
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	12
nc	5
nop	2

<?php


namespace Ciandt\Behat\PlaceholdersExtension\Transformation;

use Behat\Behat\Definition\Call\DefinitionCall;
use Behat\Gherkin\Node\PyStringNode;
use Behat\Gherkin\Node\TableNode;
use Behat\Testwork\Call\RuntimeCallee;
use Ciandt\Behat\PlaceholdersExtension\Config\PlaceholdersRepository;
use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainer;
use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainerStepNode;

/**
 *
 */
 class RuntimePlaceholdersTransformation extends RuntimeCallee implements PlaceholdersTransformation {

    public function __toString() {
        return 'UserDefinedPlaceholderTransform';
    }

    public function getPattern() {
        return PlaceholdersRepository::PLACEHOLDER_REGEX;
    }

    protected static function replaceStringPlaceholders(&$string, $repository) {
        preg_match_all(PlaceholdersRepository::PLACEHOLDER_REGEX, $string, $matches, PREG_SET_ORDER);
        foreach ($matches as $match) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $placeholder = $match['placeholder'];
            $replacement = $repository->getReplacement($placeholder);
            $string = str_replace('${' . $placeholder . '}', $replacement, $string);
        }
        return $string;
    }

    public static function transformArgument($argument, $repository) {
        if (is_string($argument)) {
            return self::replaceStringPlaceholders($argument, $repository);
        }

        if ($argument instanceof PyStringNode) {
            $strings = $argument->getStrings();
            foreach ($strings as &$string){
                self::replaceStringPlaceholders($string, $repository);
            }
            return new PyStringNode($strings, $argument->getLine());
        }
        
        if ($argument instanceof TableNode) {
            $table = $argument->getTable();
            array_walk_recursive($table, 'self::replaceTablePlaceholders', $repository);
            return new TableNode($table);
        }
    }
    
    private static function replaceTablePlaceholders(&$item, $key, $repository){

        $item = self::replaceStringPlaceholders($item, $repository);
    }
    

    public static function supportsArgument($argument)
    {
        if (is_string($argument) && preg_match(PlaceholdersRepository::PLACEHOLDER_REGEX, $argument) === 1) {
            return true;
        }

        if ($argument instanceof PyStringNode &&
            preg_match(PlaceholdersRepository::PLACEHOLDER_REGEX, $argument->getRaw()) === 1) {
            return true;
        }
        
        if ($argument instanceof TableNode &&
            preg_match(PlaceholdersRepository::PLACEHOLDER_REGEX, $argument->getTableAsString()) === 1) {
            return true;
        }
        
        return false;
    }
}


1			<?php
2
3
4			namespace Ciandt\Behat\PlaceholdersExtension\Transformation;
5
6			use Behat\Behat\Definition\Call\DefinitionCall;
7			use Behat\Gherkin\Node\PyStringNode;
8			use Behat\Gherkin\Node\TableNode;
9			use Behat\Testwork\Call\RuntimeCallee;
10			use Ciandt\Behat\PlaceholdersExtension\Config\PlaceholdersRepository;
11			use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainer;
12			use Ciandt\Behat\PlaceholdersExtension\PlaceholderContainer\PlaceholderContainerStepNode;
13
14			/**
15			*
16			*/
17			class RuntimePlaceholdersTransformation extends RuntimeCallee implements PlaceholdersTransformation {
18
19			public function __toString() {
20			return 'UserDefinedPlaceholderTransform';
21			}
22
23			public function getPattern() {
24			return PlaceholdersRepository::PLACEHOLDER_REGEX;
25			}
26
27			protected static function replaceStringPlaceholders(&$string, $repository) {
28			preg_match_all(PlaceholdersRepository::PLACEHOLDER_REGEX, $string, $matches, PREG_SET_ORDER);
29			foreach ($matches as $match) {
			0 ignored issues – show Bug introduced 2017-01-02 12:09 UTC by Report Bug Copy Issue Report The expression `$matches` of type `null\|array<integer,array<integer,string>>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
30			$placeholder = $match['placeholder'];
31			$replacement = $repository->getReplacement($placeholder);
32			$string = str_replace('${' . $placeholder . '}', $replacement, $string);
33			}
34			return $string;
35			}
36
37			public static function transformArgument($argument, $repository) {
38			if (is_string($argument)) {
39			return self::replaceStringPlaceholders($argument, $repository);
40			}
41
42			if ($argument instanceof PyStringNode) {
43			$strings = $argument->getStrings();
44			foreach ($strings as &$string){
45			self::replaceStringPlaceholders($string, $repository);
46			}
47			return new PyStringNode($strings, $argument->getLine());
48			}
49
50			if ($argument instanceof TableNode) {
51			$table = $argument->getTable();
52			array_walk_recursive($table, 'self::replaceTablePlaceholders', $repository);
53			return new TableNode($table);
54			}
55			}
56
57			private static function replaceTablePlaceholders(&$item, $key, $repository){
			0 ignored issues – show Unused Code introduced 2017-09-24 17:34 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history... Unused Code introduced 2017-09-24 17:34 UTC by Report Bug Copy Issue Report The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
58			$item = self::replaceStringPlaceholders($item, $repository);
59			}
60
61
62			public static function supportsArgument($argument)
63			{
64			if (is_string($argument) && preg_match(PlaceholdersRepository::PLACEHOLDER_REGEX, $argument) === 1) {
65			return true;
66			}
67
68			if ($argument instanceof PyStringNode &&
69			preg_match(PlaceholdersRepository::PLACEHOLDER_REGEX, $argument->getRaw()) === 1) {
70			return true;
71			}
72
73			if ($argument instanceof TableNode &&
74			preg_match(PlaceholdersRepository::PLACEHOLDER_REGEX, $argument->getTableAsString()) === 1) {
75			return true;
76			}
77
78			return false;
79			}
80			}
81

ciandt-dev / behat-placeholders-extension

GitHub Access Token became invalid

Push — master ( 5512e8...78b9a3 )

transformArgument() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like