UrlEncodedDecoderType::cleanRawData() - Code Metrics - Inspection of "add deserializer and test" - chubbyphp/chubbyphp-deserialization - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d8a1ad...d0379b )

by Dominik

created 2017-09-26 13:47 UTC

UrlEncodedDecoderType::cleanRawData() C

↳ Parent: UrlEncodedDecoderType

Complexity

Conditions	7
Paths	11

Size

Total Lines	25
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

Metric	Value
dl	0
loc	25
ccs	0
cts	22
cp	0
rs	6.7272
c	0
b	0
f	0
cc	7
eloc	16
nc	11
nop	1
crap	56

<?php

declare(strict_types=1);

namespace Chubbyphp\Deserialization\Decoder;

final class UrlEncodedDecoderType implements DecoderTypeInterface
{
    /**
     * @return string
     */
    public function getContentType(): string
    {
        return 'application/x-www-form-urlencoded';
    }

    /**
     * @param string $data
     *
     * @return array
     *
     * @throws DecoderException
     */
    public function decode(string $data): array
    {
        $rawData = [];
        parse_str($data, $rawData);

        if ('' !== $data && [] === $rawData) {
            throw DecoderException::createNotParsable($this->getContentType());
        }

        return $this->cleanRawData($rawData);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * @param array $rawData
     *
     * @return array
     */
    private function cleanRawData(array $rawData): array
    {
        $data = [];
        foreach ($rawData as $rawKey => $value) {
            $key = (string) (int) $rawKey === $rawData ? (int) $rawKey : $rawKey;

            if (is_array($value)) {
                $data[$key] = $this->cleanRawData($value);
            } else {
                if (is_numeric($value)) {
                    if ((string) (int) $value === $value) {
                        $value = (int) $value;
                    } else {
                        $value = (float) $value;
                    }
                } elseif ('' === $value) {
                    $value = null;
                }

                $data[$key] = $value;
            }
        }

        return $data;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Chubbyphp\Deserialization\Decoder;
6
7			final class UrlEncodedDecoderType implements DecoderTypeInterface
8			{
9			/**
10			* @return string
11			*/
12			public function getContentType(): string
13			{
14			return 'application/x-www-form-urlencoded';
15			}
16
17			/**
18			* @param string $data
19			*
20			* @return array
21			*
22			* @throws DecoderException
23			*/
24			public function decode(string $data): array
25			{
26			$rawData = [];
27			parse_str($data, $rawData);
28
29			if ('' !== $data && [] === $rawData) {
30			throw DecoderException::createNotParsable($this->getContentType());
31			}
32
33			return $this->cleanRawData($rawData);
			0 ignored issues – show Bug introduced 2017-09-26 13:49 UTC by Report Bug Copy Issue Report It seems like `$rawData` can also be of type `null`; however, `Chubbyphp\Deserializatio...derType::cleanRawData()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
34			}
35
36			/**
37			* @param array $rawData
38			*
39			* @return array
40			*/
41			private function cleanRawData(array $rawData): array
42			{
43			$data = [];
44			foreach ($rawData as $rawKey => $value) {
45			$key = (string) (int) $rawKey === $rawData ? (int) $rawKey : $rawKey;
46
47			if (is_array($value)) {
48			$data[$key] = $this->cleanRawData($value);
49			} else {
50			if (is_numeric($value)) {
51			if ((string) (int) $value === $value) {
52			$value = (int) $value;
53			} else {
54			$value = (float) $value;
55			}
56			} elseif ('' === $value) {
57			$value = null;
58			}
59
60			$data[$key] = $value;
61			}
62			}
63
64			return $data;
65			}
66			}
67

chubbyphp / chubbyphp-deserialization

Push — master ( d8a1ad...d0379b )

UrlEncodedDecoderType::cleanRawData() C

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like