Chubbyphp\Deserialization\Decoder\UrlEncodedDecoderType

Complexity

Total Complexity

11

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getContentType()	0	4	1
A	decode()	0	11	3
C	cleanRawData()	0	25	7

<?php

declare(strict_types=1);

namespace Chubbyphp\Deserialization\Decoder;

final class UrlEncodedDecoderType implements DecoderTypeInterface
{
    /**
     * @return string
     */
    public function getContentType(): string
    {
        return 'application/x-www-form-urlencoded';
    }

    /**
     * @param string $data
     *
     * @return array
     *
     * @throws DecoderException
     */
    public function decode(string $data): array
    {
        $rawData = [];
        parse_str($data, $rawData);

        if ('' !== $data && [] === $rawData) {
            throw DecoderException::createNotParsable($this->getContentType());
        }

        return $this->cleanRawData($rawData);

It seems like $rawData can also be of type null; however, Chubbyphp\Deserialization\Decoder\UrlEncodedDecoderType::cleanRawData() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param array $rawData
     *
     * @return array
     */
    private function cleanRawData(array $rawData): array
    {
        $data = [];
        foreach ($rawData as $rawKey => $value) {
            $key = (string) (int) $rawKey === $rawData ? (int) $rawKey : $rawKey;

            if (is_array($value)) {
                $data[$key] = $this->cleanRawData($value);
            } else {
                if (is_numeric($value)) {
                    if ((string) (int) $value === $value) {
                        $value = (int) $value;
                    } else {
                        $value = (float) $value;
                    }
                } elseif ('' === $value) {
                    $value = null;
                }

                $data[$key] = $value;
            }
        }

        return $data;
    }
}