chrmorandi / yii2-ldap

LdapFunctionTrait.php

Indentation +8 added lines, -8 removed lines

@@ -96,14 +96,14 @@
         return ldap_modify_batch($this->resource, $dn, $values);
     }
 
-     /**
-     * Add attribute values to current attributes.
-     *
-     * @param string $dn
-     * @param array  $entry
-     *
-     * @return mixed
-     */
+        /**
+         * Add attribute values to current attributes.
+         *
+         * @param string $dn
+         * @param array  $entry
+         *
+         * @return mixed
+         */
     public function modAdd($dn, array $entry)
     {
         return ldap_mod_add($this->resource, $dn, $entry);

Doc Comments +8 added lines, -10 removed lines

@@ -102,7 +102,7 @@ 
      * @param string $dn
      * @param array  $entry
      *
-     * @return mixed
+     * @return boolean
      */
     public function modAdd($dn, array $entry)
     {
@@ -115,7 +115,7 @@ 
      * @param string $dn
      * @param array  $entry
      *
-     * @return mixed
+     * @return boolean
      */
     public function modReplace($dn, array $entry)
     {
@@ -128,7 +128,7 @@ 
      * @param string $dn
      * @param array  $entry
      *
-     * @return mixed
+     * @return boolean
      */
     public function modDelete($dn, array $entry)
     {
@@ -165,7 +165,7 @@ 
      *
      * @param $searchResult
      *
-     * @return mixed
+     * @return resource
      */
     public function getFirstEntry($searchResults)
     {
@@ -177,7 +177,7 @@ 
      *
      * @param $entry
      *
-     * @return mixed
+     * @return resource
      */
     public function getNextEntry($entry)
     {
@@ -220,10 +220,8 @@ 
     /**
      * Sets an option on the current connection.
      *
-     * @param int   $option
-     * @param mixed $value
      *
-     * @return mixed
+     * @return boolean
      */
     public function setRebindCallback(callable $callback)
     {
@@ -233,7 +231,7 @@ 
     /**
      * Starts a connection using TLS.
      *
-     * @return mixed
+     * @return boolean
      */
     public function startTLS()
     {
@@ -244,7 +242,7 @@ 
      * Returns the error number of the last command
      * executed on the current connection.
      *
-     * @return mixed
+     * @return integer
      */
     public function getErrNo()
     {

schemas/ADUserTrait.php

Spacing +1 added lines, -1 removed lines

@@ -288,7 +288,7 @@
      */
     protected $wWWHomePage;
     
-    public function rules (){
+    public function rules() {
         return [['cn'], 'required'];
     }
     

FilterBuilder.php

Spacing +11 added lines, -11 removed lines

@@ -98,7 +98,7 @@ 
                 $parts[] = "$column=$value";
             }
         }
-        return count($parts) === 1 ? '('.$parts[0].')' : '$(' . implode(') (', $parts) . ')';
+        return count($parts) === 1 ? '('.$parts[0].')' : '$('.implode(') (', $parts).')';
     }
 
     /**
@@ -122,7 +122,7 @@ 
             }
         }
         if (!empty($parts)) {
-            return '('.$this->operator[$operator].'(' . implode(") (", $parts) . ')'.implode($other).' )';
+            return '('.$this->operator[$operator].'('.implode(") (", $parts).')'.implode($other).' )';
         } else {
             return '';
         }
@@ -150,7 +150,7 @@ 
             return '';
         }
 
-        return '('.$this->operator['NOT'].'('.key($operands) .'='.$operand.'))';
+        return '('.$this->operator['NOT'].'('.key($operands).'='.$operand.'))';
     }
 
     /**
@@ -209,10 +209,10 @@ 
         }
 
         if (count($sqlValues) > 1) {
-            return "$column $operator (" . implode(', ', $sqlValues) . ')';
+            return "$column $operator (".implode(', ', $sqlValues).')';
         } else {
             $operator = $operator === 'IN' ? '=' : '<>';
-            return $column . $operator . reset($sqlValues);
+            return $column.$operator.reset($sqlValues);
         }
     }
 
@@ -233,7 +233,7 @@ 
                     $columns[$i] = $this->db->quoteColumnName($col);
                 }
             }
-            return '(' . implode(', ', $columns) . ") $operator ($sql)";
+            return '('.implode(', ', $columns).") $operator ($sql)";
         } else {
             if (strpos($columns, '(') === false) {
                 $columns = $this->db->quoteColumnName($columns);
@@ -264,7 +264,7 @@ 
                     $vs[] = 'NULL';
                 }
             }
-            $vss[] = '(' . implode(', ', $vs) . ')';
+            $vss[] = '('.implode(', ', $vs).')';
         }
 
         if (empty($vss)) {
@@ -276,7 +276,7 @@ 
             $sqlColumns[] = strpos($column, '(') === false ? $this->db->quoteColumnName($column) : $column;
         }
 
-        return '(' . implode(', ', $sqlColumns) . ") $operator (" . implode(', ', $vss) . ')';
+        return '('.implode(', ', $sqlColumns).") $operator (".implode(', ', $vss).')';
     }
 
     /**
@@ -324,15 +324,15 @@ 
             return $not ? '' : '0=1';
         }
         
-        $not = ($operator == 'NOT LIKE') ? '(' . $this->operator['NOT'] : false;
+        $not = ($operator == 'NOT LIKE') ? '('.$this->operator['NOT'] : false;
 
         $parts = [];
         foreach ($values as $value) {
             $value = empty($escape) ? $value : strtr($value, $escape);
-            $parts[] = $not . '(' . $column .'=*'.$value . '*)' . ($not? ')':'');
+            $parts[] = $not.'('.$column.'=*'.$value.'*)'.($not ? ')' : '');
         }
 
-        return '('.$this->operator[trim($andor)] . implode($parts). ')';
+        return '('.$this->operator[trim($andor)].implode($parts).')';
     }
 
     /**

Connection.php

Doc Comments +9 added lines, -9 removed lines

@@ -93,7 +93,7 @@ 
 
     /**
      * Get the current resource of connection.
-     * @return mixed
+     * @return resource
      */
     public function getResource()
     {
@@ -282,7 +282,7 @@ 
      * Add attribute values to current attributes.
      * @param string $dn
      * @param array  $entry
-     * @return mixed
+     * @return boolean
      */
     public function modAdd($dn, array $entry)
     {
@@ -293,7 +293,7 @@ 
      * Replaces attribute values with new ones.
      * @param string $dn
      * @param array  $entry
-     * @return mixed
+     * @return boolean
      */
     public function modReplace($dn, array $entry)
     {
@@ -304,7 +304,7 @@ 
      * Delete attribute values from current attributes.
      * @param string $dn
      * @param array  $entry
-     * @return mixed
+     * @return boolean
      */
     public function modDelete($dn, array $entry)
     {
@@ -323,7 +323,7 @@ 
     
     /**
      * Returns the number of entries from a search result.
-     * @param $searchResult
+     * @param resource $searchResult
      * @return int
      */
     public function countEntries($searchResult)
@@ -334,7 +334,7 @@ 
     /**
      * Retrieves the first entry from a search result.
      * @param $searchResult
-     * @return mixed
+     * @return resource
      */
     public function getFirstEntry($searchResult)
     {
@@ -344,7 +344,7 @@ 
     /**
      * Retrieves the next entry from a search result.
      * @param $entry
-     * @return mixed
+     * @return resource
      */
     public function getNextEntry($entry)
     {
@@ -365,7 +365,7 @@ 
      * Sets an option on the current connection.
      * @param int   $option
      * @param mixed $value
-     * @return mixed
+     * @return boolean
      */
     public function setOption($option, $value)
     {
@@ -392,7 +392,7 @@ 
     
     /**
      * Returns the number of the last error on the current connection.
-     * @return mixed
+     * @return integer
      */
     public function getErrNo()
     {

Indentation +6 added lines, -6 removed lines

@@ -278,12 +278,12 @@
         return ldap_modify_batch($this->resource, $dn, $values);
     }
 
-     /**
-     * Add attribute values to current attributes.
-     * @param string $dn
-     * @param array  $entry
-     * @return mixed
-     */
+        /**
+         * Add attribute values to current attributes.
+         * @param string $dn
+         * @param array  $entry
+         * @return mixed
+         */
     public function modAdd($dn, array $entry)
     {
         return ldap_mod_add($this->resource, $dn, $entry);

Spacing +1 added lines, -1 removed lines

@@ -139,7 +139,7 @@
         $protocol = $this::PROTOCOL;
 
         if (is_array($hostname)) {
-            $hostname = $protocol . implode(' ' . $protocol, $hostname);
+            $hostname = $protocol.implode(' '.$protocol, $hostname);
         }
         $this->resource = ldap_connect($hostname, $port);
 

Query.php

Spacing +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
         }
         
         $this->filter = (new FilterBuilder)->build($this->where);        
-        if(empty($this->filter)){
+        if (empty($this->filter)) {
             throw new InvalidValueException('You must define a filter for the search.');
         }