View GitHub Repository yii2-ldap

Schedule Inspection
Subscribe
Completed
Push — master ( f38146...3141eb )
by Christopher
05:15
created
Status
Category
Toggle Patches
schemas/ADUserTrait.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -26,7 +26,7 @@  discard block
 
 block discarded – undo
26 26 
      * @link https://msdn.microsoft.com/en-us/library/ms680932(v=vs.85).aspx
27 27 
      * @var array
28 28 
      */
29 
-    protected $objectClass = ['user','person','organizationalPerson', 'top'];
29 
+    protected $objectClass = ['user', 'person', 'organizationalPerson', 'top'];
30 30
31 31 
     /**
32 32 
      * The date when the account expires. This value represents the number of 100-nanosecond
 
@@ -288,8 +288,8 @@  discard block
 
 block discarded – undo
288 288 
      */
289 289 
     protected $wWWHomePage;
290 290
291 
-    public function rules (){
292 
-        return [['cn'],'safe'];
291 
+    public function rules() {
292 
+        return [['cn'], 'safe'];
293 293 
     }
294 294
295 295 
 }
Please login to merge, or discard this patch.
DataReader.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -140,7 +140,7 @@  discard block
 
 block discarded – undo
140 140 
             Yii::endProfile('ldap_free_result', 'chrmorandi\ldap\DataReader');
141 141
142 142 
             $this->_result = null;
143 
-            $this->_row  = null;
143 
+            $this->_row = null;
144 144 
         }
145 145 
     }
146 146 
 
@@ -211,7 +211,7 @@  discard block
 
 block discarded – undo
211 211
212 212 
         $resource = $this->_conn->resource;
213 213
214 
-        Yii::beginProfile('current:' . $this->key(), 'chrmorandi\ldap\DataReader');
214 
+        Yii::beginProfile('current:'.$this->key(), 'chrmorandi\ldap\DataReader');
215 215 
         $name = ldap_first_attribute($resource, $this->_row);
216 216
217 217 
         while ($name) {
Please login to merge, or discard this patch.
ActiveRecord.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -173,7 +173,7 @@
 
 block discarded – undo
173 173 
         $dn = $values[self::primaryKey()];
174 174 
         unset($values[self::primaryKey()]);
175 175
176 
-        if (($primaryKeys = static::getDb()->execute('ldap_add', [$dn,$values])) === false) {
176 
+        if (($primaryKeys = static::getDb()->execute('ldap_add', [$dn, $values])) === false) {
177 177 
             return false;
178 178 
         }
179 179 
         $this->setAttribute(self::primaryKey(), $dn);
Please login to merge, or discard this patch.
index.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -11,7 +11,7 @@
 
 block discarded – undo
11 11 
   </head>
12 12 
   <body>
13 13 
       <?php
14 
-      // put your code here
14 
+        // put your code here
15 15
16 16 
         ?>
17 17 
   </body>
Please login to merge, or discard this patch.
Query.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -108,7 +108,7 @@  discard block
 
 block discarded – undo
108 108 
         }
109 109
110 110 
         $filter = (new FilterBuilder)->build($this->where);
111 
-        $select = (is_array($this->select))?$this->select:[];
111 
+        $select = (is_array($this->select)) ? $this->select : [];
112 112
113 113 
         $params = [
114 114 
             $db->baseDn,
 
@@ -234,7 +234,7 @@  discard block
 
 block discarded – undo
234 234 
         $params = $this->createCommand($db);
235 235
236 236 
         /** @var $result DataReader */
237 
-        $result = $db->execute($this->scope, array_push($params,1));
237 
+        $result = $db->execute($this->scope, array_push($params, 1));
238 238 
         return $result->toArray();
239 239 
     }
240 240 
 
@@ -304,7 +304,7 @@  discard block
 
 block discarded – undo
304 304 
         $params = $command->params;
305 305 
         $command->setSql($command->db->getQueryBuilder()->selectExists($command->getSql()));
306 306 
         $command->bindValues($params);
307 
-        return (boolean)$command->queryScalar();
307 
+        return (boolean) $command->queryScalar();
308 308 
     }
309 309
310 310 
     /**
Please login to merge, or discard this patch.
FilterBuilder.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch 
@@ -98,7 +98,7 @@  discard block
 
 block discarded – undo
98 98 
                 $parts[] = "$column=$value";
99 99 
             }
100 100 
         }
101 
-        return count($parts) === 1 ? '('.$parts[0].')' : '$(' . implode(') (', $parts) . ')';
101 
+        return count($parts) === 1 ? '('.$parts[0].')' : '$('.implode(') (', $parts).')';
102 102 
     }
103 103
104 104 
     /**
 
@@ -121,7 +121,7 @@  discard block
 
 block discarded – undo
121 121 
             }
122 122 
         }
123 123 
         if (!empty($parts)) {
124 
-            return '('.$this->operator[$operator].'(' . implode(") (", $parts) . ')'.implode($other).' )';
124 
+            return '('.$this->operator[$operator].'('.implode(") (", $parts).')'.implode($other).' )';
125 125 
         } else {
126 126 
             return '';
127 127 
         }
 
@@ -149,7 +149,7 @@  discard block
 
 block discarded – undo
149 149 
             return '';
150 150 
         }
151 151
152 
-        return '('.$this->operator['NOT'].'('.key($operands) .'='.$operand.'))';
152 
+        return '('.$this->operator['NOT'].'('.key($operands).'='.$operand.'))';
153 153 
     }
154 154
155 155 
     /**
 
@@ -208,10 +208,10 @@  discard block
 
 block discarded – undo
208 208 
         }
209 209
210 210 
         if (count($sqlValues) > 1) {
211 
-            return "$column $operator (" . implode(', ', $sqlValues) . ')';
211 
+            return "$column $operator (".implode(', ', $sqlValues).')';
212 212 
         } else {
213 213 
             $operator = $operator === 'IN' ? '=' : '<>';
214 
-            return $column . $operator . reset($sqlValues);
214 
+            return $column.$operator.reset($sqlValues);
215 215 
         }
216 216 
     }
217 217 
 
@@ -232,7 +232,7 @@  discard block
 
 block discarded – undo
232 232 
                     $columns[$i] = $this->db->quoteColumnName($col);
233 233 
                 }
234 234 
             }
235 
-            return '(' . implode(', ', $columns) . ") $operator ($sql)";
235 
+            return '('.implode(', ', $columns).") $operator ($sql)";
236 236 
         } else {
237 237 
             if (strpos($columns, '(') === false) {
238 238 
                 $columns = $this->db->quoteColumnName($columns);
 
@@ -256,14 +256,14 @@  discard block
 
 block discarded – undo
256 256 
             $vs = [];
257 257 
             foreach ($columns as $column) {
258 258 
                 if (isset($value[$column])) {
259 
-                    $phName = self::PARAM_PREFIX . count($params);
259 
+                    $phName = self::PARAM_PREFIX.count($params);
260 260 
                     $params[$phName] = $value[$column];
261 261 
                     $vs[] = $phName;
262 262 
                 } else {
263 263 
                     $vs[] = 'NULL';
264 264 
                 }
265 265 
             }
266 
-            $vss[] = '(' . implode(', ', $vs) . ')';
266 
+            $vss[] = '('.implode(', ', $vs).')';
267 267 
         }
268 268
269 269 
         if (empty($vss)) {
 
@@ -275,7 +275,7 @@  discard block
 
 block discarded – undo
275 275 
             $sqlColumns[] = strpos($column, '(') === false ? $this->db->quoteColumnName($column) : $column;
276 276 
         }
277 277
278 
-        return '(' . implode(', ', $sqlColumns) . ") $operator (" . implode(', ', $vss) . ')';
278 
+        return '('.implode(', ', $sqlColumns).") $operator (".implode(', ', $vss).')';
279 279 
     }
280 280
281 281 
     /**
 
@@ -323,15 +323,15 @@  discard block
 
 block discarded – undo
323 323 
             return $not ? '' : '0=1';
324 324 
         }
325 325
326 
-        $not = ($operator == 'NOT LIKE') ? '(' . $this->operator['NOT'] : false;
326 
+        $not = ($operator == 'NOT LIKE') ? '('.$this->operator['NOT'] : false;
327 327
328 328 
         $parts = [];
329 329 
         foreach ($values as $value) {
330 330 
             $value = empty($escape) ? $value : strtr($value, $escape);
331 
-            $parts[] = $not . '(' . $column .'=*'.$value . '*)' . ($not? ')':'');
331 
+            $parts[] = $not.'('.$column.'=*'.$value.'*)'.($not ? ')' : '');
332 332 
         }
333 333
334 
-        return '('.$this->operator[trim($andor)] . implode($parts). ')';
334 
+        return '('.$this->operator[trim($andor)].implode($parts).')';
335 335 
     }
336 336
337 337 
     /**
Please login to merge, or discard this patch.