chrmorandi / yii2-ldap

LdapFunctionTrait.php

Doc Comments +9 added lines, -10 removed lines

@@ -111,7 +111,7 @@ 
      * @param string $dn
      * @param array  $entry
      *
-     * @return mixed
+     * @return boolean
      */
     public function modAdd($dn, array $entry)
     {
@@ -124,7 +124,7 @@ 
      * @param string $dn
      * @param array  $entry
      *
-     * @return mixed
+     * @return boolean
      */
     public function modReplace($dn, array $entry)
     {
@@ -137,7 +137,7 @@ 
      * @param string $dn
      * @param array  $entry
      *
-     * @return mixed
+     * @return boolean
      */
     public function modDelete($dn, array $entry)
     {
@@ -174,7 +174,7 @@ 
      *
      * @param $searchResult
      *
-     * @return mixed
+     * @return resource
      */
     public function getFirstEntry($searchResults)
     {
@@ -186,7 +186,7 @@ 
      *
      * @param $entry
      *
-     * @return mixed
+     * @return resource
      */
     public function getNextEntry($entry)
     {
@@ -220,6 +220,7 @@ 
 
     /**
      * {@inheritdoc}
+     * @param integer $option
      */
     public function setOption($option, $value)
     {
@@ -229,10 +230,8 @@ 
     /**
      * Sets an option on the current connection.
      *
-     * @param int   $option
-     * @param mixed $value
      *
-     * @return mixed
+     * @return boolean
      */
     public function setRebindCallback(callable $callback)
     {
@@ -242,7 +241,7 @@ 
     /**
      * Starts a connection using TLS.
      *
-     * @return mixed
+     * @return boolean
      */
     public function startTLS()
     {
@@ -253,7 +252,7 @@ 
      * Returns the error number of the last command
      * executed on the current connection.
      *
-     * @return mixed
+     * @return integer
      */
     public function getErrNo()
     {

Indentation +8 added lines, -8 removed lines

@@ -96,14 +96,14 @@
         return ldap_modify_batch($this->resource, $dn, $values);
     }
 
-     /**
-     * Add attribute values to current attributes.
-     *
-     * @param string $dn
-     * @param array  $entry
-     *
-     * @return mixed
-     */
+        /**
+         * Add attribute values to current attributes.
+         *
+         * @param string $dn
+         * @param array  $entry
+         *
+         * @return mixed
+         */
     public function modAdd($dn, array $entry)
     {
         return ldap_mod_add($this->resource, $dn, $entry);

FilterBuilder.php

Spacing +12 added lines, -12 removed lines

@@ -98,7 +98,7 @@ 
                 $parts[] = "$column=$value";
             }
         }
-        return count($parts) === 1 ? '('.$parts[0].')' : '$(' . implode(') (', $parts) . ')';
+        return count($parts) === 1 ? '('.$parts[0].')' : '$('.implode(') (', $parts).')';
     }
 
     /**
@@ -121,7 +121,7 @@ 
             }
         }
         if (!empty($parts)) {
-            return '('.$this->operator[$operator].'(' . implode(") (", $parts) . ')'.implode($other).' )';
+            return '('.$this->operator[$operator].'('.implode(") (", $parts).')'.implode($other).' )';
         } else {
             return '';
         }
@@ -149,7 +149,7 @@ 
             return '';
         }
 
-        return '('.$this->operator['NOT'].'('.key($operands) .'='.$operand.'))';
+        return '('.$this->operator['NOT'].'('.key($operands).'='.$operand.'))';
     }
 
     /**
@@ -208,10 +208,10 @@ 
         }
 
         if (count($sqlValues) > 1) {
-            return "$column $operator (" . implode(', ', $sqlValues) . ')';
+            return "$column $operator (".implode(', ', $sqlValues).')';
         } else {
             $operator = $operator === 'IN' ? '=' : '<>';
-            return $column . $operator . reset($sqlValues);
+            return $column.$operator.reset($sqlValues);
         }
     }
 
@@ -232,7 +232,7 @@ 
                     $columns[$i] = $this->db->quoteColumnName($col);
                 }
             }
-            return '(' . implode(', ', $columns) . ") $operator ($sql)";
+            return '('.implode(', ', $columns).") $operator ($sql)";
         } else {
             if (strpos($columns, '(') === false) {
                 $columns = $this->db->quoteColumnName($columns);
@@ -256,14 +256,14 @@ 
             $vs = [];
             foreach ($columns as $column) {
                 if (isset($value[$column])) {
-                    $phName = self::PARAM_PREFIX . count($params);
+                    $phName = self::PARAM_PREFIX.count($params);
                     $params[$phName] = $value[$column];
                     $vs[] = $phName;
                 } else {
                     $vs[] = 'NULL';
                 }
             }
-            $vss[] = '(' . implode(', ', $vs) . ')';
+            $vss[] = '('.implode(', ', $vs).')';
         }
 
         if (empty($vss)) {
@@ -275,7 +275,7 @@ 
             $sqlColumns[] = strpos($column, '(') === false ? $this->db->quoteColumnName($column) : $column;
         }
 
-        return '(' . implode(', ', $sqlColumns) . ") $operator (" . implode(', ', $vss) . ')';
+        return '('.implode(', ', $sqlColumns).") $operator (".implode(', ', $vss).')';
     }
 
     /**
@@ -323,15 +323,15 @@ 
             return $not ? '' : '0=1';
         }
         
-        $not = ($operator == 'NOT LIKE') ? '(' . $this->operator['NOT'] : false;
+        $not = ($operator == 'NOT LIKE') ? '('.$this->operator['NOT'] : false;
 
         $parts = [];
         foreach ($values as $value) {
             $value = empty($escape) ? $value : strtr($value, $escape);
-            $parts[] = $not . '(' . $column .'=*'.$value . '*)' . ($not? ')':'');
+            $parts[] = $not.'('.$column.'=*'.$value.'*)'.($not ? ')' : '');
         }
 
-        return '('.$this->operator[trim($andor)] . implode($parts). ')';
+        return '('.$this->operator[trim($andor)].implode($parts).')';
     }
 
     /**

schemas/ADUserTrait.php

Spacing +1 added lines, -1 removed lines

@@ -288,7 +288,7 @@
      */
     protected $wWWHomePage;
     
-    public function rules (){
+    public function rules() {
         return [['cn'], 'required'];
     }
     

DataReader.php

Spacing +1 added lines, -1 removed lines

@@ -209,7 +209,7 @@
 
         $resource = $this->_conn->resource;
         
-        Yii::beginProfile('current:' . $this->key(), 'chrmorandi\ldap\DataReader');
+        Yii::beginProfile('current:'.$this->key(), 'chrmorandi\ldap\DataReader');
         $name = ldap_first_attribute($resource, $this->_row);
         
         while ($name) {