chrmorandi / yii2-ldap

Connection.php

Doc Comments +5 added lines, -3 removed lines

@@ -133,6 +133,10 @@ 
     protected $userDN;
     
     # Create AD password (Microsoft Active Directory password format)
+
+    /**
+     * @param string $password
+     */
     protected static function encodePassword($password) {
         $password = "\"" . $password . "\"";
         $adpassword = mb_convert_encoding($password, "UTF-16LE", "UTF-8");
@@ -230,7 +234,7 @@ 
      * Authenticate user
      * @param string $username
      * @param string $password
-     * @return int indicate occurrence of error. 
+     * @return boolean indicate occurrence of error. 
      */
     public function auth($username, $password)
     {
@@ -563,8 +567,6 @@ 
     
     /**
      * Send LDAP pagination control.
-     * @param int    $pageSize
-     * @param bool   $isCritical
      * @param string $cookie
      * @return bool
      */

Spacing +8 added lines, -8 removed lines

@@ -134,7 +134,7 @@ 
     
     # Create AD password (Microsoft Active Directory password format)
     protected static function encodePassword($password) {
-        $password = "\"" . $password . "\"";
+        $password = "\"".$password."\"";
         $adpassword = mb_convert_encoding($password, "UTF-16LE", "UTF-8");
         return $adpassword;
     }
@@ -183,7 +183,7 @@ 
      */
     public function open($anonymous = false)
     {
-        $token = 'Opening LDAP connection: ' . LdapUtils::recursive_implode($this->dc, ' or ');
+        $token = 'Opening LDAP connection: '.LdapUtils::recursive_implode($this->dc, ' or ');
         Yii::info($token, __METHOD__);
         Yii::beginProfile($token, __METHOD__);
         // Connect to the LDAP server.
@@ -240,7 +240,7 @@ 
         # Search for user and get user DN
         $searchResult = ldap_search($this->resource, $this->baseDn, "(&(objectClass=person)($this->loginAttribute=$username))", [$this->loginAttribute]);
         $entry = $this->getFirstEntry($searchResult);
-        if($entry) {
+        if ($entry) {
             $this->userDN = $this->getDn($entry);        
         } else {
             $this->userDN = null;
@@ -269,7 +269,7 @@ 
         }
 
         // Open connection with user
-        if(!$this->auth($username, $oldPassword)){
+        if (!$this->auth($username, $oldPassword)) {
             return false;
         }
         
@@ -326,20 +326,20 @@ 
         $this->open();
         $results = [];
         $cookie = '';        
-        $token = $function . ' - params: ' . LdapUtils::recursive_implode($params, ';');
+        $token = $function.' - params: '.LdapUtils::recursive_implode($params, ';');
 
-        Yii::info($token , 'chrmorandi\ldap\Connection::query');
+        Yii::info($token, 'chrmorandi\ldap\Connection::query');
        
         Yii::beginProfile($token, 'chrmorandi\ldap\Connection::query');
         do {
-            if($this->pageSize > 0) {
+            if ($this->pageSize > 0) {
                 $this->setControlPagedResult($cookie);
             }
             
             // Run the search.
             $result = call_user_func($function, $this->resource, ...$params);
             
-            if($this->pageSize > 0) {
+            if ($this->pageSize > 0) {
                 $this->setControlPagedResultResponse($result, $cookie);
             }