for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
/**
* Created by PhpStorm.
* User: chrl
* Date: 27/10/16
* Time: 11:08
*/
namespace Chrl\AppBundle\GameAction;
use Chrl\AppBundle\Entity\Game;
use Chrl\AppBundle\Entity\Question;
class StartAction extends BaseGameAction implements GameActionInterface
{
public function run($message, $user)
/** @var Game $game */
$game = $this->gameService->findGame($message);
if ($game->status == 0) {
$game->status = 1;
$this->gameService->em->persist($game);
$this->gameService->em->flush();
$this->botApi->sendMessage($message['chat']['id'], 'The game has started!');
} else {
$this->botApi->sendMessage($message['chat']['id'], 'The game is already running...');
$question = $this->gameService->getRandomQuestion();
$question
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
}
chrl /
buktopuha
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.