FrontRenderTest::testExceptionOnSyntax() - Code Metrics - Inspection of "Merge pull request #1 from christophe-chausseray/f..." - christophe-chausseray/front-render-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e3a66c...d34c1a )

by Christophe

created 2016-01-07 14:16 UTC

FrontRenderTest::testExceptionOnSyntax() A

↳ Parent: FrontRenderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	6
rs	9.4286
cc	1
eloc	3
nc	1
nop	0

<?php

namespace Chris\Bundle\FrontRenderBundle\Tests\Render;

use Chris\Bundle\FrontRenderBundle\Listener\TwigListener;
use Chris\Bundle\FrontRenderBundle\Render\FrontRender;
use InvalidArgumentException;
use Symfony\Bundle\TwigBundle\TwigEngine;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\EventDispatcher\EventDispatcher;
use Symfony\Component\Templating\TemplateNameParser;
use Twig_Error_Syntax;

class FrontRenderTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var string TEMPLATE_PATH
     */
    const TEMPLATE_PATH = 'Tests/Template';

    /**
     * @var string TEMPLATE
     */
    const TEMPLATE = 'index.html.twig';

    /**
     * @var string FAILED_TEMPLATE
     */
    const FAILED_TEMPLATE = 'failed.html.twig';

    /**
     * @var string FAILED_PATH
     */
    const FAILED_PATH = 'failedPath.html.twig';

    /**
     * @var EventDispatcher
     */
    protected $eventDispatcher;

    /**
     * @var \Twig_Loader_Filesystem
     */
    protected $twigLoader;

    /**
     * @var \Twig_Environment
     */
    protected $twigEnvironment;

    /**
     * @var TwigListener
     */
    protected $twigListener;

    /**
     * @var TemplateNameParser
     */
    protected $templateNameParser;

    /**
     * @var FileLocator
     */
    protected $fileLocator;

    /**
     * @var TwigEngine
     */
    protected $engine;

    /**
     * @var FrontRender
     */
    protected $frontRender;

    /**
     * Set up the front render test
     */
    public function setUp()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        parent::setUp();

        $this->eventDispatcher = \Phake::mock(EventDispatcher::class);

        $this->twigLoader      = \Phake::partialMock(\Twig_Loader_Filesystem::class, [$_SERVER['KERNEL_DIR'] . self::TEMPLATE_PATH]);

        $this->twigEnvironment = \Phake::partialMock(\Twig_Environment::class, $this->twigLoader);

        $this->twigListener    = \Phake::partialMock(TwigListener::class, $this->twigEnvironment);


        $this->templateNameParser = \Phake::mock(TemplateNameParser::class);

        $this->fileLocator        = \Phake::mock(FileLocator::class);

        $this->engine             = \Phake::partialMock(TwigEngine::class, $this->twigEnvironment, $this->templateNameParser, $this->fileLocator);


        $lexer = $this->twigListener->getLexer();

        $this->twigEnvironment->setLexer($lexer);

    }

    /**
     * Test render of the template with parameter
     */
    public function testTemplateRenderWithParameter()

    {
        $this->frontRender = new FrontRender($this->engine, $this->eventDispatcher, self::TEMPLATE);

        $this->frontRender->setParameters(
            [
                'applicationName' => 'Test Render',
            ]
        );

        $this->assertContains(
            'Welcome on Test Render',
            $this->frontRender->render()
        );
    }

    /**
     * Test render of the template without parameter
     */
    public function testTemplateRenderWithoutParameter()

    {
        $this->frontRender = new FrontRender($this->engine, $this->eventDispatcher, self::TEMPLATE);

        $this->assertNotContains(
            'Test Render',
            $this->frontRender->render()
        );
    }

    /**
     * Test on the update of lexer
     *
     * @dataProvider lexerTags
     *
     * @param string $oldTags
     * @param string $newTags
     */
    public function testSetLexer($oldTags, $newTags)
    {
        $this->frontRender = new FrontRender($this->engine, $this->eventDispatcher, self::TEMPLATE);

        $this->frontRender->setParameters(
            [
                'applicationName' => 'Test Render',
            ]
        );

        $render = $this->frontRender->render();

        $this->assertContains(
            $oldTags,
            $render
        );

        $this->assertNotContains(
            $newTags,
            $render
        );
    }

    /**
     * Test on the failed template
     *
     * @expectedException Twig_Error_Syntax
     */
    public function testExceptionOnSyntax()
    {
        $this->frontRender = new FrontRender($this->engine, $this->eventDispatcher, self::FAILED_TEMPLATE);

        $this->frontRender->render();
    }

    /**
     * Test when the template doesn't exist
     *
     * @expectedException InvalidArgumentException
     */
    public function testExceptionOnFailedPath()
    {
        $this->frontRender = new FrontRender($this->engine, $this->eventDispatcher, self::FAILED_PATH);

        $this->frontRender->render();
    }

    /**
     * Test when the template path is empty
     *
     * @expectedException Chris\Bundle\FrontRenderBundle\Exception\FrontRenderException
     */
    public function testExceptionOnEmptyPath()
    {
        $this->frontRender = new FrontRender($this->engine, $this->eventDispatcher, '');

        $this->frontRender->render();
    }

    /**
     * Provide the lexer tags
     *
     * @return array
     */
    public function lexerTags()
    {
        return [
            ['{#', '{*'],
            ['{%', '{@'],
            ['{{', '{$']
        ];

    }
}


1		<?php
2
3		namespace Chris\Bundle\FrontRenderBundle\Tests\Render;
4
5		use Chris\Bundle\FrontRenderBundle\Listener\TwigListener;
6		use Chris\Bundle\FrontRenderBundle\Render\FrontRender;
7		use InvalidArgumentException;
8		use Symfony\Bundle\TwigBundle\TwigEngine;
9		use Symfony\Component\Config\FileLocator;
10		use Symfony\Component\EventDispatcher\EventDispatcher;
11		use Symfony\Component\Templating\TemplateNameParser;
12		use Twig_Error_Syntax;
13
14		class FrontRenderTest extends \PHPUnit_Framework_TestCase
15		{
16		/**
17		* @var string TEMPLATE_PATH
18		*/
19		const TEMPLATE_PATH = 'Tests/Template';
20
21		/**
22		* @var string TEMPLATE
23		*/
24		const TEMPLATE = 'index.html.twig';
25
26		/**
27		* @var string FAILED_TEMPLATE
28		*/
29		const FAILED_TEMPLATE = 'failed.html.twig';
30
31		/**
32		* @var string FAILED_PATH
33		*/
34		const FAILED_PATH = 'failedPath.html.twig';
35
36		/**
37		* @var EventDispatcher
38		*/
39		protected $eventDispatcher;
40
41		/**
42		* @var \Twig_Loader_Filesystem
43		*/
44		protected $twigLoader;
45
46		/**
47		* @var \Twig_Environment
48		*/
49		protected $twigEnvironment;
50
51		/**
52		* @var TwigListener
53		*/
54		protected $twigListener;
55
56		/**
57		* @var TemplateNameParser
58		*/
59		protected $templateNameParser;
60
61		/**
62		* @var FileLocator
63		*/
64		protected $fileLocator;
65
66		/**
67		* @var TwigEngine
68		*/
69		protected $engine;
70
71		/**
72		* @var FrontRender
73		*/
74		protected $frontRender;
75
76		/**
77		* Set up the front render test
78		*/
79		public function setUp()
		0 ignored issues – show Coding Style introduced 2016-01-07 12:42 UTC by Report Bug Copy Issue Report `setUp` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
80		{
81		parent::setUp();
82
83		$this->eventDispatcher = \Phake::mock(EventDispatcher::class);
		0 ignored issues – show Documentation Bug introduced 2016-01-07 12:42 UTC by Report Bug Copy Issue Report It seems like `\Phake::mock(\Symfony\Co...EventDispatcher::class)` of type `object<Phake_IMock>` is incompatible with the declared type `object<Symfony\Component...atcher\EventDispatcher>` of property `$eventDispatcher`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
84		$this->twigLoader = \Phake::partialMock(\Twig_Loader_Filesystem::class, [$_SERVER['KERNEL_DIR'] . self::TEMPLATE_PATH]);
		0 ignored issues – show Documentation Bug introduced 2016-01-07 13:59 UTC by Report Bug Copy Issue Report It seems like `\Phake::partialMock(\Twi.... self::TEMPLATE_PATH))` of type `object<Phake_IMock>` is incompatible with the declared type `object<Twig_Loader_Filesystem>` of property `$twigLoader`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
85		$this->twigEnvironment = \Phake::partialMock(\Twig_Environment::class, $this->twigLoader);
		0 ignored issues – show Documentation Bug introduced 2016-01-07 12:42 UTC by Report Bug Copy Issue Report It seems like `\Phake::partialMock(\Twi...ass, $this->twigLoader)` of type `object<Phake_IMock>` is incompatible with the declared type `object<Twig_Environment>` of property `$twigEnvironment`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
86		$this->twigListener = \Phake::partialMock(TwigListener::class, $this->twigEnvironment);
		0 ignored issues – show Documentation Bug introduced 2016-01-07 12:42 UTC by Report Bug Copy Issue Report It seems like `\Phake::partialMock(\Chr...$this->twigEnvironment)` of type `object<Phake_IMock>` is incompatible with the declared type `object<Chris\Bundle\Fron...\Listener\TwigListener>` of property `$twigListener`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
87
88		$this->templateNameParser = \Phake::mock(TemplateNameParser::class);
		0 ignored issues – show Documentation Bug introduced 2016-01-07 12:42 UTC by Report Bug Copy Issue Report It seems like `\Phake::mock(\Symfony\Co...plateNameParser::class)` of type `object<Phake_IMock>` is incompatible with the declared type `object<Symfony\Component...ing\TemplateNameParser>` of property `$templateNameParser`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
89		$this->fileLocator = \Phake::mock(FileLocator::class);
		0 ignored issues – show Documentation Bug introduced 2016-01-07 12:42 UTC by Report Bug Copy Issue Report It seems like `\Phake::mock(\Symfony\Co...fig\FileLocator::class)` of type `object<Phake_IMock>` is incompatible with the declared type `object<Symfony\Component\Config\FileLocator>` of property `$fileLocator`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
90		$this->engine = \Phake::partialMock(TwigEngine::class, $this->twigEnvironment, $this->templateNameParser, $this->fileLocator);
		0 ignored issues – show Documentation Bug introduced 2016-01-07 12:42 UTC by Report Bug Copy Issue Report It seems like `\Phake::partialMock(\Sym...er, $this->fileLocator)` of type `object<Phake_IMock>` is incompatible with the declared type `object<Symfony\Bundle\TwigBundle\TwigEngine>` of property `$engine`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
91
92		$lexer = $this->twigListener->getLexer();
		0 ignored issues – show Bug introduced 2016-01-07 12:42 UTC by Report Bug Copy Issue Report The method `getLexer()` does not seem to exist on `object<Phake_IMock>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
93		$this->twigEnvironment->setLexer($lexer);
		0 ignored issues – show Bug introduced 2016-01-07 12:42 UTC by Report Bug Copy Issue Report The method `setLexer()` does not seem to exist on `object<Phake_IMock>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
94		}
95
96		/**
97		* Test render of the template with parameter
98		*/
99	View Code Duplication	public function testTemplateRenderWithParameter()
		0 ignored issues – show Duplication introduced 2016-01-07 12:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
100		{
101		$this->frontRender = new FrontRender($this->engine, $this->eventDispatcher, self::TEMPLATE);
102
103		$this->frontRender->setParameters(
104		[
105		'applicationName' => 'Test Render',
106		]
107		);
108
109		$this->assertContains(
110		'Welcome on Test Render',
111		$this->frontRender->render()
112		);
113		}
114
115		/**
116		* Test render of the template without parameter
117		*/
118	View Code Duplication	public function testTemplateRenderWithoutParameter()
		0 ignored issues – show Duplication introduced 2016-01-07 12:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
119		{
120		$this->frontRender = new FrontRender($this->engine, $this->eventDispatcher, self::TEMPLATE);
121
122		$this->assertNotContains(
123		'Test Render',
124		$this->frontRender->render()
125		);
126		}
127
128		/**
129		* Test on the update of lexer
130		*
131		* @dataProvider lexerTags
132		*
133		* @param string $oldTags
134		* @param string $newTags
135		*/
136		public function testSetLexer($oldTags, $newTags)
137		{
138		$this->frontRender = new FrontRender($this->engine, $this->eventDispatcher, self::TEMPLATE);
139
140		$this->frontRender->setParameters(
141		[
142		'applicationName' => 'Test Render',
143		]
144		);
145
146		$render = $this->frontRender->render();
147
148		$this->assertContains(
149		$oldTags,
150		$render
151		);
152
153		$this->assertNotContains(
154		$newTags,
155		$render
156		);
157		}
158
159		/**
160		* Test on the failed template
161		*
162		* @expectedException Twig_Error_Syntax
163		*/
164		public function testExceptionOnSyntax()
165		{
166		$this->frontRender = new FrontRender($this->engine, $this->eventDispatcher, self::FAILED_TEMPLATE);
167
168		$this->frontRender->render();
169		}
170
171		/**
172		* Test when the template doesn't exist
173		*
174		* @expectedException InvalidArgumentException
175		*/
176		public function testExceptionOnFailedPath()
177		{
178		$this->frontRender = new FrontRender($this->engine, $this->eventDispatcher, self::FAILED_PATH);
179
180		$this->frontRender->render();
181		}
182
183		/**
184		* Test when the template path is empty
185		*
186		* @expectedException Chris\Bundle\FrontRenderBundle\Exception\FrontRenderException
187		*/
188		public function testExceptionOnEmptyPath()
189		{
190		$this->frontRender = new FrontRender($this->engine, $this->eventDispatcher, '');
191
192		$this->frontRender->render();
193		}
194
195		/**
196		* Provide the lexer tags
197		*
198		* @return array
199		*/
200		public function lexerTags()
201		{
202		return [
203		['{#', '{*'],
204		['{%', '{@'],
205		['{{', '{$']
206		];
207
208		}
209		}
210

christophe-chausseray / front-render-bundle

Push — master ( e3a66c...d34c1a )

FrontRenderTest::testExceptionOnSyntax() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like