Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
14 | class FrontRenderTest extends \PHPUnit_Framework_TestCase |
||
15 | { |
||
16 | /** |
||
17 | * @var string TEMPLATE_PATH |
||
18 | */ |
||
19 | const TEMPLATE_PATH = 'Tests/Template'; |
||
20 | |||
21 | /** |
||
22 | * @var string TEMPLATE |
||
23 | */ |
||
24 | const TEMPLATE = 'index.html.twig'; |
||
25 | |||
26 | /** |
||
27 | * @var string FAILED_TEMPLATE |
||
28 | */ |
||
29 | const FAILED_TEMPLATE = 'failed.html.twig'; |
||
30 | |||
31 | /** |
||
32 | * @var string FAILED_PATH |
||
33 | */ |
||
34 | const FAILED_PATH = 'failedPath.html.twig'; |
||
35 | |||
36 | /** |
||
37 | * @var EventDispatcher |
||
38 | */ |
||
39 | protected $eventDispatcher; |
||
40 | |||
41 | /** |
||
42 | * @var \Twig_Loader_Filesystem |
||
43 | */ |
||
44 | protected $twigLoader; |
||
45 | |||
46 | /** |
||
47 | * @var \Twig_Environment |
||
48 | */ |
||
49 | protected $twigEnvironment; |
||
50 | |||
51 | /** |
||
52 | * @var TwigListener |
||
53 | */ |
||
54 | protected $twigListener; |
||
55 | |||
56 | /** |
||
57 | * @var TemplateNameParser |
||
58 | */ |
||
59 | protected $templateNameParser; |
||
60 | |||
61 | /** |
||
62 | * @var FileLocator |
||
63 | */ |
||
64 | protected $fileLocator; |
||
65 | |||
66 | /** |
||
67 | * @var TwigEngine |
||
68 | */ |
||
69 | protected $engine; |
||
70 | |||
71 | /** |
||
72 | * @var FrontRender |
||
73 | */ |
||
74 | protected $frontRender; |
||
75 | |||
76 | /** |
||
77 | * Set up the front render test |
||
78 | */ |
||
79 | public function setUp() |
||
95 | |||
96 | /** |
||
97 | * Test render of the template with parameter |
||
98 | */ |
||
99 | View Code Duplication | public function testTemplateRenderWithParameter() |
|
114 | |||
115 | /** |
||
116 | * Test render of the template without parameter |
||
117 | */ |
||
118 | View Code Duplication | public function testTemplateRenderWithoutParameter() |
|
127 | |||
128 | /** |
||
129 | * Test on the update of lexer |
||
130 | * |
||
131 | * @dataProvider lexerTags |
||
132 | * |
||
133 | * @param string $oldTags |
||
134 | * @param string $newTags |
||
135 | */ |
||
136 | public function testSetLexer($oldTags, $newTags) |
||
158 | |||
159 | /** |
||
160 | * Test on the failed template |
||
161 | * |
||
162 | * @expectedException Twig_Error_Syntax |
||
163 | */ |
||
164 | public function testExceptionOnSyntax() |
||
170 | |||
171 | /** |
||
172 | * Test when the template doesn't exist |
||
173 | * |
||
174 | * @expectedException InvalidArgumentException |
||
175 | */ |
||
176 | public function testExceptionOnFailedPath() |
||
182 | |||
183 | /** |
||
184 | * Test when the template path is empty |
||
185 | * |
||
186 | * @expectedException Chris\Bundle\FrontRenderBundle\Exception\FrontRenderException |
||
187 | */ |
||
188 | public function testExceptionOnEmptyPath() |
||
194 | |||
195 | /** |
||
196 | * Provide the lexer tags |
||
197 | * |
||
198 | * @return array |
||
199 | */ |
||
200 | public function lexerTags() |
||
209 | } |
||
210 |
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: