PostsHaveACategory::hasAnyCategory() - Code Metrics - Inspection of "Additional fields for posts and methods for post f..." - chrisjk123/laravel-blogger - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8f843b...36053e )

by Christopher

created 2019-12-31 10:31 UTC

PostsHaveACategory::hasAnyCategory() A

↳ Parent: PostsHaveACategory

Complexity

Conditions	4
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.7998
c	0
b	0
f	0
cc	4
nc	6
nop	1

<?php

namespace Chriscreates\Blog\Traits\Post;

use Chriscreates\Blog\Category;
use Illuminate\Support\Collection;

trait PostsHaveACategory
{
    public function hasCategory($category)
    {
        if ($category instanceof Category) {
            $category = $category->id;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }

        if (is_null($this->category)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return false;
        }

        return $category_id == $this->category->id;

    }

    public function hasAnyCategory($categories)
    {
        if ($categories instanceof Collection) {
            $categories = $categories->pluck('id')->toArray();
        }

        foreach ($categories as $category) {
            if ($this->hasCategory($category)) {
                return true;
            }
        }

        return false;
    }
}


1			<?php
2
3			namespace Chriscreates\Blog\Traits\Post;
4
5			use Chriscreates\Blog\Category;
6			use Illuminate\Support\Collection;
7
8			trait PostsHaveACategory
9			{
10			public function hasCategory($category)
11			{
12			if ($category instanceof Category) {
13			$category = $category->id;
			0 ignored issues – show Unused Code introduced 2019-12-31 10:32 UTC by Report Bug Copy Issue Report `$category` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
14			}
15
16			if (is_null($this->category)) {
			0 ignored issues – show Bug introduced 2019-12-31 10:32 UTC by Report Bug Copy Issue Report The property `category` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17			return false;
18			}
19
20			return $category_id == $this->category->id;
			0 ignored issues – show Bug introduced 2019-12-31 10:32 UTC by Report Bug Copy Issue Report The variable `$category_id` does not exist. Did you mean `$category`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
21			}
22
23			public function hasAnyCategory($categories)
24			{
25			if ($categories instanceof Collection) {
26			$categories = $categories->pluck('id')->toArray();
27			}
28
29			foreach ($categories as $category) {
30			if ($this->hasCategory($category)) {
31			return true;
32			}
33			}
34
35			return false;
36			}
37			}
38

chrisjk123 / laravel-blogger

Push — master ( 8f843b...36053e )

PostsHaveACategory::hasAnyCategory() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like