for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace Chriscreates\Blog\Traits\Post;
use Chriscreates\Blog\Category;
use Illuminate\Support\Collection;
trait PostsHaveACategory
{
public function hasCategory($category)
if ($category instanceof Category) {
$category = $category->id;
$category
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
}
if (is_null($this->category)) {
category
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
class MyClass { } $x = new MyClass(); $x->foo = true;
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:
class MyClass { public $foo; } $x = new MyClass(); $x->foo = true;
return false;
return $category_id == $this->category->id;
$category_id
This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name.
The variable may have been renamed without also renaming all references.
public function hasAnyCategory($categories)
if ($categories instanceof Collection) {
$categories = $categories->pluck('id')->toArray();
foreach ($categories as $category) {
if ($this->hasCategory($category)) {
return true;
chrisjk123 /
laravel-blogger
Loading history...
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.