SecretBox::open() - Code Metrics - Inspection of ":sparkles:" - chillerlan/php-traits - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d732f2...827150 )

by smiley

created 2018-01-25 05:30 UTC

SecretBox::open() A

↳ Parent: SecretBox

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	2

<?php
/**
 * Class SecretBox
 *
 * @filesource   SecretBox.php
 * @created      25.01.2018
 * @package      chillerlan\Traits\Crypto
 * @author       Smiley <[email protected]>
 * @copyright    2018 Smiley
 * @license      MIT
 */

namespace chillerlan\Traits\Crypto;

class SecretBox extends CryptoBox{

	public function create(string $message, string $nonce_bin = null):CryptoBoxInterface{
		$this->checkKeypair(SODIUM_CRYPTO_BOX_SECRETKEYBYTES);

		$message     = $this->checkMessage($message);
		$this->nonce = $nonce_bin ?? random_bytes(SODIUM_CRYPTO_BOX_NONCEBYTES);
		$this->box   = sodium_crypto_secretbox($message, $this->nonce, $this->keypair->secret);


		sodium_memzero($message);

		if($nonce_bin !== null){
			sodium_memzero($nonce_bin);
		}

		return $this;
	}

	public function open(string $box_bin, string $nonce_bin):CryptoBoxInterface{
		$this->checkKeypair(SODIUM_CRYPTO_BOX_SECRETKEYBYTES);

		$this->message = sodium_crypto_secretbox_open($box_bin, $nonce_bin, $this->keypair->secret);


		if($this->message === false){

			throw new CryptoException('invalid box');
		}

		return $this;
	}

}


1			<?php
2			/**
3			* Class SecretBox
4			*
5			* @filesource SecretBox.php
6			* @created 25.01.2018
7			* @package chillerlan\Traits\Crypto
8			* @author Smiley <[email protected]>
9			* @copyright 2018 Smiley
10			* @license MIT
11			*/
12
13			namespace chillerlan\Traits\Crypto;
14
15			class SecretBox extends CryptoBox{
16
17			public function create(string $message, string $nonce_bin = null):CryptoBoxInterface{
18			$this->checkKeypair(SODIUM_CRYPTO_BOX_SECRETKEYBYTES);
19
20			$message = $this->checkMessage($message);
21			$this->nonce = $nonce_bin ?? random_bytes(SODIUM_CRYPTO_BOX_NONCEBYTES);
22			$this->box = sodium_crypto_secretbox($message, $this->nonce, $this->keypair->secret);
			0 ignored issues – show Bug introduced 2018-01-25 05:32 UTC by Report Bug Copy Issue Report Accessing `secret` on the interface `chillerlan\Traits\Crypto\CryptoKeyInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
23
24			sodium_memzero($message);
25
26			if($nonce_bin !== null){
27			sodium_memzero($nonce_bin);
28			}
29
30			return $this;
31			}
32
33			public function open(string $box_bin, string $nonce_bin):CryptoBoxInterface{
34			$this->checkKeypair(SODIUM_CRYPTO_BOX_SECRETKEYBYTES);
35
36			$this->message = sodium_crypto_secretbox_open($box_bin, $nonce_bin, $this->keypair->secret);
			0 ignored issues – show Bug introduced 2018-01-25 05:32 UTC by Report Bug Copy Issue Report Accessing `secret` on the interface `chillerlan\Traits\Crypto\CryptoKeyInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
37
38			if($this->message === false){
			0 ignored issues – show introduced 2018-01-25 05:32 UTC by Report Bug Copy Issue Report The condition `$this->message === false` can never be `true`. Loading history...
39			throw new CryptoException('invalid box');
40			}
41
42			return $this;
43			}
44
45			}
46

chillerlan / php-traits

Push — master ( d732f2...827150 )

SecretBox::open() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like