chillerlan\Traits\Crypto\SecretBox

Complexity

Total Complexity

4

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	open()	0	10	2
A	create()	0	14	2

<?php
/**
 * Class SecretBox
 *
 * @filesource   SecretBox.php
 * @created      25.01.2018
 * @package      chillerlan\Traits\Crypto
 * @author       Smiley <smiley@chillerlan.net>
 * @copyright    2018 Smiley
 * @license      MIT
 */

namespace chillerlan\Traits\Crypto;

class SecretBox extends CryptoBox{

	public function create(string $message, string $nonce_bin = null):CryptoBoxInterface{
		$this->checkKeypair(SODIUM_CRYPTO_BOX_SECRETKEYBYTES);

		$message     = $this->checkMessage($message);
		$this->nonce = $nonce_bin ?? random_bytes(SODIUM_CRYPTO_BOX_NONCEBYTES);
		$this->box   = sodium_crypto_secretbox($message, $this->nonce, $this->keypair->secret);

Accessing secret on the interface chillerlan\Traits\Crypto\CryptoKeyInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

		sodium_memzero($message);

		if($nonce_bin !== null){
			sodium_memzero($nonce_bin);
		}

		return $this;
	}

	public function open(string $box_bin, string $nonce_bin):CryptoBoxInterface{
		$this->checkKeypair(SODIUM_CRYPTO_BOX_SECRETKEYBYTES);

		$this->message = sodium_crypto_secretbox_open($box_bin, $nonce_bin, $this->keypair->secret);

Accessing secret on the interface chillerlan\Traits\Crypto\CryptoKeyInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

		if($this->message === false){

The condition $this->message === false can never be true.

			throw new CryptoException('invalid box');
		}

		return $this;
	}

}