Inspection of ":octocat:" - chillerlan/php-qrcode - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (03e903)

by smiley

created 2016-03-21 11:42 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@
 block discarded – undo
 	/**
 	 * @param \chillerlan\QRCode\BitBuffer $buffer
 	 */
-	public function write(BitBuffer &$buffer){
+	public function write(BitBuffer&$buffer){
 		$i = 0;
 
 		while($i + 2 < $this->dataLength){

Please login to merge, or discard this patch.

src/Data/QRDataInterface.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@
 block discarded – undo
 	/**
 	 * @param \chillerlan\QRCode\BitBuffer $buffer
 	 */
-	public function write(BitBuffer &$buffer);
+	public function write(BitBuffer&$buffer);
 
 	/**
 	 * @param $type

Please login to merge, or discard this patch.

src/Polynomial.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -76,7 +76,7 @@
 block discarded – undo
 		}
 
 		for($i = 8; $i < 256; $i++){
-			$this->EXP_TABLE[$i] = $this->EXP_TABLE[$i - 4] ^ $this->EXP_TABLE[$i - 5] ^ $this->EXP_TABLE[$i - 6] ^ $this->EXP_TABLE[$i - 8];
+			$this->EXP_TABLE[$i] = $this->EXP_TABLE[$i - 4]^$this->EXP_TABLE[$i - 5]^$this->EXP_TABLE[$i - 6]^$this->EXP_TABLE[$i - 8];
 		}
 
 		for($i = 0; $i < 255; $i++){

Please login to merge, or discard this patch.

src/QRConst.php 1 patch

Spacing +33 added lines, -33 removed lines patch added patch discarded remove patch

		@@ -25,16 +25,16 @@ discard block
		block discarded – undo
25	25	];
26	26
27	27	const MAX_BITS = [
28		- QRCode::TYPE_01 => [ 128, 152, 72, 104],
29		- QRCode::TYPE_02 => [ 224, 272, 128, 176],
30		- QRCode::TYPE_03 => [ 352, 440, 208, 272],
31		- QRCode::TYPE_04 => [ 512, 640, 288, 384],
32		- QRCode::TYPE_05 => [ 688, 864, 368, 496],
33		- QRCode::TYPE_06 => [ 864, 1088, 480, 608],
34		- QRCode::TYPE_07 => [ 992, 1248, 528, 704],
35		- QRCode::TYPE_08 => [1232, 1552, 688, 880],
36		- QRCode::TYPE_09 => [1456, 1856, 800, 1056],
37		- QRCode::TYPE_10 => [1728, 2192, 976, 1232],
	28	+ QRCode::TYPE_01 => [128, 152, 72, 104],
	29	+ QRCode::TYPE_02 => [224, 272, 128, 176],
	30	+ QRCode::TYPE_03 => [352, 440, 208, 272],
	31	+ QRCode::TYPE_04 => [512, 640, 288, 384],
	32	+ QRCode::TYPE_05 => [688, 864, 368, 496],
	33	+ QRCode::TYPE_06 => [864, 1088, 480, 608],
	34	+ QRCode::TYPE_07 => [992, 1248, 528, 704],
	35	+ QRCode::TYPE_08 => [1232, 1552, 688, 880],
	36	+ QRCode::TYPE_09 => [1456, 1856, 800, 1056],
	37	+ QRCode::TYPE_10 => [1728, 2192, 976, 1232],
38	38	];
39	39
40	40	const MODE_NUMBER = 1 << 0;
		@@ -66,16 +66,16 @@ discard block
		block discarded – undo
66	66	const PAD1 = 0x11;
67	67
68	68	const MAX_LENGTH = [
69		- [[ 41, 25, 17, 10], [ 34, 20, 14, 8], [ 27, 16, 11, 7], [ 17, 10, 7, 4]],
70		- [[ 77, 47, 32, 20], [ 63, 38, 26, 16], [ 48, 29, 20, 12], [ 34, 20, 14, 8]],
71		- [[127, 77, 53, 32], [101, 61, 42, 26], [ 77, 47, 32, 20], [ 58, 35, 24, 15]],
72		- [[187, 114, 78, 48], [149, 90, 62, 38], [111, 67, 46, 28], [ 82, 50, 34, 21]],
73		- [[255, 154, 106, 65], [202, 122, 84, 52], [144, 87, 60, 37], [106, 64, 44, 27]],
74		- [[322, 195, 134, 82], [255, 154, 106, 65], [178, 108, 74, 45], [139, 84, 58, 36]],
75		- [[370, 224, 154, 95], [293, 178, 122, 75], [207, 125, 86, 53], [154, 93, 64, 39]],
76		- [[461, 279, 192, 118], [365, 221, 152, 93], [259, 157, 108, 66], [202, 122, 84, 52]],
77		- [[552, 335, 230, 141], [432, 262, 180, 111], [312, 189, 130, 80], [235, 143, 98, 60]],
78		- [[652, 395, 271, 167], [513, 311, 213, 131], [364, 221, 151, 93], [288, 174, 119, 74]],
	69	+ [[41, 25, 17, 10], [34, 20, 14, 8], [27, 16, 11, 7], [17, 10, 7, 4]],
	70	+ [[77, 47, 32, 20], [63, 38, 26, 16], [48, 29, 20, 12], [34, 20, 14, 8]],
	71	+ [[127, 77, 53, 32], [101, 61, 42, 26], [77, 47, 32, 20], [58, 35, 24, 15]],
	72	+ [[187, 114, 78, 48], [149, 90, 62, 38], [111, 67, 46, 28], [82, 50, 34, 21]],
	73	+ [[255, 154, 106, 65], [202, 122, 84, 52], [144, 87, 60, 37], [106, 64, 44, 27]],
	74	+ [[322, 195, 134, 82], [255, 154, 106, 65], [178, 108, 74, 45], [139, 84, 58, 36]],
	75	+ [[370, 224, 154, 95], [293, 178, 122, 75], [207, 125, 86, 53], [154, 93, 64, 39]],
	76	+ [[461, 279, 192, 118], [365, 221, 152, 93], [259, 157, 108, 66], [202, 122, 84, 52]],
	77	+ [[552, 335, 230, 141], [432, 262, 180, 111], [312, 189, 130, 80], [235, 143, 98, 60]],
	78	+ [[652, 395, 271, 167], [513, 311, 213, 131], [364, 221, 151, 93], [288, 174, 119, 74]],
79	79	];
80	80
81	81	const BLOCK_TABLE = [
		@@ -83,7 +83,7 @@ discard block
		block discarded – undo
83	83	[1, 26, 19], // L
84	84	[1, 26, 16], // M
85	85	[1, 26, 13], // Q
86		- [1, 26, 9], // H
	86	+ [1, 26, 9], // H
87	87	// 2
88	88	[1, 44, 34],
89	89	[1, 44, 28],
		@@ -96,14 +96,14 @@ discard block
		block discarded – undo
96	96	[2, 35, 13],
97	97	// 4
98	98	[1, 100, 80],
99		- [2, 50, 32],
100		- [2, 50, 24],
101		- [4, 25, 9],
	99	+ [2, 50, 32],
	100	+ [2, 50, 24],
	101	+ [4, 25, 9],
102	102	// 5
103	103	[1, 134, 108],
104		- [2, 67, 43],
105		- [2, 33, 15, 2, 34, 16],
106		- [2, 33, 11, 2, 34, 12],
	104	+ [2, 67, 43],
	105	+ [2, 33, 15, 2, 34, 16],
	106	+ [2, 33, 11, 2, 34, 12],
107	107	// 6
108	108	[2, 86, 68],
109	109	[4, 43, 27],
		@@ -116,14 +116,14 @@ discard block
		block discarded – undo
116	116	[4, 39, 13, 1, 40, 14],
117	117	// 8
118	118	[2, 121, 97],
119		- [2, 60, 38, 2, 61, 39],
120		- [4, 40, 18, 2, 41, 19],
121		- [4, 40, 14, 2, 41, 15],
	119	+ [2, 60, 38, 2, 61, 39],
	120	+ [4, 40, 18, 2, 41, 19],
	121	+ [4, 40, 14, 2, 41, 15],
122	122	// 9
123	123	[2, 146, 116],
124		- [3, 58, 36, 2, 59, 37],
125		- [4, 36, 16, 4, 37, 17],
126		- [4, 36, 12, 4, 37, 13],
	124	+ [3, 58, 36, 2, 59, 37],
	125	+ [4, 36, 16, 4, 37, 17],
	126	+ [4, 36, 12, 4, 37, 13],
127	127	// 10
128	128	[2, 86, 68, 2, 87, 69],
129	129	[4, 69, 43, 1, 70, 44],

Please login to merge, or discard this patch.

src/Data/AlphaNum.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@
 block discarded – undo
 	/**
 	 * @param \chillerlan\QRCode\BitBuffer $buffer
 	 */
-	public function write(BitBuffer &$buffer){
+	public function write(BitBuffer&$buffer){
 		$i = 0;
 
 		while($i + 2 < $this->dataLength){

Please login to merge, or discard this patch.

src/Data/Byte.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@
 block discarded – undo
 	/**
 	 * @param \chillerlan\QRCode\BitBuffer $buffer
 	 */
-	public function write(BitBuffer &$buffer){
+	public function write(BitBuffer&$buffer){
 		$i = 0;
 
 		while($i + 2 < $this->dataLength){

Please login to merge, or discard this patch.

src/Data/Kanji.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@
 block discarded – undo
 	/**
 	 * @param \chillerlan\QRCode\BitBuffer $buffer
 	 */
-	public function write(BitBuffer &$buffer){
+	public function write(BitBuffer&$buffer){
 		$i = 0;
 
 		while($i + 2 < $this->dataLength){

Please login to merge, or discard this patch.

src/QRCode.php 2 patches

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -292,7 +292,7 @@  discard block
 block discarded – undo
 			foreach($range2 as $col){
 
 				if(
-					    $this->matrix[$row][$col    ]
+						$this->matrix[$row][$col    ]
 					&& !$this->matrix[$row][$col + 1]
 					&&  $this->matrix[$row][$col + 2]
 					&&  $this->matrix[$row][$col + 3]
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
 			foreach($range2 as $row){
 
 				if(
-					    $this->matrix[$row    ][$col]
+						$this->matrix[$row    ][$col]
 					&& !$this->matrix[$row + 1][$col]
 					&&  $this->matrix[$row + 2][$col]
 					&&  $this->matrix[$row + 3][$col]
@@ -649,7 +649,7 @@  discard block
 block discarded – undo
 				for($row = -2; $row <= 2; $row++){
 					for($col = -2; $col <= 2; $col++){
 						$this->matrix[$posI + $row][$posJ + $col] =
-							    $row === -2 || $row === 2
+								$row === -2 || $row === 2
 							||  $col === -2 || $col === 2
 							|| ($row ===  0 && $col === 0);
 					}

Please login to merge, or discard this patch.

Spacing +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -41,15 +41,15 @@  discard block
 block discarded – undo
 	const ERROR_CORRECT_LEVEL_H = 2; // 30%.
 
 	// max bits @ ec level L:07 M:15 Q:25 H:30 %
-	const TYPE_01 =  1; //  152  128  104   72
-	const TYPE_02 =  2; //  272  224  176  128
-	const TYPE_03 =  3; //  440  352  272  208
-	const TYPE_04 =  4; //  640  512  384  288
-	const TYPE_05 =  5; //  864  688  496  368
-	const TYPE_06 =  6; // 1088  864  608  480
-	const TYPE_07 =  7; // 1248  992  704  528
-	const TYPE_08 =  8; // 1552 1232  880  688
-	const TYPE_09 =  9; // 1856 1456 1056  800
+	const TYPE_01 = 1; //  152  128  104   72
+	const TYPE_02 = 2; //  272  224  176  128
+	const TYPE_03 = 3; //  440  352  272  208
+	const TYPE_04 = 4; //  640  512  384  288
+	const TYPE_05 = 5; //  864  688  496  368
+	const TYPE_06 = 6; // 1088  864  608  480
+	const TYPE_07 = 7; // 1248  992  704  528
+	const TYPE_08 = 8; // 1552 1232  880  688
+	const TYPE_09 = 9; // 1856 1456 1056  800
 	const TYPE_10 = 10; // 2192 1728 1232  976
 
 	/**
@@ -265,9 +265,9 @@  discard block
 block discarded – undo
 				$count = 0;
 
 				if(
-					   $this->matrix[$row    ][$col    ]
-					|| $this->matrix[$row    ][$col + 1]
-					|| $this->matrix[$row + 1][$col    ]
+					   $this->matrix[$row][$col]
+					|| $this->matrix[$row][$col + 1]
+					|| $this->matrix[$row + 1][$col]
 					|| $this->matrix[$row + 1][$col + 1]
 				){
 					$count++;
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
 			foreach($range2 as $col){
 
 				if(
-					    $this->matrix[$row][$col    ]
+					    $this->matrix[$row][$col]
 					&& !$this->matrix[$row][$col + 1]
 					&&  $this->matrix[$row][$col + 2]
 					&&  $this->matrix[$row][$col + 3]
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
 			foreach($range2 as $row){
 
 				if(
-					    $this->matrix[$row    ][$col]
+					    $this->matrix[$row][$col]
 					&& !$this->matrix[$row + 1][$col]
 					&&  $this->matrix[$row + 2][$col]
 					&&  $this->matrix[$row + 3][$col]
@@ -349,11 +349,11 @@  discard block
 block discarded – undo
 		$this->lostPoint = 0;
 		$this->darkCount = 0;
 
-		$range = range(0, $this->pixelCount-1);
+		$range = range(0, $this->pixelCount - 1);
 
 		$this->testLevel1($range);
-		$this->testLevel2(range(0, $this->pixelCount-2));
-		$this->testLevel3($range, range(0, $this->pixelCount-7));
+		$this->testLevel2(range(0, $this->pixelCount - 2));
+		$this->testLevel3($range, range(0, $this->pixelCount - 7));
 		$this->testLevel4($range);
 
 		$this->lostPoint += (abs(100 * $this->darkCount / $this->pixelCount / $this->pixelCount - 50) / 5) * 10;
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
 			$a = (int)floor($i / 3);
 			$b = $i % 3 + $this->pixelCount - 8 - 3;
 
-			$this->matrix[$a][$b] = $this->matrix[$b][$a] = !$test && (($bits >> $i) & 1) === 1;
+			$this->matrix[$a][$b] = $this->matrix[$b][$a] = !$test && (($bits >> $i)&1) === 1;
 			$i++;
 		}
 
@@ -387,13 +387,13 @@  discard block
 block discarded – undo
 	 */
 	protected function setTypeInfo($test, $pattern){
 		$this->setPattern();
-		$bits = Util::getBCHTypeInfo(($this->errorCorrectLevel << 3) | $pattern);
+		$bits = Util::getBCHTypeInfo(($this->errorCorrectLevel << 3)|$pattern);
 		$i = 0;
 		while($i < 15){
-			$mod = !$test && (($bits >> $i) & 1) === 1;
+			$mod = !$test && (($bits >> $i)&1) === 1;
 
 			switch(true){
-				case $i < 6: $this->matrix[$i    ][8] = $mod; break;
+				case $i < 6: $this->matrix[$i][8] = $mod; break;
 				case $i < 8: $this->matrix[$i + 1][8] = $mod; break;
 				default:
 					$this->matrix[$this->pixelCount - 15 + $i][8] = $mod;
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
 
 			switch(true){
 				case $i < 8: $this->matrix[8][$this->pixelCount - $i - 1] = $mod; break;
-				case $i < 9: $this->matrix[8][           15 + 1 - $i - 1] = $mod; break;
+				case $i < 9: $this->matrix[8][15 + 1 - $i - 1] = $mod; break;
 				default:
 					$this->matrix[8][15 - $i - 1] = $mod;
 			}
@@ -481,7 +481,7 @@  discard block
 block discarded – undo
 
 			foreach($dcdata[$key] as $i => &$_dcdata){
 				$bdata = $this->bitBuffer->buffer;
-				$_dcdata = 0xff & $bdata[$i + $offset];
+				$_dcdata = 0xff&$bdata[$i + $offset];
 			}
 
 			$offset += $rsBlockDataCount;
@@ -563,7 +563,7 @@  discard block
 block discarded – undo
 						$dark = false;
 
 						if($byteIndex < $dataCount){
-							$dark = (($data[$byteIndex] >> $bitIndex) & 1) === 1;
+							$dark = (($data[$byteIndex] >> $bitIndex)&1) === 1;
 						}
 
 						$a = $row + $_col;
@@ -626,7 +626,7 @@  discard block
 block discarded – undo
 					$this->matrix[$row + $r][$col + $c] =
 						(0 <= $r && $r <= 6 && ($c === 0 || $c === 6))
 						|| (0 <= $c && $c <= 6 && ($r === 0 || $r === 6))
-						|| (2 <= $c && $c <= 4 &&  2 <= $r && $r <= 4);
+						|| (2 <= $c && $c <= 4 && 2 <= $r && $r <= 4);
 				}
 				$r++;
 			}
@@ -651,7 +651,7 @@  discard block
 block discarded – undo
 						$this->matrix[$posI + $row][$posJ + $col] =
 							    $row === -2 || $row === 2
 							||  $col === -2 || $col === 2
-							|| ($row ===  0 && $col === 0);
+							|| ($row === 0 && $col === 0);
 					}
 				}
 			}

Please login to merge, or discard this patch.

src/Output/QRImage.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -63,8 +63,8 @@
 block discarded – undo
 			foreach($row as $c => $pixel){
 				if($pixel){
 					imagefilledrectangle($image,
-						$this->options->marginSize +  $c      * $this->options->pixelSize,
-						$this->options->marginSize +  $r      * $this->options->pixelSize,
+						$this->options->marginSize + $c * $this->options->pixelSize,
+						$this->options->marginSize + $r * $this->options->pixelSize,
 						$this->options->marginSize + ($c + 1) * $this->options->pixelSize - 1,
 						$this->options->marginSize + ($r + 1) * $this->options->pixelSize - 1,
 						$foreground);

Please login to merge, or discard this patch.

		@@ -33,7 +33,7 @@
		block discarded – undo
33	33	/**
34	34	* @param \chillerlan\QRCode\BitBuffer $buffer
35	35	*/
36		- public function write(BitBuffer &$buffer){
	36	+ public function write(BitBuffer&$buffer){
37	37	$i = 0;
38	38
39	39	while($i + 2 < $this->dataLength){

		@@ -22,7 +22,7 @@
		block discarded – undo
22	22	/**
23	23	* @param \chillerlan\QRCode\BitBuffer $buffer
24	24	*/
25		- public function write(BitBuffer &$buffer);
	25	+ public function write(BitBuffer&$buffer);
26	26
27	27	/**
28	28	* @param $type

		@@ -76,7 +76,7 @@
		block discarded – undo
76	76	}
77	77
78	78	for($i = 8; $i < 256; $i++){
79		- $this->EXP_TABLE[$i] = $this->EXP_TABLE[$i - 4] ^ $this->EXP_TABLE[$i - 5] ^ $this->EXP_TABLE[$i - 6] ^ $this->EXP_TABLE[$i - 8];
	79	+ $this->EXP_TABLE[$i] = $this->EXP_TABLE[$i - 4]^$this->EXP_TABLE[$i - 5]^$this->EXP_TABLE[$i - 6]^$this->EXP_TABLE[$i - 8];
80	80	}
81	81
82	82	for($i = 0; $i < 255; $i++){

		@@ -292,7 +292,7 @@ discard block
		block discarded – undo
292	292	foreach($range2 as $col){
293	293
294	294	if(
295		- $this->matrix[$row][$col ]
	295	+ $this->matrix[$row][$col ]
296	296	&& !$this->matrix[$row][$col + 1]
297	297	&& $this->matrix[$row][$col + 2]
298	298	&& $this->matrix[$row][$col + 3]
		@@ -310,7 +310,7 @@ discard block
		block discarded – undo
310	310	foreach($range2 as $row){
311	311
312	312	if(
313		- $this->matrix[$row ][$col]
	313	+ $this->matrix[$row ][$col]
314	314	&& !$this->matrix[$row + 1][$col]
315	315	&& $this->matrix[$row + 2][$col]
316	316	&& $this->matrix[$row + 3][$col]
		@@ -649,7 +649,7 @@ discard block
		block discarded – undo
649	649	for($row = -2; $row <= 2; $row++){
650	650	for($col = -2; $col <= 2; $col++){
651	651	$this->matrix[$posI + $row][$posJ + $col] =
652		- $row === -2 \|\| $row === 2
	652	+ $row === -2 \|\| $row === 2
653	653	\|\| $col === -2 \|\| $col === 2
654	654	\|\| ($row === 0 && $col === 0);
655	655	}

		@@ -41,15 +41,15 @@ discard block
		block discarded – undo
41	41	const ERROR_CORRECT_LEVEL_H = 2; // 30%.
42	42
43	43	// max bits @ ec level L:07 M:15 Q:25 H:30 %
44		- const TYPE_01 = 1; // 152 128 104 72
45		- const TYPE_02 = 2; // 272 224 176 128
46		- const TYPE_03 = 3; // 440 352 272 208
47		- const TYPE_04 = 4; // 640 512 384 288
48		- const TYPE_05 = 5; // 864 688 496 368
49		- const TYPE_06 = 6; // 1088 864 608 480
50		- const TYPE_07 = 7; // 1248 992 704 528
51		- const TYPE_08 = 8; // 1552 1232 880 688
52		- const TYPE_09 = 9; // 1856 1456 1056 800
	44	+ const TYPE_01 = 1; // 152 128 104 72
	45	+ const TYPE_02 = 2; // 272 224 176 128
	46	+ const TYPE_03 = 3; // 440 352 272 208
	47	+ const TYPE_04 = 4; // 640 512 384 288
	48	+ const TYPE_05 = 5; // 864 688 496 368
	49	+ const TYPE_06 = 6; // 1088 864 608 480
	50	+ const TYPE_07 = 7; // 1248 992 704 528
	51	+ const TYPE_08 = 8; // 1552 1232 880 688
	52	+ const TYPE_09 = 9; // 1856 1456 1056 800
53	53	const TYPE_10 = 10; // 2192 1728 1232 976
54	54
55	55	/**
		@@ -265,9 +265,9 @@ discard block
		block discarded – undo
265	265	$count = 0;
266	266
267	267	if(
268		- $this->matrix[$row ][$col ]
269		- \|\| $this->matrix[$row ][$col + 1]
270		- \|\| $this->matrix[$row + 1][$col ]
	268	+ $this->matrix[$row][$col]
	269	+ \|\| $this->matrix[$row][$col + 1]
	270	+ \|\| $this->matrix[$row + 1][$col]
271	271	\|\| $this->matrix[$row + 1][$col + 1]
272	272	){
273	273	$count++;
		@@ -292,7 +292,7 @@ discard block
		block discarded – undo
292	292	foreach($range2 as $col){
293	293
294	294	if(
295		- $this->matrix[$row][$col ]
	295	+ $this->matrix[$row][$col]
296	296	&& !$this->matrix[$row][$col + 1]
297	297	&& $this->matrix[$row][$col + 2]
298	298	&& $this->matrix[$row][$col + 3]
		@@ -310,7 +310,7 @@ discard block
		block discarded – undo
310	310	foreach($range2 as $row){
311	311
312	312	if(
313		- $this->matrix[$row ][$col]
	313	+ $this->matrix[$row][$col]
314	314	&& !$this->matrix[$row + 1][$col]
315	315	&& $this->matrix[$row + 2][$col]
316	316	&& $this->matrix[$row + 3][$col]
		@@ -349,11 +349,11 @@ discard block
		block discarded – undo
349	349	$this->lostPoint = 0;
350	350	$this->darkCount = 0;
351	351
352		- $range = range(0, $this->pixelCount-1);
	352	+ $range = range(0, $this->pixelCount - 1);
353	353
354	354	$this->testLevel1($range);
355		- $this->testLevel2(range(0, $this->pixelCount-2));
356		- $this->testLevel3($range, range(0, $this->pixelCount-7));
	355	+ $this->testLevel2(range(0, $this->pixelCount - 2));
	356	+ $this->testLevel3($range, range(0, $this->pixelCount - 7));
357	357	$this->testLevel4($range);
358	358
359	359	$this->lostPoint += (abs(100 * $this->darkCount / $this->pixelCount / $this->pixelCount - 50) / 5) * 10;
		@@ -375,7 +375,7 @@ discard block
		block discarded – undo
375	375	$a = (int)floor($i / 3);
376	376	$b = $i % 3 + $this->pixelCount - 8 - 3;
377	377
378		- $this->matrix[$a][$b] = $this->matrix[$b][$a] = !$test && (($bits >> $i) & 1) === 1;
	378	+ $this->matrix[$a][$b] = $this->matrix[$b][$a] = !$test && (($bits >> $i)&1) === 1;
379	379	$i++;
380	380	}
381	381
		@@ -387,13 +387,13 @@ discard block
		block discarded – undo
387	387	*/
388	388	protected function setTypeInfo($test, $pattern){
389	389	$this->setPattern();
390		- $bits = Util::getBCHTypeInfo(($this->errorCorrectLevel << 3) \| $pattern);
	390	+ $bits = Util::getBCHTypeInfo(($this->errorCorrectLevel << 3)\|$pattern);
391	391	$i = 0;
392	392	while($i < 15){
393		- $mod = !$test && (($bits >> $i) & 1) === 1;
	393	+ $mod = !$test && (($bits >> $i)&1) === 1;
394	394
395	395	switch(true){
396		- case $i < 6: $this->matrix[$i ][8] = $mod; break;
	396	+ case $i < 6: $this->matrix[$i][8] = $mod; break;
397	397	case $i < 8: $this->matrix[$i + 1][8] = $mod; break;
398	398	default:
399	399	$this->matrix[$this->pixelCount - 15 + $i][8] = $mod;
		@@ -401,7 +401,7 @@ discard block
		block discarded – undo
401	401
402	402	switch(true){
403	403	case $i < 8: $this->matrix[8][$this->pixelCount - $i - 1] = $mod; break;
404		- case $i < 9: $this->matrix[8][ 15 + 1 - $i - 1] = $mod; break;
	404	+ case $i < 9: $this->matrix[8][15 + 1 - $i - 1] = $mod; break;
405	405	default:
406	406	$this->matrix[8][15 - $i - 1] = $mod;
407	407	}
		@@ -481,7 +481,7 @@ discard block
		block discarded – undo
481	481
482	482	foreach($dcdata[$key] as $i => &$_dcdata){
483	483	$bdata = $this->bitBuffer->buffer;
484		- $_dcdata = 0xff & $bdata[$i + $offset];
	484	+ $_dcdata = 0xff&$bdata[$i + $offset];
485	485	}
486	486
487	487	$offset += $rsBlockDataCount;
		@@ -563,7 +563,7 @@ discard block
		block discarded – undo
563	563	$dark = false;
564	564
565	565	if($byteIndex < $dataCount){
566		- $dark = (($data[$byteIndex] >> $bitIndex) & 1) === 1;
	566	+ $dark = (($data[$byteIndex] >> $bitIndex)&1) === 1;
567	567	}
568	568
569	569	$a = $row + $_col;
		@@ -626,7 +626,7 @@ discard block
		block discarded – undo
626	626	$this->matrix[$row + $r][$col + $c] =
627	627	(0 <= $r && $r <= 6 && ($c === 0 \|\| $c === 6))
628	628	\|\| (0 <= $c && $c <= 6 && ($r === 0 \|\| $r === 6))
629		- \|\| (2 <= $c && $c <= 4 && 2 <= $r && $r <= 4);
	629	+ \|\| (2 <= $c && $c <= 4 && 2 <= $r && $r <= 4);
630	630	}
631	631	$r++;
632	632	}
		@@ -651,7 +651,7 @@ discard block
		block discarded – undo
651	651	$this->matrix[$posI + $row][$posJ + $col] =
652	652	$row === -2 \|\| $row === 2
653	653	\|\| $col === -2 \|\| $col === 2
654		- \|\| ($row === 0 && $col === 0);
	654	+ \|\| ($row === 0 && $col === 0);
655	655	}
656	656	}
657	657	}

		@@ -63,8 +63,8 @@
		block discarded – undo
63	63	foreach($row as $c => $pixel){
64	64	if($pixel){
65	65	imagefilledrectangle($image,
66		- $this->options->marginSize + $c * $this->options->pixelSize,
67		- $this->options->marginSize + $r * $this->options->pixelSize,
	66	+ $this->options->marginSize + $c * $this->options->pixelSize,
	67	+ $this->options->marginSize + $r * $this->options->pixelSize,
68	68	$this->options->marginSize + ($c + 1) * $this->options->pixelSize - 1,
69	69	$this->options->marginSize + ($r + 1) * $this->options->pixelSize - 1,
70	70	$foreground);

chillerlan / php-qrcode

Branch — master (03e903)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +33 added lines, -33 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +26 added lines, -26 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch