chillerlan / php-database

src/Drivers/SQLite/SQLite3Driver.php

Doc Comments +1 added lines, -1 removed lines

@@ -168,7 +168,7 @@
 	 * @param string $sql    The SQL statement to prepare
 	 * @param array  $values a multidimensional array with the values, each row represents one line to insert.
 	 *
-	 * @return bool true query success, otherwise false
+	 * @return boolean|null true query success, otherwise false
 	 */
 	public function multi($sql, array $values){
 		// TODO: Implement multi() method.

Indentation +9 added lines, -9 removed lines

@@ -1,14 +1,14 @@
 <?php
 /**
- * Class SQLite3Driver
- *
- * @filesource   SQLite3Driver.php
- * @created      21.02.2016
- * @package      chillerlan\Database\Drivers\SQLite
- * @author       Smiley <smiley@chillerlan.net>
- * @copyright    2016 Smiley
- * @license      MIT
- */
+	 * Class SQLite3Driver
+	 *
+	 * @filesource   SQLite3Driver.php
+	 * @created      21.02.2016
+	 * @package      chillerlan\Database\Drivers\SQLite
+	 * @author       Smiley <smiley@chillerlan.net>
+	 * @copyright    2016 Smiley
+	 * @license      MIT
+	 */
 
 namespace chillerlan\Database\Drivers\SQLite;
 

Unused Use Statements +2 added lines, -2 removed lines

@@ -12,10 +12,10 @@
 
 namespace chillerlan\Database\Drivers\SQLite;
 
-use chillerlan\Database\DBException;
-use chillerlan\Database\Drivers\DBDriverAbstract;
 use Exception;
 use SQLite3;
+use chillerlan\Database\DBException;
+use chillerlan\Database\Drivers\DBDriverAbstract;
 
 /**
  *

src/Drivers/DBDriverInterface.php

Doc Comments +1 added lines

@@ -86,6 +86,7 @@
 	 *
 	 * @param array $stats
 	 * @internal
+	 * @return void
 	 */
 	public function addStats(array $stats);
 

src/Drivers/PostgreSQL/PostgreSQLDriver.php

Doc Comments +1 added lines, -1 removed lines

@@ -168,7 +168,7 @@
 	 * @param string $sql    The SQL statement to prepare
 	 * @param array  $values a multidimensional array with the values, each row represents one line to insert.
 	 *
-	 * @return bool true query success, otherwise false
+	 * @return boolean|null true query success, otherwise false
 	 */
 	public function multi($sql, array $values){
 		// TODO: Implement multi() method.

src/Traits/ClassLoaderTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 	 * @param string $class     FQCN
 	 * @param string $interface FQCN
 	 *
-	 * @param mixed  $params    [optional] the following arguments are optional and will be passed to the class constructor if present.
+	 * @param \chillerlan\Database\DBOptions  $params    [optional] the following arguments are optional and will be passed to the class constructor if present.
 	 *
 	 * @return object of type $interface
 	 * @throws \chillerlan\Database\DBException

Unused Use Statements +1 added lines, -1 removed lines

@@ -12,8 +12,8 @@
 
 namespace chillerlan\Database\Traits;
 
-use chillerlan\Database\DBException;
 use ReflectionClass;
+use chillerlan\Database\DBException;
 
 /**
  * A simple class loader

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
 		if(class_exists($class)){
 			$reflectionClass = new ReflectionClass($class);
 
-			if(!$reflectionClass->implementsInterface($interface)) {
+			if(!$reflectionClass->implementsInterface($interface)){
 				throw new DBException($class.' does not implement '.$interface);
 			}
 

Braces +3 added lines, -2 removed lines

@@ -31,12 +31,13 @@
 	 * @return object of type $interface
 	 * @throws \chillerlan\Database\DBException
 	 */
-	protected function __loadClass($class, $interface, ...$params){ // phpDocumentor stumbles across the ... syntax
+	protected function __loadClass($class, $interface, ...$params){
+// phpDocumentor stumbles across the ... syntax
 
 		if(class_exists($class)){
 			$reflectionClass = new ReflectionClass($class);
 
-			if(!$reflectionClass->implementsInterface($interface)) {
+			if(!$reflectionClass->implementsInterface($interface)){
 				throw new DBException($class.' does not implement '.$interface);
 			}
 

tests/DBInstanceTest.php

Unused Use Statements +1 added lines, -2 removed lines

@@ -9,15 +9,14 @@
 
 namespace chillerlan\DatabaseTest;
 
+use Dotenv\Dotenv;
 use chillerlan\Database\DBOptions;
 use chillerlan\Database\Drivers\MySQLi\MySQLiDriver;
-use chillerlan\Database\Drivers\PDO\PDOFirebirdDriver;
 use chillerlan\Database\Drivers\PDO\PDOMySQLDriver;
 use chillerlan\Database\Drivers\PDO\PDOPostgresDriver;
 use chillerlan\Database\Drivers\PDO\PDOSQLiteDriver;
 use chillerlan\Database\Drivers\PostgreSQL\PostgreSQLDriver;
 use chillerlan\Database\Drivers\SQLite\SQLite3Driver;
-use Dotenv\Dotenv;
 
 class DBInstanceTest extends \PHPUnit_Framework_TestCase{
 

Spacing +5 added lines, -5 removed lines

@@ -39,15 +39,15 @@
 	public function driverDataProvider(){
 		return [
 			// native
-			['MYSQLI',       MySQLiDriver::class,       'mysqli'],
-			['POSTGRESQL',   PostgreSQLDriver::class, 'resource'],
-			['SQLITE3',      SQLite3Driver::class,     'SQLite3'],
+			['MYSQLI', MySQLiDriver::class, 'mysqli'],
+			['POSTGRESQL', PostgreSQLDriver::class, 'resource'],
+			['SQLITE3', SQLite3Driver::class, 'SQLite3'],
 
 			// PDO (obviously)
-			['PDO_MYSQL',    PDOMySQLDriver::class,    'PDO'],
+			['PDO_MYSQL', PDOMySQLDriver::class, 'PDO'],
 			['PDO_POSTGRES', PDOPostgresDriver::class, 'PDO'],
 #			['PDO_FIREBIRD', PDOFirebirdDriver::class, 'PDO'], // https://github.com/asfernandes/firebird/blob/master/.travis.yml
-			['PDO_SQLITE',   PDOSQLiteDriver::class,   'PDO'],
+			['PDO_SQLITE', PDOSQLiteDriver::class, 'PDO'],
 		];
 	}
 

src/DBOptions.php

Spacing +1 added lines, -1 removed lines

@@ -129,7 +129,7 @@
 	 * 
 	 * @var int
 	 */
-	public $sqlite_flags = SQLITE3_OPEN_READWRITE | SQLITE3_OPEN_CREATE;
+	public $sqlite_flags = SQLITE3_OPEN_READWRITE|SQLITE3_OPEN_CREATE;
 	/**
 	 * An optional encryption key used when encrypting and decrypting an SQLite database.
 	 *

src/Drivers/PDO/PDODriver.php

Spacing +5 added lines, -5 removed lines

@@ -192,10 +192,10 @@ 
 	 * @return array
 	 * @internal
 	 */
-	protected function getResult(PDOStatement &$stmt, $index, $assoc, $fetch_array){
+	protected function getResult(PDOStatement&$stmt, $index, $assoc, $fetch_array){
 		$out = [];
 		$method = $assoc ? ($fetch_array ? PDO::FETCH_ASSOC : PDO::FETCH_OBJ) : PDO::FETCH_NUM;
-		$i = 0 ;
+		$i = 0;
 
 		// ok, we have a result with one or more rows, loop out the rows and output as array
 		while($row = $stmt->fetch($method)){
@@ -225,16 +225,16 @@ 
 	 * @param array         $values
 	 * @internal
 	 */
-	protected function bindParams(PDOStatement &$stmt, array $values){
+	protected function bindParams(PDOStatement&$stmt, array $values){
 		$param_no = 1;
 
 		foreach($values as $v){
 
 			switch(gettype($v)){
 				case 'boolean': $type = PDO::PARAM_BOOL; break;
-				case 'integer': $type = PDO::PARAM_INT;  break;
+				case 'integer': $type = PDO::PARAM_INT; break;
 				case 'NULL':    $type = PDO::PARAM_NULL; break;
-				default:        $type = PDO::PARAM_STR;  break;
+				default:        $type = PDO::PARAM_STR; break;
 			}
 
 			$stmt->bindValue($param_no, $v, $type);

Unused Use Statements +2 added lines, -2 removed lines

@@ -11,11 +11,11 @@
 
 namespace chillerlan\Database\Drivers\PDO;
 
-use chillerlan\Database\DBException;
-use chillerlan\Database\Drivers\DBDriverAbstract;
 use PDO;
 use PDOException;
 use PDOStatement;
+use chillerlan\Database\DBException;
+use chillerlan\Database\Drivers\DBDriverAbstract;
 
 /**
  * Class PDODriver

tests/Traits/ClassLoaderTraitTest.php

Indentation +8 added lines, -8 removed lines

@@ -1,13 +1,13 @@
 <?php
 /**
- *
- * @filesource   ClassLoaderTraitTest.php
- * @created      29.02.2016
- * @package      chillerlan\DatabaseTest\Traits
- * @author       Smiley <smiley@chillerlan.net>
- * @copyright    2015 Smiley
- * @license      MIT
- */
+	 *
+	 * @filesource   ClassLoaderTraitTest.php
+	 * @created      29.02.2016
+	 * @package      chillerlan\DatabaseTest\Traits
+	 * @author       Smiley <smiley@chillerlan.net>
+	 * @copyright    2015 Smiley
+	 * @license      MIT
+	 */
 
 namespace chillerlan\DatabaseTest\Traits;
 

src/Drivers/MySQLi/MySQLiDriver.php

Unused Use Statements +1 added lines, -2 removed lines

@@ -12,6 +12,7 @@ 
 
 namespace chillerlan\Database\Drivers\MySQLi;
 
+use ReflectionMethod;
 use chillerlan\Database\DBException;
 use chillerlan\Database\Drivers\DBBaseDriver;
 use chillerlan\Database\Drivers\DBDriverInterface;
@@ -19,8 +20,6 @@ 
 use mysqli_result;
 use mysqli_sql_exception;
 use mysqli_stmt;
-use ReflectionClass;
-use ReflectionMethod;
 use stdClass;
 
 /**

Spacing +4 added lines, -4 removed lines

@@ -187,7 +187,7 @@ 
 
 			$out = [];
 			$method = 'fetch_'.($assoc ? ($fetch_array ? 'assoc' : 'object') : 'row');
-			$i = 0 ;
+			$i = 0;
 
 			// ok, we have a result with one or more rows, loop out the rows and output as array
 			while($row = $result->{$method}()){
@@ -351,7 +351,7 @@ 
 	 * @param \ReflectionMethod $reflectionMethod
 	 * @param array             $row
 	 */
-	protected function insertPreparedRow(mysqli_stmt &$stmt, ReflectionMethod &$reflectionMethod, array &$row){
+	protected function insertPreparedRow(mysqli_stmt&$stmt, ReflectionMethod&$reflectionMethod, array &$row){
 		$references = $this->getReferences($row);
 		array_unshift($references, $this->getTypes($references));
 		$reflectionMethod->invokeArgs($stmt, $references);
@@ -366,7 +366,7 @@ 
 	 *
 	 * @return array|bool
 	 */
-	protected function getResult(mysqli_stmt &$stmt, mysqli_result &$result, $assoc, $fetch_array){
+	protected function getResult(mysqli_stmt&$stmt, mysqli_result&$result, $assoc, $fetch_array){
 		// get the columns and their references
 		// http://php.net/manual/mysqli-stmt.bind-result.php
 		$cols = $refs = [];
@@ -422,7 +422,7 @@ 
 		foreach($values as &$v){
 			switch(gettype($v)){
 				case 'integer': $types[] = 'i'; break;
-				case 'double': $types[] ='d'; break;
+				case 'double': $types[] = 'd'; break;
 				default: $types[] = 's'; break;
 			}
 		}