charlesportwoodii / yii2-api-rest-components

api/actions/ActivationAction.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use app\forms\Activation;
 use yrc\rest\Action as RestAction;
-
 use yii\web\HttpException;
 use Yii;
 

api/actions/AuthenticationAction.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use app\forms\Login;
 use app\models\Token;
 use yrc\rest\Action as RestAction;
-
 use yii\web\UnauthorizedHttpException;
 use Yii;
 

Doc Comments +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
 
     /**
      * Deauthenticates a user
-     * @return mixed
+     * @return boolean
      */
     public function delete($params)
     {

api/actions/OTPAction.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use app\models\User;
 use yrc\rest\Action as RestAction;
-
 use yii\web\HttpException;
 use Yii;
 

api/models/User.php

Doc Comments +1 added lines, -1 removed lines

@@ -224,7 +224,7 @@
     
     /**
      * Provisions TOTP for the account
-     * @return boolean|string
+     * @return false|string
      */
     public function provisionOTP()
     {

Spacing +4 added lines, -4 removed lines

@@ -247,8 +247,8 @@ 
         $totp = new TOTP(
             $this->username,
             $encodedSecret,
-            30,             // 30 second window
-            'sha256',       // SHA256 for the hashing algorithm
+            30, // 30 second window
+            'sha256', // SHA256 for the hashing algorithm
             6               // 6 digits
         );
 
@@ -302,8 +302,8 @@ 
         $totp = new TOTP(
             $this->username,
             $this->otp_secret,
-            30,             // 30 second window
-            'sha256',       // SHA256 for the hashing algorithm
+            30, // 30 second window
+            'sha256', // SHA256 for the hashing algorithm
             6               // 6 digits
         );
 

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Base32\Base32;
 use OTPHP\TOTP;
-
 use yii\behaviors\TimestampBehavior;
 use yii\db\ActiveRecord;
 use yii\filters\RateLimitInterface;

filters/auth/HMACSignatureAuth.php

Indentation +3 added lines, -3 removed lines

@@ -129,9 +129,9 @@
 
         // Calculate the signature string
         $signatureString = hash('sha256', $body) . "\n" .
-                           $request->method . "+" . $request->getUrl() . "\n" .
-                           $request->getHeaders()->get(self::DATE_HEADER) . "\n" .
-                           \base64_encode($salt);
+                            $request->method . "+" . $request->getUrl() . "\n" .
+                            $request->getHeaders()->get(self::DATE_HEADER) . "\n" .
+                            \base64_encode($salt);
        
         // Calculate the HMAC
         $selfHMAC = \base64_encode(\hash_hmac('sha256', $signatureString, $hkdf, true));

Spacing +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
     private function isHMACSignatureValid($accessToken, $ikm, $salt, $request, $hmac = null)
     {
         static $selfHMAC = null;
-        static $hkdf   = null;
+        static $hkdf = null;
         
         // Null check the HMAC string
         if (empty($hmac) || $hmac === null) {

Doc Comments +2 added lines, -1 removed lines

@@ -87,6 +87,7 @@ 
      * @param string $accessToken
      * @param string $salt
      * @param \yii\web\request $request
+     * @param string $ikm
      * @return bool
      */
     private function isHMACSignatureValid($accessToken, $ikm, $salt, $request, $hmac = null)
@@ -152,7 +153,7 @@ 
     
     /**
      * Gets the datetime drift that has occured since the request was sent
-     * @param yii\web\Request $request
+     * @param \yii\web\Request $request
      * @return int
      */
     private function getTimeDrift($request)

Unused Use Statements -3 removed lines

@@ -3,10 +3,7 @@
 namespace yrc\filters\auth;
 
 use app\models\Token;
-
-use yii\helpers\Json;
 use yii\filters\auth\AuthMethod;
-
 use Yii;
 
 /**

api/forms/Login.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace yrc\api\forms;
 
 use app\models\Token;
-use yii\web\UnauthorizedHttpException;
 use Yii;
 
 /**

api/forms/ChangeEmail.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace yrc\api\forms;
 
-use Base32\Base32;
 use Yii;
 
 /**

api/actions/ResetPasswordAction.php

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 
 use app\forms\ResetPassword;
 use yrc\rest\Action as RestAction;
-use yrc\api\models\Code;
-
 use yii\web\HttpException;
 use Yii;
 

api/forms/Activation.php

Unused Use Statements -2 removed lines

@@ -2,9 +2,7 @@
 
 namespace yrc\api\forms;
 
-use Base32\Base32;
 use Yii;
-
 use yrc\api\models\Code;
 
 /**