chamilo / chamilo-lms

main/forum/editthread.php

Unused Use Statements -2 removed lines

@@ -1,8 +1,6 @@
 <?php
 /* For licensing terms, see /license.txt */
 
-use ChamiloSession as Session;
-
 /**
  * Class ExerciseLib
  * shows a question and its answers

Spacing +3 added lines, -3 removed lines

@@ -45,7 +45,7 @@ 
 }
 
 if (!empty($gradebook) && $gradebook == 'view') {
-    $interbreadcrumb[] = array (
+    $interbreadcrumb[] = array(
         'url' => '../gradebook/'.Security::remove_XSS($_SESSION['gradebook_dest']),
         'name' => get_lang('ToolGradebook')
     );
@@ -107,7 +107,7 @@ 
     $interbreadcrumb[] = array('url' => '../group/group.php?'.$cidreq, 'name' => get_lang('Groups'));
     $interbreadcrumb[] = array('url' => '../group/group_space.php?'.$cidreq, 'name' => get_lang('GroupSpace').' '.$groupProperties['name']);
     $interbreadcrumb[] = array('url' => 'viewforum.php?'.$cidreq.'&forum='.intval($_GET['forum']), 'name' => $currentForum['forum_title']);
-    $interbreadcrumb[] = array('url' => 'newthread.php?'.$cidreq.'&forum='.intval($_GET['forum']),'name' => get_lang('EditThread'));
+    $interbreadcrumb[] = array('url' => 'newthread.php?'.$cidreq.'&forum='.intval($_GET['forum']), 'name' => get_lang('EditThread'));
 } else {
     $interbreadcrumb[] = array('url' => 'index.php?'.$cidreq, 'name' => $nameTools);
     $interbreadcrumb[] = array('url' => 'viewforumcategory.php?'.$cidreq.'&forumcategory='.$currentForumCategory['cat_id'], 'name' => $currentForumCategory['cat_title']);
@@ -156,7 +156,7 @@ 
 echo '<div class="actions">';
 echo '<span style="float:right;">'.search_link().'</span>';
 echo '<a href="viewforum.php?forum='.intval($_GET['forum']).'&'.$cidreq.'">'.
-    Display::return_icon('back.png',get_lang('BackToForum'),'',ICON_SIZE_MEDIUM).'</a>';
+    Display::return_icon('back.png', get_lang('BackToForum'), '', ICON_SIZE_MEDIUM).'</a>';
 echo '</div>';
 
 $threadData = getThreadInfo($threadId, $cId);

main/forum/newthread.php

Unused Use Statements -2 removed lines

@@ -1,8 +1,6 @@
 <?php
 /* For licensing terms, see /license.txt */
 
-use ChamiloSession as Session;
-
 /**
  * Class ExerciseLib
  * shows a question and its answers

Spacing +7 added lines, -7 removed lines

@@ -54,12 +54,12 @@ 
 
 /* Breadcrumbs */
 
-if (isset($_SESSION['gradebook'])){
+if (isset($_SESSION['gradebook'])) {
     $gradebook = Security::remove_XSS($_SESSION['gradebook']);
 }
 
 if (!empty($gradebook) && $gradebook == 'view') {
-    $interbreadcrumb[] = array (
+    $interbreadcrumb[] = array(
         'url' => '../gradebook/'.Security::remove_XSS($_SESSION['gradebook_dest']),
         'name' => get_lang('ToolGradebook')
     );
@@ -117,7 +117,7 @@ 
     $interbreadcrumb[] = array('url' => '../group/group.php?'.$cidreq, 'name' => get_lang('Groups'));
     $interbreadcrumb[] = array('url' => '../group/group_space.php?'.$cidreq, 'name' => get_lang('GroupSpace').' '.$groupProperties['name']);
     $interbreadcrumb[] = array('url' => 'viewforum.php?'.$cidreq.'&forum='.intval($_GET['forum']), 'name' => $current_forum['forum_title']);
-    $interbreadcrumb[] = array('url' => 'newthread.php?'.$cidreq.'&forum='.intval($_GET['forum']),'name' => get_lang('NewTopic'));
+    $interbreadcrumb[] = array('url' => 'newthread.php?'.$cidreq.'&forum='.intval($_GET['forum']), 'name' => get_lang('NewTopic'));
 } else {
     $interbreadcrumb[] = array('url' => 'index.php?'.$cidreq, 'name' => $nameTools);
     $interbreadcrumb[] = array('url' => 'viewforumcategory.php?'.$cidreq.'&forumcategory='.$current_forum_category['cat_id'], 'name' => $current_forum_category['cat_title']);
@@ -128,9 +128,9 @@ 
 /* Resource Linker */
 
 if (isset($_POST['add_resources']) AND $_POST['add_resources'] == get_lang('Resources')) {
-    $_SESSION['formelements']	= $_POST;
-    $_SESSION['origin']			= $_SERVER['REQUEST_URI'];
-    $_SESSION['breadcrumbs']	= $interbreadcrumb;
+    $_SESSION['formelements'] = $_POST;
+    $_SESSION['origin'] = $_SERVER['REQUEST_URI'];
+    $_SESSION['breadcrumbs'] = $interbreadcrumb;
     header('Location: ../resourcelinker/resourcelinker.php');
     exit;
 }
@@ -165,7 +165,7 @@ 
 echo '<div class="actions">';
 echo '<span style="float:right;">'.search_link().'</span>';
 echo '<a href="viewforum.php?forum='.intval($_GET['forum']).'&'.$cidreq.'">'.
-    Display::return_icon('back.png',get_lang('BackToForum'),'',ICON_SIZE_MEDIUM).'</a>';
+    Display::return_icon('back.png', get_lang('BackToForum'), '', ICON_SIZE_MEDIUM).'</a>';
 echo '</div>';
 
 // Set forum attachment data into $_SESSION

main/forum/viewforum.php

Unused Use Statements -2 removed lines

@@ -1,8 +1,6 @@
 <?php
 /* For licensing terms, see /license.txt */
 
-use ChamiloSession as Session;
-
 /**
  * Class ExerciseLib
  * shows a question and its answers

Spacing +71 added lines, -71 removed lines

@@ -26,7 +26,7 @@ 
 
 // Including the global initialization file.
 require_once '../inc/global.inc.php';
-$current_course_tool  = TOOL_FORUM;
+$current_course_tool = TOOL_FORUM;
 
 // Notification for unauthorized people.
 api_protect_course_script(true);
@@ -77,7 +77,7 @@ 
 
     // Course
     if (
-        !api_is_allowed_to_edit(false, true) &&  //is a student
+        !api_is_allowed_to_edit(false, true) && //is a student
         (($current_forum_category && $current_forum_category['visibility'] == 0) ||
         $current_forum['visibility'] == 0 || !$user_has_access_in_group)
     ) {
@@ -86,7 +86,7 @@ 
 } else {
     //Course
     if (
-        !api_is_allowed_to_edit(false, true) &&  //is a student
+        !api_is_allowed_to_edit(false, true) && //is a student
         (
             ($current_forum_category && $current_forum_category['visibility'] == 0) ||
             $current_forum['visibility'] == 0
@@ -102,12 +102,12 @@ 
 $my_action = isset($_GET['action']) ? $_GET['action'] : '';
 
 $gradebook = null;
-if (isset($_SESSION['gradebook'])){
+if (isset($_SESSION['gradebook'])) {
     $gradebook = $_SESSION['gradebook'];
 }
 
 if (!empty($gradebook) && $gradebook == 'view') {
-    $interbreadcrumb[] = array (
+    $interbreadcrumb[] = array(
         'url' => '../gradebook/'.$_SESSION['gradebook_dest'],
         'name' => get_lang('ToolGradebook')
     );
@@ -117,25 +117,25 @@ 
 
 if ($origin == 'group') {
     $interbreadcrumb[] = array(
-        'url' => api_get_path(WEB_CODE_PATH) . 'group/group.php?'.api_get_cidreq(),
+        'url' => api_get_path(WEB_CODE_PATH).'group/group.php?'.api_get_cidreq(),
         'name' => get_lang('Groups')
     );
     $interbreadcrumb[] = array(
-        'url' => api_get_path(WEB_CODE_PATH) . 'group/group_space.php?' . api_get_cidreq(),
-        'name' => get_lang('GroupSpace') . ' ' . $group_properties['name']
+        'url' => api_get_path(WEB_CODE_PATH).'group/group_space.php?'.api_get_cidreq(),
+        'name' => get_lang('GroupSpace').' '.$group_properties['name']
     );
     $interbreadcrumb[] = array(
         'url' => '#',
-        'name' => get_lang('Forum') . ' ' . Security::remove_XSS($current_forum['forum_title'])
+        'name' => get_lang('Forum').' '.Security::remove_XSS($current_forum['forum_title'])
     );
 } else {
     $interbreadcrumb[] = array(
-        'url' => $forumUrl . 'index.php?search=' . Security::remove_XSS($my_search),
+        'url' => $forumUrl.'index.php?search='.Security::remove_XSS($my_search),
         'name' => get_lang('ForumCategories')
     );
     $interbreadcrumb[] = array(
-        'url' => $forumUrl . 'viewforumcategory.php?forumcategory=' . $current_forum_category['cat_id']
-            . '&search=' . Security::remove_XSS(urlencode($my_search)),
+        'url' => $forumUrl.'viewforumcategory.php?forumcategory='.$current_forum_category['cat_id']
+            . '&search='.Security::remove_XSS(urlencode($my_search)),
         'name' => prepare4display($current_forum_category['cat_title'])
     );
     $interbreadcrumb[] = array(
@@ -243,25 +243,25 @@ 
             break;
     }
 
-    $table_list = Display::page_subheader(get_lang('ThreadUsersList') . ': ' . get_name_thread_by_id($_GET['id']));
+    $table_list = Display::page_subheader(get_lang('ThreadUsersList').': '.get_name_thread_by_id($_GET['id']));
 
     if ($nrorow3 > 0 || $nrorow3 == -2) {
-        $url = 'cidReq=' . Security::remove_XSS($_GET['cidReq']) .
-            '&forum=' . Security::remove_XSS($my_forum) . '&action='
-            . Security::remove_XSS($_GET['action']) . '&content='
-            . Security::remove_XSS($_GET['content'], STUDENT) . '&id=' . intval($_GET['id']);
+        $url = 'cidReq='.Security::remove_XSS($_GET['cidReq']).
+            '&forum='.Security::remove_XSS($my_forum).'&action='
+            . Security::remove_XSS($_GET['action']).'&content='
+            . Security::remove_XSS($_GET['content'], STUDENT).'&id='.intval($_GET['id']);
         $tabs = array(
             array(
                 'content' =>  get_lang('AllStudents'),
-                'url' => $forumUrl . 'viewforum.php?' . $url . '&origin=' . $origin . '&list=all'
+                'url' => $forumUrl.'viewforum.php?'.$url.'&origin='.$origin.'&list=all'
             ),
             array(
                 'content' =>  get_lang('StudentsQualified'),
-                'url' => $forumUrl . 'viewforum.php?' . $url . '&origin=' . $origin . '&list=qualify'
+                'url' => $forumUrl.'viewforum.php?'.$url.'&origin='.$origin.'&list=qualify'
             ),
             array(
                 'content' =>  get_lang('StudentsNotQualified'),
-                'url' => $forumUrl . 'viewforum.php?' . $url . '&origin=' . $origin . '&list=notqualify'
+                'url' => $forumUrl.'viewforum.php?'.$url.'&origin='.$origin.'&list=notqualify'
             ),
         );
         $table_list .= Display::tabsOnlyLink($tabs, $active);
@@ -270,32 +270,32 @@ 
         $table_list .= '<center><br /><table class="data_table" style="width:50%">';
         // The column headers (TODO: Make this sortable).
         $table_list .= '<tr >';
-        $table_list .= '<th height="24">' . get_lang('NamesAndLastNames') . '</th>';
+        $table_list .= '<th height="24">'.get_lang('NamesAndLastNames').'</th>';
 
         if ($listType == 'qualify') {
-            $table_list .= '<th>' . get_lang('Qualification') . '</th>';
+            $table_list .= '<th>'.get_lang('Qualification').'</th>';
         }
         if (api_is_allowed_to_edit(null, true)) {
-            $table_list .= '<th>' . get_lang('Qualify') . '</th>';
+            $table_list .= '<th>'.get_lang('Qualify').'</th>';
         }
         $table_list .= '</tr>';
         $max_qualify = showQualify('2', $userId, $_GET['id']);
         $counter_stdlist = 0;
 
         if (Database::num_rows($student_list) > 0) {
-            while ($row_student_list=Database::fetch_array($student_list)) {
+            while ($row_student_list = Database::fetch_array($student_list)) {
                 $userInfo = api_get_user_info($row_student_list['id']);
                 if ($counter_stdlist % 2 == 0) {
                     $class_stdlist = 'row_odd';
                 } else {
                     $class_stdlist = 'row_even';
                 }
-                $table_list .= '<tr class="' . $class_stdlist . '"><td>';
+                $table_list .= '<tr class="'.$class_stdlist.'"><td>';
                 $table_list .= UserManager::getUserProfileLink($userInfo);
 
                 $table_list .= '</td>';
                 if ($listType == 'qualify') {
-                    $table_list .= '<td>' . $row_student_list['qualify'] . '/' . $max_qualify . '</td>';
+                    $table_list .= '<td>'.$row_student_list['qualify'].'/'.$max_qualify.'</td>';
                 }
                 if (api_is_allowed_to_edit(null, true)) {
                     $current_qualify_thread = showQualify(
@@ -304,20 +304,20 @@ 
                         $_GET['id']
                     );
                     $table_list .= '<td>
-                        <a href="' . $forumUrl . 'forumqualify.php?' . api_get_cidreq()
-                        . '&forum=' . Security::remove_XSS($my_forum) . '&thread='
-                        . Security::remove_XSS($_GET['id']) . '&user=' . $row_student_list['id']
-                        . '&user_id=' . $row_student_list['id'] . '&idtextqualify='
-                        . $current_qualify_thread . '&origin=' . $origin . '">'
-                        . Display::return_icon($icon_qualify, get_lang('Qualify')) . '</a></td></tr>';
+                        <a href="' . $forumUrl.'forumqualify.php?'.api_get_cidreq()
+                        . '&forum='.Security::remove_XSS($my_forum).'&thread='
+                        . Security::remove_XSS($_GET['id']).'&user='.$row_student_list['id']
+                        . '&user_id='.$row_student_list['id'].'&idtextqualify='
+                        . $current_qualify_thread.'&origin='.$origin.'">'
+                        . Display::return_icon($icon_qualify, get_lang('Qualify')).'</a></td></tr>';
                 }
                 $counter_stdlist++;
             }
         } else {
             if ($listType == 'qualify') {
-                $table_list .= '<tr><td colspan="2">' . get_lang('ThereIsNotQualifiedLearners') . '</td></tr>';
+                $table_list .= '<tr><td colspan="2">'.get_lang('ThereIsNotQualifiedLearners').'</td></tr>';
             } else {
-                $table_list .= '<tr><td colspan="2">' . get_lang('ThereIsNotUnqualifiedLearners') . '</td></tr>';
+                $table_list .= '<tr><td colspan="2">'.get_lang('ThereIsNotUnqualifiedLearners').'</td></tr>';
             }
         }
 
@@ -343,14 +343,14 @@ 
 echo '<div class="actions">';
 
 if ($origin != 'learnpath') {
-    if ($origin=='group') {
-        echo '<a href="' . api_get_path(WEB_CODE_PATH) . 'group/group_space.php?'
-            . api_get_cidreq() . '&gradebook=' . $gradebook . '">'
+    if ($origin == 'group') {
+        echo '<a href="'.api_get_path(WEB_CODE_PATH).'group/group_space.php?'
+            . api_get_cidreq().'&gradebook='.$gradebook.'">'
             . Display::return_icon('back.png', get_lang('BackTo')
-            . ' ' . get_lang('Groups'), '', ICON_SIZE_MEDIUM) . '</a>';
+            . ' '.get_lang('Groups'), '', ICON_SIZE_MEDIUM).'</a>';
     } else {
         echo '<span style="float:right;">'.search_link().'</span>';
-        echo '<a href="' . $forumUrl . 'index.php?' . api_get_cidreq() . '">'
+        echo '<a href="'.$forumUrl.'index.php?'.api_get_cidreq().'">'
             . Display::return_icon('back.png', get_lang('BackToForumOverview'), '', ICON_SIZE_MEDIUM)
             . '</a>';
     }
@@ -368,14 +368,14 @@ 
     if ($current_forum['locked'] <> 1 AND $current_forum['locked'] <> 1) {
         if (!api_is_anonymous() && !api_is_invitee()) {
             if ($my_forum == strval(intval($my_forum))) {
-                echo '<a href="' . $forumUrl . 'newthread.php?' . api_get_cidreq() . '&forum='
-                    . Security::remove_XSS($my_forum) . $origin_string . '">'
+                echo '<a href="'.$forumUrl.'newthread.php?'.api_get_cidreq().'&forum='
+                    . Security::remove_XSS($my_forum).$origin_string.'">'
                     . Display::return_icon('new_thread.png', get_lang('NewTopic'), '', ICON_SIZE_MEDIUM)
                     . '</a>';
             } else {
                 $my_forum = strval(intval($my_forum));
-                echo '<a href="' . $forumUrl . 'newthread.php?' . api_get_cidreq()
-                    . '&forum=' . $my_forum . $origin_string . '">'
+                echo '<a href="'.$forumUrl.'newthread.php?'.api_get_cidreq()
+                    . '&forum='.$my_forum.$origin_string.'">'
                     . Display::return_icon('new_thread.png', get_lang('NewTopic'), '', ICON_SIZE_MEDIUM)
                     . '</a>';
             }
@@ -402,7 +402,7 @@ 
 if ($origin != 'learnpath') {
     $html .= Display::tag(
         'h3',
-        $iconForum .' '. $titleForum,
+        $iconForum.' '.$titleForum,
         array(
             'class' => 'title-forum')
     );
@@ -444,7 +444,7 @@ 
             }
 
             if (is_array($my_whatsnew_post_info) && !empty($my_whatsnew_post_info)) {
-                $newPost = ' ' . Display::return_icon('alert.png', get_lang('Forum'), null, ICON_SIZE_SMALL);
+                $newPost = ' '.Display::return_icon('alert.png', get_lang('Forum'), null, ICON_SIZE_SMALL);
             } else {
                 $newPost = '';
             }
@@ -454,12 +454,12 @@ 
             }
 
             $name = api_get_person_name($row['firstname'], $row['lastname']);
-            $linkPostForum = '<a href="viewthread.php?' . api_get_cidreq() . '&forum=' . Security::remove_XSS($my_forum)
+            $linkPostForum = '<a href="viewthread.php?'.api_get_cidreq().'&forum='.Security::remove_XSS($my_forum)
                 . "&origin=$origin&thread={$row['thread_id']}$origin_string&search="
-                . Security::remove_XSS(urlencode($my_search)) . '">'
-                . $row['thread_title'] . '</a>';
+                . Security::remove_XSS(urlencode($my_search)).'">'
+                . $row['thread_title'].'</a>';
             $html = '';
-            $html .= '<div class="panel panel-default forum '.($row['thread_sticky']?'sticky':'').'">';
+            $html .= '<div class="panel panel-default forum '.($row['thread_sticky'] ? 'sticky' : '').'">';
             $html .= '<div class="panel-body">';
             $html .= '<div class="row">';
             $html .= '<div class="col-md-6">';
@@ -491,7 +491,7 @@ 
                 );
             }
 
-            $html .= '<div class="thumbnail">' . display_user_image($row['user_id'], $name, $origin) . '</div>';
+            $html .= '<div class="thumbnail">'.display_user_image($row['user_id'], $name, $origin).'</div>';
             $html .= '</div>';
             $html .= '<div class="col-md-10">';
             $html .= Display::tag(
@@ -501,8 +501,8 @@ 
                     'class' => 'title'
                 )
             );
-            $html .= '<p>'. get_lang('By') .' ' .$authorName.'</p>';
-            $html .= '<p>' . api_convert_and_format_date($row['insert_date']) . '</p>';
+            $html .= '<p>'.get_lang('By').' '.$authorName.'</p>';
+            $html .= '<p>'.api_convert_and_format_date($row['insert_date']).'</p>';
             $html .= '</div>';
             $html .= '</div>';
 
@@ -511,13 +511,13 @@ 
             $html .= '<div class="row">';
             $html .= '<div class="col-md-4">'
                 . Display::return_icon('post-forum.png', null, null, ICON_SIZE_SMALL)
-                . " {$row['thread_replies']} " . get_lang('Replies') . '<br>';
-            $html .=  Display::return_icon(
+                . " {$row['thread_replies']} ".get_lang('Replies').'<br>';
+            $html .= Display::return_icon(
                     'post-forum.png',
                     null,
                     null,
                     ICON_SIZE_SMALL
-                ) . ' ' . $row['thread_views'] . ' ' . get_lang('Views') . '<br>' . $newPost;
+                ).' '.$row['thread_views'].' '.get_lang('Views').'<br>'.$newPost;
             $html .= '</div>';
 
             $last_post_info = get_last_post_by_thread(
@@ -531,7 +531,7 @@ 
             if ($last_post_info) {
                 $poster_info = api_get_user_info($last_post_info['poster_id']);
                 $post_date = api_convert_and_format_date($last_post_info['post_date']);
-                $last_post = $post_date . '<br>' . get_lang('By') . ' ' . display_user_link(
+                $last_post = $post_date.'<br>'.get_lang('By').' '.display_user_link(
                     $last_post_info['poster_id'],
                     $poster_info['complete_name'],
                     '',
@@ -541,7 +541,7 @@ 
 
             $html .= '<div class="col-md-5">'
                 . Display::return_icon('post-item.png', null, null, ICON_SIZE_TINY)
-                . ' ' . $last_post;
+                . ' '.$last_post;
             $html .= '</div>';
             $html .= '<div class="col-md-3">';
             $cidreq = api_get_cidreq();
@@ -556,11 +556,11 @@ 
                 if (api_is_allowed_to_edit(false, true) &&
                     !(api_is_course_coach() && $current_forum['session_id'] != $sessionId)
                 ) {
-                    $iconsEdit .= '<a href="' . $forumUrl . 'editthread.php?' . $cidreq
-                        . '&forum=' . intval($my_forum) . '&thread='
+                    $iconsEdit .= '<a href="'.$forumUrl.'editthread.php?'.$cidreq
+                        . '&forum='.intval($my_forum).'&thread='
                         . intval($row['thread_id'])
-                        . '&id_attach=' . $id_attach . '">'
-                        . Display::return_icon('edit.png', get_lang('Edit'), array(), ICON_SIZE_SMALL) . '</a>';
+                        . '&id_attach='.$id_attach.'">'
+                        . Display::return_icon('edit.png', get_lang('Edit'), array(), ICON_SIZE_SMALL).'</a>';
                     if (api_resource_is_locked_by_gradebook($row['thread_id'], LINK_FORUM_THREAD)) {
                         $iconsEdit .= Display::return_icon(
                             'delete_na.png',
@@ -569,13 +569,13 @@ 
                             ICON_SIZE_SMALL
                         );
                     } else {
-                        $iconsEdit.= '<a href="' . api_get_self() . '?' . $cidreq . '&forum='
-                            . intval($my_forum) . '&action=delete&content=thread&id='
-                            . $row['thread_id'] . $origin_string
+                        $iconsEdit .= '<a href="'.api_get_self().'?'.$cidreq.'&forum='
+                            . intval($my_forum).'&action=delete&content=thread&id='
+                            . $row['thread_id'].$origin_string
                             . "\" onclick=\"javascript:if(!confirm('"
                             . addslashes(api_htmlentities(get_lang('DeleteCompleteThread'), ENT_QUOTES))
                             . "')) return false;\">"
-                            . Display::return_icon('delete.png', get_lang('Delete'), array(), ICON_SIZE_SMALL) . '</a>';
+                            . Display::return_icon('delete.png', get_lang('Delete'), array(), ICON_SIZE_SMALL).'</a>';
                     }
 
                     $iconsEdit .= return_visible_invisible_icon(
@@ -598,9 +598,9 @@ 
                             'gidReq' => api_get_group_id()
                         )
                     );
-                    $iconsEdit .= '<a href="viewforum.php?' . $cidreq . '&forum='
+                    $iconsEdit .= '<a href="viewforum.php?'.$cidreq.'&forum='
                         . intval($my_forum)
-                        . '&action=move&thread=' . $row['thread_id'] . $origin_string . '">'
+                        . '&action=move&thread='.$row['thread_id'].$origin_string.'">'
                         . Display::return_icon('move.png', get_lang('MoveThread'), array(), ICON_SIZE_SMALL)
                         . '</a>';
                 }
@@ -617,17 +617,17 @@ 
             }
             $icon_liststd = 'user.png';
             if (!api_is_anonymous() && api_is_allowed_to_session_edit(false, true)) {
-                $iconsEdit .= '<a href="' . api_get_self() . '?' . $cidreq . '&forum='
+                $iconsEdit .= '<a href="'.api_get_self().'?'.$cidreq.'&forum='
                     . Security::remove_XSS($my_forum)
                     . "&origin=$origin&action=notify&content=thread&id={$row['thread_id']}"
-                    . '">' . Display::return_icon($iconnotify, get_lang('NotifyMe')) . '</a>';
+                    . '">'.Display::return_icon($iconnotify, get_lang('NotifyMe')).'</a>';
             }
 
             if (api_is_allowed_to_edit(null, true) && $origin != 'learnpath') {
-                $iconsEdit .= '<a href="' . api_get_self() . '?' . $cidreq . '&forum='
+                $iconsEdit .= '<a href="'.api_get_self().'?'.$cidreq.'&forum='
                     . Security::remove_XSS($my_forum)
                     . "&origin=$origin&action=liststd&content=thread&id={$row['thread_id']}"
-                    . '">' . Display::return_icon($icon_liststd, get_lang('StudentList'), array(), ICON_SIZE_SMALL)
+                    . '">'.Display::return_icon($icon_liststd, get_lang('StudentList'), array(), ICON_SIZE_SMALL)
                     . '</a>';
             }
             $html .= $iconsEdit;

main/forum/forumqualify.php

Spacing +24 added lines, -24 removed lines

@@ -59,12 +59,12 @@ 
 /*
     Header and Breadcrumbs
 */
-if (isset($_SESSION['gradebook'])){
-    $gradebook=	$_SESSION['gradebook'];
+if (isset($_SESSION['gradebook'])) {
+    $gradebook = $_SESSION['gradebook'];
 }
 
-if (!empty($gradebook) && $gradebook=='view') {
-    $interbreadcrumb[]= array (
+if (!empty($gradebook) && $gradebook == 'view') {
+    $interbreadcrumb[] = array(
         'url' => '../gradebook/'.$_SESSION['gradebook_dest'],
         'name' => get_lang('ToolGradebook')
     );
@@ -88,7 +88,7 @@ 
             "name" => prepare4display($currentForum['forum_title'])
         );
         if ($message <> 'PostDeletedSpecial') {
-            $interbreadcrumb[]= array(
+            $interbreadcrumb[] = array(
                 "url" => "viewthread.php?forum=".intval($_GET['forum'])."&gradebook=".$gradebook."&thread=".intval($_GET['thread']),
                 "name" => prepare4display($currentThread['thread_title'])
             );
@@ -119,8 +119,8 @@ 
         );
 
         if ($message <> 'PostDeletedSpecial') {
-            if (isset($_GET['gradebook']) and $_GET['gradebook']=='view') {
-                $info_thread=get_thread_information($_GET['thread']);
+            if (isset($_GET['gradebook']) and $_GET['gradebook'] == 'view') {
+                $info_thread = get_thread_information($_GET['thread']);
                 $interbreadcrumb[] = array(
                     "url" => "viewthread.php?".api_get_cidreq()."&forum=".$info_thread['forum_id']."&thread=".intval($_GET['thread']),
                     "name" => prepare4display($currentThread['thread_title'])
@@ -133,7 +133,7 @@ 
             }
         }
         // the last element of the breadcrumb navigation is already set in interbreadcrumb, so give empty string
-        $interbreadcrumb[]=array("url" => "#","name" => get_lang('QualifyThread'));
+        $interbreadcrumb[] = array("url" => "#", "name" => get_lang('QualifyThread'));
         Display :: display_header('');
     }
 }
@@ -143,7 +143,7 @@ 
 */
 $action = isset($_GET['action']) ? $_GET['action'] : '';
 
-if ($action =='delete' &&
+if ($action == 'delete' &&
     isset($_GET['content']) &&
     isset($_GET['id']) && api_is_allowed_to_edit(false, true)
 ) {
@@ -240,8 +240,8 @@ 
     if (isset($rows)) {
         $counter = 1;
         foreach ($rows as $row) {
-            if ($row['status']=='0') {
-                $style =" id = 'post".$post_en."' class=\"hide-me\" style=\"border:1px solid red; display:none; background-color:#F7F7F7; width:95%; margin: 0px 0px 4px 40px; \" ";
+            if ($row['status'] == '0') {
+                $style = " id = 'post".$post_en."' class=\"hide-me\" style=\"border:1px solid red; display:none; background-color:#F7F7F7; width:95%; margin: 0px 0px 4px 40px; \" ";
             } else {
                 $style = "";
                 $post_en = $row['post_parent_id'];
@@ -258,20 +258,20 @@ 
 
             echo "<div ".$style."><table class=\"data_table\">";
 
-            if ($row['visible']=='0') {
-                $titleclass='forum_message_post_title_2_be_approved';
-                $messageclass='forum_message_post_text_2_be_approved';
-                $leftclass='forum_message_left_2_be_approved';
+            if ($row['visible'] == '0') {
+                $titleclass = 'forum_message_post_title_2_be_approved';
+                $messageclass = 'forum_message_post_text_2_be_approved';
+                $leftclass = 'forum_message_left_2_be_approved';
             } else {
-                $titleclass='forum_message_post_title';
-                $messageclass='forum_message_post_text';
-                $leftclass='forum_message_left';
+                $titleclass = 'forum_message_post_title';
+                $messageclass = 'forum_message_post_text';
+                $leftclass = 'forum_message_left';
             }
 
             echo "<tr>";
             echo "<td rowspan=\"3\" class=\"$leftclass\">";
 
-            echo '<br /><b>'.  api_convert_and_format_date($row['post_date'], DATE_TIME_FORMAT_LONG).'</b><br />';
+            echo '<br /><b>'.api_convert_and_format_date($row['post_date'], DATE_TIME_FORMAT_LONG).'</b><br />';
 
             echo "</td>";
 
@@ -292,7 +292,7 @@ 
                 $realname = $attachment_list['path'];
                 $user_filename = $attachment_list['filename'];
 
-                echo Display::return_icon('attachment.gif',get_lang('Attachment'));
+                echo Display::return_icon('attachment.gif', get_lang('Attachment'));
                 echo '<a href="download.php?file=';
                 echo $realname;
                 echo ' "> '.$user_filename.' </a>';
@@ -311,8 +311,8 @@ 
 
     // Show past data
     if (api_is_allowed_to_edit() && $counter > 0) {
-        if (isset($_GET['gradebook'])){
-            $view_gradebook='&gradebook=view';
+        if (isset($_GET['gradebook'])) {
+            $view_gradebook = '&gradebook=view';
         }
         echo '<h4>'.get_lang('QualificationChangesHistory').'</h4>';
         if (isset($_GET['type']) && $_GET['type'] == 'false') {
@@ -342,12 +342,12 @@ 
             );
             $table_list .= '</td></tr>';
         }
-        $table_list.= '</table>';
+        $table_list .= '</table>';
 
         echo $table_list;
     }
 }
 
-if ($origin!='learnpath') {
+if ($origin != 'learnpath') {
     Display :: display_footer();
 }

main/forum/viewthread.php

Spacing +28 added lines, -28 removed lines

@@ -7,7 +7,7 @@ 
  */
 
 require_once '../inc/global.inc.php';
-$current_course_tool  = TOOL_FORUM;
+$current_course_tool = TOOL_FORUM;
 
 $this_section = SECTION_COURSES;
 
@@ -23,7 +23,7 @@ 
 // Are we in a lp ?
 $origin = '';
 if (isset($_GET['origin'])) {
-    $origin =  Security::remove_XSS($_GET['origin']);
+    $origin = Security::remove_XSS($_GET['origin']);
 }
 $my_search = null;
 $gradebook = null;
@@ -36,10 +36,10 @@ 
 // Note pcool: I tried to use only one sql statement (and function) for this,
 // but the problem is that the visibility of the forum AND forum category are stored in the item_property table.
 // Note: This has to be validated that it is an existing thread
-$current_thread	= get_thread_information($_GET['thread']);
+$current_thread = get_thread_information($_GET['thread']);
 // Note: This has to be validated that it is an existing forum.
-$current_forum	= get_forum_information($current_thread['forum_id']);
-$current_forum_category	= get_forumcategory_information($current_forum['forum_category']);
+$current_forum = get_forum_information($current_thread['forum_id']);
+$current_forum_category = get_forumcategory_information($current_forum['forum_category']);
 $whatsnew_post_info = isset($_SESSION['whatsnew_post_info']) ? $_SESSION['whatsnew_post_info'] : null;
 /* Header and Breadcrumbs */
 
@@ -49,8 +49,8 @@ 
 }
 
 if (!empty($gradebook) && $gradebook == 'view') {
-    $interbreadcrumb[] = array (
-        'url' => '../gradebook/' . $_SESSION['gradebook_dest'],
+    $interbreadcrumb[] = array(
+        'url' => '../gradebook/'.$_SESSION['gradebook_dest'],
         'name' => get_lang('ToolGradebook')
     );
 }
@@ -65,16 +65,16 @@ 
         'name' => get_lang('Groups')
     );
     $interbreadcrumb[] = array(
-        'url' => '../group/group_space.php?' . api_get_cidreq(),
-        'name' => get_lang('GroupSpace') . ' ' . $group_properties['name']
+        'url' => '../group/group_space.php?'.api_get_cidreq(),
+        'name' => get_lang('GroupSpace').' '.$group_properties['name']
     );
     $interbreadcrumb[] = array(
-        'url' => 'viewforum.php?forum=' . intval($_GET['forum']) . '&' . api_get_cidreq()
-            . "&origin=$origin&search=" . Security::remove_XSS(urlencode($my_search)),
+        'url' => 'viewforum.php?forum='.intval($_GET['forum']).'&'.api_get_cidreq()
+            . "&origin=$origin&search=".Security::remove_XSS(urlencode($my_search)),
         'name' => Security::remove_XSS($current_forum['forum_title'])
     );
     $interbreadcrumb[] = array(
-        'url' => 'viewthread.php?forum=' . intval($_GET['forum']) . '&' . api_get_cidreq(). '&thread=' . intval($_GET['thread']),
+        'url' => 'viewthread.php?forum='.intval($_GET['forum']).'&'.api_get_cidreq().'&thread='.intval($_GET['thread']),
         'name' => Security::remove_XSS($current_thread['thread_title'])
     );
 
@@ -87,7 +87,7 @@ 
         $interbreadcrumb[] = array(
             'url' => 'index.php?'
                 . (isset($gradebook) ? "gradebook=$gradebook&" : '')
-                . 'search=' . Security::remove_XSS(urlencode($my_search)),
+                . 'search='.Security::remove_XSS(urlencode($my_search)),
             'name' => $nameTools
         );
         $interbreadcrumb[] = array(
@@ -98,7 +98,7 @@ 
             'name' => Security::remove_XSS($current_forum_category['cat_title'])
         );
         $interbreadcrumb[] = array(
-            'url' => 'viewforum.php?forum=' . intval($_GET['forum'])
+            'url' => 'viewforum.php?forum='.intval($_GET['forum'])
                 . "&origin=$origin&search="
                 . Security::remove_XSS(urlencode($my_search)),
             'name' => Security::remove_XSS($current_forum['forum_title'])
@@ -171,9 +171,9 @@ 
     echo '<div class="actions">';
     echo '<span style="float:right;">'.search_link().'</span>';
     if ($origin != 'learnpath') {
-        echo '<a href="' . $forumUrl . 'viewforum.php?forum='
-            . intval($_GET['forum']) . '&' . api_get_cidreq() . '">'
-            . Display::return_icon('back.png', get_lang('BackToForum'), '', ICON_SIZE_MEDIUM) . '</a>';
+        echo '<a href="'.$forumUrl.'viewforum.php?forum='
+            . intval($_GET['forum']).'&'.api_get_cidreq().'">'
+            . Display::return_icon('back.png', get_lang('BackToForum'), '', ICON_SIZE_MEDIUM).'</a>';
     }
     // The reply to thread link should only appear when the forum_category is
     // not locked AND the forum is not locked AND the thread is not locked.
@@ -189,9 +189,9 @@ 
         if ($_user['user_id'] OR ($current_forum['allow_anonymous'] == 1 && !$_user['user_id'])) {
             // reply link
             if (!api_is_anonymous() && api_is_allowed_to_session_edit(false, true)) {
-                echo '<a href="' . $forumUrl . 'reply.php?' . api_get_cidreq() . '&forum='
-                    . intval($_GET['forum']) . '&thread='
-                    . intval($_GET['thread']) . '&action=replythread">'
+                echo '<a href="'.$forumUrl.'reply.php?'.api_get_cidreq().'&forum='
+                    . intval($_GET['forum']).'&thread='
+                    . intval($_GET['thread']).'&action=replythread">'
                     . Display::return_icon('reply_thread.png', get_lang('ReplyToThread'), '', ICON_SIZE_MEDIUM)
                     . '</a>';
             }
@@ -215,13 +215,13 @@ 
 
     // The different views of the thread.
     if ($origin != 'learnpath') {
-        $my_url = '<a href="' . $forumUrl . 'viewthread.php?' . api_get_cidreq() . '&' . api_get_cidreq()
-            . '&forum=' . intval($_GET['forum']) . '&thread=' . intval($_GET['thread'])
-            . '&search=' . Security::remove_XSS(urlencode($my_search));
-        echo $my_url . '&view=flat">'
+        $my_url = '<a href="'.$forumUrl.'viewthread.php?'.api_get_cidreq().'&'.api_get_cidreq()
+            . '&forum='.intval($_GET['forum']).'&thread='.intval($_GET['thread'])
+            . '&search='.Security::remove_XSS(urlencode($my_search));
+        echo $my_url.'&view=flat">'
             . Display::return_icon('forum_listview.png', get_lang('FlatView'), null, ICON_SIZE_MEDIUM)
             . '</a>';
-        echo $my_url . '&view=nested">'
+        echo $my_url.'&view=nested">'
             . Display::return_icon('forum_nestedview.png', get_lang('NestedView'), null, ICON_SIZE_MEDIUM)
             . '</a>';
     }
@@ -231,7 +231,7 @@ 
 
     /* Display Forum Category and the Forum information */
 
-    if (!isset($_SESSION['view']))	{
+    if (!isset($_SESSION['view'])) {
         $viewMode = $current_forum['default_view'];
     } else {
         $viewMode = $_SESSION['view'];
@@ -247,7 +247,7 @@ 
     }
 
     if (isset($_GET['msg']) && isset($_GET['type'])) {
-        switch($_GET['type']) {
+        switch ($_GET['type']) {
             case 'error':
                 Display::display_error_message($_GET['msg']);
                 break;
@@ -257,7 +257,7 @@ 
         }
     }
 
-    if ($current_thread['thread_peer_qualify'] == 1 ) {
+    if ($current_thread['thread_peer_qualify'] == 1) {
         echo Display::return_message(get_lang('ForumThreadPeerScoringStudentComment'), 'info');
     }
 

main/forum/reply.php

Spacing +7 added lines, -7 removed lines

@@ -30,7 +30,7 @@ 
 
 $origin = '';
 if (isset($_GET['origin'])) {
-    $origin =  Security::remove_XSS($_GET['origin']);
+    $origin = Security::remove_XSS($_GET['origin']);
     $origin_string = '&origin='.$origin;
 }
 
@@ -44,8 +44,8 @@ 
 // We are getting all the information about the current forum and forum category.
 // Note pcool: I tried to use only one sql statement (and function) for this,
 // but the problem is that the visibility of the forum AND forum cateogory are stored in the item_property table.
-$current_thread	= get_thread_information($_GET['thread']); // Note: This has to be validated that it is an existing thread.
-$current_forum	= get_forum_information($current_thread['forum_id']); // Note: This has to be validated that it is an existing forum.
+$current_thread = get_thread_information($_GET['thread']); // Note: This has to be validated that it is an existing thread.
+$current_forum = get_forum_information($current_thread['forum_id']); // Note: This has to be validated that it is an existing forum.
 $current_forum_category = get_forumcategory_information(Security::remove_XSS($current_forum['forum_category']));
 
 /* Is the user allowed here? */
@@ -80,12 +80,12 @@ 
 /* Breadcrumbs */
 
 $gradebook = null;
-if (isset($_SESSION['gradebook'])){
+if (isset($_SESSION['gradebook'])) {
     $gradebook = Security::remove_XSS($_SESSION['gradebook']);
 }
 
 if (!empty($gradebook) && $gradebook == 'view') {
-    $interbreadcrumb[] = array (
+    $interbreadcrumb[] = array(
         'url' => '../gradebook/'.Security::remove_XSS($_SESSION['gradebook_dest']),
         'name' => get_lang('ToolGradebook')
     );
@@ -188,7 +188,7 @@ 
 /* End new display forum */
 // The form for the reply
 $my_action   = isset($_GET['action']) ? Security::remove_XSS($_GET['action']) : '';
-$my_post     = isset($_GET['post']) ?   Security::remove_XSS($_GET['post']) : '';
+$my_post     = isset($_GET['post']) ? Security::remove_XSS($_GET['post']) : '';
 $my_elements = isset($_SESSION['formelements']) ? $_SESSION['formelements'] : '';
 $values = show_add_post_form(
     $current_forum,
@@ -202,7 +202,7 @@ 
     //@todo split the show_add_post_form function
     $origin = isset($_GET['origin']) && $_GET['origin'] === 'learnpath' ? 'learnpath' : null;
 
-    $url = 'viewthread.php?' . http_build_query([
+    $url = 'viewthread.php?'.http_build_query([
         'forum' => $current_thread['forum_id'],
         'gradebook' => $gradebook,
         'thread' => intval($_GET['thread']),