chamilo / chamilo-lms

main/mySpace/myStudents.php

Indentation +1 added lines, -1 removed lines

@@ -989,7 +989,7 @@
                     $data_learnpath[$i][] = $progress . '%';
                 }
 
-                 ?>
+                    ?>
             </tbody>
             </table>
             </div>

Spacing +71 added lines, -71 removed lines

@@ -64,52 +64,52 @@ 
 if (isset($_GET['details'])) {
     if ($origin == 'user_course') {
         if (empty ($cidReq)) {
-            $interbreadcrumb[] = array (
-                "url" => api_get_path(WEB_COURSE_PATH) . $courseInfo['directory'],
+            $interbreadcrumb[] = array(
+                "url" => api_get_path(WEB_COURSE_PATH).$courseInfo['directory'],
                 'name' => $courseInfo['title']
             );
         }
-        $interbreadcrumb[] = array (
-            "url" => "../user/user.php?cidReq=" . $course_code,
+        $interbreadcrumb[] = array(
+            "url" => "../user/user.php?cidReq=".$course_code,
             "name" => get_lang("Users")
         );
     } else
         if ($origin == 'tracking_course') {
-            $interbreadcrumb[] = array (
-                "url" => "../tracking/courseLog.php?cidReq=".$course_code.'&id_session=' . api_get_session_id(),
+            $interbreadcrumb[] = array(
+                "url" => "../tracking/courseLog.php?cidReq=".$course_code.'&id_session='.api_get_session_id(),
                 "name" => get_lang("Tracking")
             );
         } else
             if ($origin == 'resume_session') {
-                $interbreadcrumb[] = array (
+                $interbreadcrumb[] = array(
                     'url' => "../session/session_list.php",
                     "name" => get_lang('SessionList')
                 );
-                $interbreadcrumb[] = array (
-                    'url' => "../session/resume_session.php?id_session=" . $sessionId,
+                $interbreadcrumb[] = array(
+                    'url' => "../session/resume_session.php?id_session=".$sessionId,
                     "name" => get_lang('SessionOverview')
                 );
             } else {
-                $interbreadcrumb[] = array (
+                $interbreadcrumb[] = array(
                     "url" => "index.php",
                     "name" => get_lang('MySpace')
                 );
                 if (isset ($_GET['id_coach']) && intval($_GET['id_coach']) != 0) {
-                    $interbreadcrumb[] = array (
-                        "url" => "student.php?id_coach=" . Security :: remove_XSS($_GET['id_coach']),
+                    $interbreadcrumb[] = array(
+                        "url" => "student.php?id_coach=".Security :: remove_XSS($_GET['id_coach']),
                         "name" => get_lang("CoachStudents")
                     );
-                    $interbreadcrumb[] = array (
-                        "url" => "myStudents.php?student=" . Security :: remove_XSS($_GET['student']) . '&id_coach=' . Security :: remove_XSS($_GET['id_coach']),
+                    $interbreadcrumb[] = array(
+                        "url" => "myStudents.php?student=".Security :: remove_XSS($_GET['student']).'&id_coach='.Security :: remove_XSS($_GET['id_coach']),
                         "name" => get_lang("StudentDetails")
                     );
                 } else {
-                    $interbreadcrumb[] = array (
+                    $interbreadcrumb[] = array(
                         "url" => "student.php",
                         "name" => get_lang("MyStudents")
                     );
-                    $interbreadcrumb[] = array (
-                        "url" => "myStudents.php?student=" . Security :: remove_XSS($_GET['student']),
+                    $interbreadcrumb[] = array(
+                        "url" => "myStudents.php?student=".Security :: remove_XSS($_GET['student']),
                         "name" => get_lang("StudentDetails")
                     );
                 }
@@ -117,7 +117,7 @@ 
     $nameTools = get_lang("DetailsStudentInCourse");
 } else {
     if ($origin == 'resume_session') {
-        $interbreadcrumb[] = array (
+        $interbreadcrumb[] = array(
             'url' => "../session/session_list.php",
             "name" => get_lang('SessionList')
         );
@@ -128,24 +128,24 @@ 
             );
         }
     } else {
-        $interbreadcrumb[] = array (
+        $interbreadcrumb[] = array(
             "url" => "index.php",
             "name" => get_lang('MySpace')
         );
         if (isset ($_GET['id_coach']) && intval($_GET['id_coach']) != 0) {
             if ($sessionId) {
-                $interbreadcrumb[] = array (
-                    "url" => "student.php?id_coach=" . Security :: remove_XSS($_GET['id_coach']) . "&id_session=" . $sessionId,
+                $interbreadcrumb[] = array(
+                    "url" => "student.php?id_coach=".Security :: remove_XSS($_GET['id_coach'])."&id_session=".$sessionId,
                     "name" => get_lang("CoachStudents")
                 );
             } else {
-                $interbreadcrumb[] = array (
-                    "url" => "student.php?id_coach=" . Security :: remove_XSS($_GET['id_coach']),
+                $interbreadcrumb[] = array(
+                    "url" => "student.php?id_coach=".Security :: remove_XSS($_GET['id_coach']),
                     "name" => get_lang("CoachStudents")
                 );
             }
         } else {
-            $interbreadcrumb[] = array (
+            $interbreadcrumb[] = array(
                 "url" => "student.php",
                 "name" => get_lang("MyStudents")
             );
@@ -316,28 +316,28 @@ 
     // Actions bar
     echo '<div class="actions">';
     echo '<a href="javascript: window.history.go(-1);">'.
-            Display::return_icon('back.png', get_lang('Back'),'',ICON_SIZE_MEDIUM).'</a>';
+            Display::return_icon('back.png', get_lang('Back'), '', ICON_SIZE_MEDIUM).'</a>';
 
     echo '<a href="javascript: void(0);" onclick="javascript: window.print();">'.
-            Display::return_icon('printer.png', get_lang('Print'),'',ICON_SIZE_MEDIUM).'</a>';
+            Display::return_icon('printer.png', get_lang('Print'), '', ICON_SIZE_MEDIUM).'</a>';
 
-    echo '<a href="' . api_get_self() . '?' . Security :: remove_XSS($_SERVER['QUERY_STRING']) . '&export=csv">'.
-            Display::return_icon('export_csv.png', get_lang('ExportAsCSV'),'',ICON_SIZE_MEDIUM).'</a> ';
+    echo '<a href="'.api_get_self().'?'.Security :: remove_XSS($_SERVER['QUERY_STRING']).'&export=csv">'.
+            Display::return_icon('export_csv.png', get_lang('ExportAsCSV'), '', ICON_SIZE_MEDIUM).'</a> ';
 
-    echo '<a href="' . api_get_self() . '?' . Security :: remove_XSS($_SERVER['QUERY_STRING']) . '&export=xls">'.
-    Display::return_icon('export_excel.png', get_lang('ExportAsXLS'),'',ICON_SIZE_MEDIUM).'</a> ';
+    echo '<a href="'.api_get_self().'?'.Security :: remove_XSS($_SERVER['QUERY_STRING']).'&export=xls">'.
+    Display::return_icon('export_excel.png', get_lang('ExportAsXLS'), '', ICON_SIZE_MEDIUM).'</a> ';
 
     if (!empty ($user_info['email'])) {
         $send_mail = '<a href="mailto:'.$user_info['email'].'">'.
-            Display :: return_icon('mail_send.png', get_lang('SendMail'),'',ICON_SIZE_MEDIUM).'</a>';
+            Display :: return_icon('mail_send.png', get_lang('SendMail'), '', ICON_SIZE_MEDIUM).'</a>';
     } else {
-        $send_mail = Display :: return_icon('mail_send_na.png', get_lang('SendMail'),'',ICON_SIZE_MEDIUM);
+        $send_mail = Display :: return_icon('mail_send_na.png', get_lang('SendMail'), '', ICON_SIZE_MEDIUM);
     }
     echo $send_mail;
     if (!empty($student_id) && !empty($_GET['course'])) {
         // Only show link to connection details if course and student were defined in the URL
-        echo '<a href="access_details.php?student=' . $student_id . '&course=' . Security :: remove_XSS($_GET['course']) . '&origin=' . $origin. '&cidReq='.Security::remove_XSS($_GET['course']).'&id_session='.$sessionId.'">'.
-            Display :: return_icon('statistics.png', get_lang('AccessDetails'),'',ICON_SIZE_MEDIUM).'</a>';
+        echo '<a href="access_details.php?student='.$student_id.'&course='.Security :: remove_XSS($_GET['course']).'&origin='.$origin.'&cidReq='.Security::remove_XSS($_GET['course']).'&id_session='.$sessionId.'">'.
+            Display :: return_icon('statistics.png', get_lang('AccessDetails'), '', ICON_SIZE_MEDIUM).'</a>';
     }
     if (api_can_login_as($student_id)) {
         echo '<a href="'.api_get_path(WEB_CODE_PATH).'admin/user_list.php?action=login_as&user_id='.$student_id.'&sec_token='.$token.'">'.
@@ -402,7 +402,7 @@ 
     $csv_content[] = array(
         get_lang('Information', '')
     );
-    $csv_content[] = array (
+    $csv_content[] = array(
         get_lang('Name', ''),
         get_lang('Email', ''),
         get_lang('Tel', '')
@@ -430,7 +430,7 @@ 
         strip_tags($first_connection_date),
         strip_tags($last_connection_date),
         $time_spent_on_the_course,
-        $avg_student_progress . '%',
+        $avg_student_progress.'%',
         $avg_student_score
     );
 
@@ -478,19 +478,19 @@ 
             </thead>
             <tbody>
             <tr>
-                <td><?php echo get_lang('Name') . ' : '.$user_info['complete_name']; ?></td>
+                <td><?php echo get_lang('Name').' : '.$user_info['complete_name']; ?></td>
             </tr>
             <tr>
-                <td><?php echo get_lang('Email') . ' : ';
+                <td><?php echo get_lang('Email').' : ';
                     if (!empty ($user_info['email'])) {
-                        echo '<a href="mailto:' . $user_info['email'] . '">' . $user_info['email'] . '</a>';
+                        echo '<a href="mailto:'.$user_info['email'].'">'.$user_info['email'].'</a>';
                     } else {
                         echo get_lang('NoEmail');
                     } ?>
                 </td>
             </tr>
             <tr>
-                <td> <?php echo get_lang('Tel') . ' : ';
+                <td> <?php echo get_lang('Tel').' : ';
                     if (!empty ($user_info['phone'])) {
                         echo $user_info['phone'];
                     } else {
@@ -500,7 +500,7 @@ 
                 </td>
             </tr>
             <tr>
-                <td> <?php echo get_lang('OfficialCode') . ' : ';
+                <td> <?php echo get_lang('OfficialCode').' : ';
                     if (!empty ($user_info['official_code'])) {
                         echo $user_info['official_code'];
                     } else {
@@ -510,13 +510,13 @@ 
                 </td>
             </tr>
             <tr>
-                <td><?php echo get_lang('OnLine') . ' : '.$online; ?> </td>
+                <td><?php echo get_lang('OnLine').' : '.$online; ?> </td>
             </tr>
             <?php
 
             // Display timezone if the user selected one and if the admin allows the use of user's timezone
             $timezone = null;
-            $timezone_user = UserManager::get_extra_user_data_by_field($user_info['user_id'],'timezone');
+            $timezone_user = UserManager::get_extra_user_data_by_field($user_info['user_id'], 'timezone');
             $use_users_timezone = api_get_setting('use_users_timezone', 'timezones');
             if ($timezone_user['timezone'] != null && $use_users_timezone == 'true') {
                 $timezone = $timezone_user['timezone'];
@@ -524,7 +524,7 @@ 
             if ($timezone !== null) {
                 ?>
                 <tr>
-                    <td> <?php echo get_lang('Timezone') . ' : '.$timezone; ?> </td>
+                    <td> <?php echo get_lang('Timezone').' : '.$timezone; ?> </td>
                 </tr>
             <?php
             }
@@ -556,7 +556,7 @@ 
                     <td align="right">
                         <?php
                         echo get_lang('Progress').' ';
-                        Display :: display_icon('info3.gif', get_lang('ScormAndLPProgressTotalAverage'), array ('align' => 'absmiddle', 'hspace' => '3px'));?>
+                        Display :: display_icon('info3.gif', get_lang('ScormAndLPProgressTotalAverage'), array('align' => 'absmiddle', 'hspace' => '3px')); ?>
                     </td>
                     <td align="left"><?php echo $avg_student_progress.'%' ?></td>
                 </tr>
@@ -564,7 +564,7 @@ 
                     <td align="right">
                         <?php
                         echo get_lang('Score').' ';
-                        Display :: display_icon('info3.gif', get_lang('ScormAndLPTestTotalAverage'), array ('align' => 'absmiddle', 'hspace' => '3px')); ?>
+                        Display :: display_icon('info3.gif', get_lang('ScormAndLPTestTotalAverage'), array('align' => 'absmiddle', 'hspace' => '3px')); ?>
                     </td>
                     <td align="left"><?php
                         if (is_numeric($avg_student_score)) {
@@ -630,9 +630,9 @@ 
                 }
 
                 if (!empty($access_start_date) && !empty($access_end_date)) {
-                    $date_session = get_lang('From') . ' ' . $access_start_date . ' ' . get_lang('Until') . ' ' . $access_end_date;
+                    $date_session = get_lang('From').' '.$access_start_date.' '.get_lang('Until').' '.$access_end_date;
                 }
-                $title = Display::return_icon('session.png', get_lang('Session'), array(), ICON_SIZE_SMALL).' '.$session_name.($date_session?' ('.$date_session.')':'');
+                $title = Display::return_icon('session.png', get_lang('Session'), array(), ICON_SIZE_SMALL).' '.$session_name.($date_session ? ' ('.$date_session.')' : '');
             }
 
             // Courses
@@ -687,16 +687,16 @@ 
                         $scoretotal = array();
                         if (isset($cats) && isset($cats[0])) {
                             if (!empty($sessionId)) {
-                                $scoretotal= $cats[0]->calc_score($student_id, null, $courseCodeItem, $sessionId);
+                                $scoretotal = $cats[0]->calc_score($student_id, null, $courseCodeItem, $sessionId);
                             } else {
-                                $scoretotal= $cats[0]->calc_score($student_id, null, $courseCodeItem);
+                                $scoretotal = $cats[0]->calc_score($student_id, null, $courseCodeItem);
                             }
                         }
 
                         $scoretotal_display = '0/0 (0%)';
                         if (!empty($scoretotal)) {
                             $scoretotal_display =
-                                round($scoretotal[0], 1 ).'/'.
+                                round($scoretotal[0], 1).'/'.
                                 round($scoretotal[1], 1).
                                 ' ('.round(($scoretotal[0] / $scoretotal[1]) * 100, 2).' %)';
                         }
@@ -717,9 +717,9 @@ 
                         );
 
                         echo '<tr>
-                        <td ><a href="' .$courseInfoItem['course_public_url'] .'?id_session=' . $sessionId . '">'.
+                        <td ><a href="' .$courseInfoItem['course_public_url'].'?id_session='.$sessionId.'">'.
                             $courseInfoItem['title'].'</a></td>
-                        <td >'.$time_spent_on_course .'</td>
+                        <td >'.$time_spent_on_course.'</td>
                         <td >'.$progress.'</td>
                         <td >'.$score.'</td>
                         <td >'.$attendances_faults_avg.'</td>
@@ -789,7 +789,7 @@ 
                 <table class="table table-striped table-hover">
                 <thead>
                 <tr>
-                    <th><?php echo get_lang('LearningPath');?></th>
+                    <th><?php echo get_lang('LearningPath'); ?></th>
                     <th>
                         <?php
                         echo get_lang('Time').' ';
@@ -864,7 +864,7 @@ 
 
                     if ($progress === null) {
                         $progress = '0%';
-                    }  else {
+                    } else {
                         $any_result = true;
                     }
 
@@ -891,7 +891,7 @@ 
                     if (!empty($start_time)) {
                         $start_time = api_convert_and_format_date($start_time, DATE_TIME_FORMAT_LONG);
                     } else {
-                        $start_time =  '-';
+                        $start_time = '-';
                     }
 
                     if (!empty($total_time)) $any_result = true;
@@ -923,11 +923,11 @@ 
                     $i++;
 
                     // csv export content
-                    $csv_content[] = array (
+                    $csv_content[] = array(
                         api_html_entity_decode(stripslashes($lp_name), ENT_QUOTES, $charset),
                         api_time_to_hms($total_time),
-                        $score . '%',
-                        $score_latest . '%',
+                        $score.'%',
+                        $score_latest.'%',
                         $progress.'%',
                         $start_time
                     );
@@ -966,7 +966,7 @@ 
                     if ($any_result === true) {
                         $from = '';
                         if ($from_myspace) {
-                            $from ='&from=myspace';
+                            $from = '&from=myspace';
                         }
                         $link = Display::url(
                             Display::return_icon('2rightarrow.png', get_lang('Details')),
@@ -979,14 +979,14 @@ 
                         echo '<td>';
                         if ($any_result === true) {
                             echo '<a href="myStudents.php?action=reset_lp&sec_token='.$token.'&cidReq='.Security::remove_XSS($_GET['course']).'&course='.Security::remove_XSS($_GET['course']).'&details='.Security::remove_XSS($_GET['details']).'&origin='.$origin.'&lp_id='.$learnpath->getId().'&student='.$user_info['user_id'].'&details=true&id_session='.$sessionId.'">';
-                            echo Display::return_icon('clean.png', get_lang('Clean'),'',ICON_SIZE_SMALL).'</a>';
+                            echo Display::return_icon('clean.png', get_lang('Clean'), '', ICON_SIZE_SMALL).'</a>';
                             echo '</a>';
                         }
                         echo '</td>';
                         echo '</tr>';
                     }
                     $data_learnpath[$i][] = $lp_name;
-                    $data_learnpath[$i][] = $progress . '%';
+                    $data_learnpath[$i][] = $progress.'%';
                 }
 
                  ?>
@@ -1004,7 +1004,7 @@ 
             <thead>
             <tr>
                 <th><?php echo get_lang('Exercises'); ?></th>
-                <th><?php echo get_lang('LearningPath');?></th>
+                <th><?php echo get_lang('LearningPath'); ?></th>
                 <th><?php echo get_lang('AvgCourseScore').' '.Display :: return_icon('info3.gif', get_lang('AverageScore'), array('align' => 'absmiddle', 'hspace' => '3px')) ?></th>
                 <th><?php echo get_lang('Attempts'); ?></th>
                 <th><?php echo get_lang('LatestAttempt'); ?></th>
@@ -1023,7 +1023,7 @@ 
             );
 
             $t_quiz = Database :: get_course_table(TABLE_QUIZ_TEST);
-            $sql = "SELECT quiz.title, id FROM " . $t_quiz . " AS quiz
+            $sql = "SELECT quiz.title, id FROM ".$t_quiz." AS quiz
                     WHERE
                         quiz.c_id =  ".$courseInfo['real_id']." AND
                         (quiz.session_id = $sessionId OR quiz.session_id = 0) AND
@@ -1088,7 +1088,7 @@ 
                     echo '<td>';
 
                     if ($count_attempts > 0) {
-                        echo $score_percentage . '%';
+                        echo $score_percentage.'%';
                     } else {
                         echo '-';
                         $score_percentage = 0;
@@ -1098,7 +1098,7 @@ 
                     echo '<td>'.$count_attempts.'</td>';
                     echo '<td>';
 
-                    $sql = 'SELECT exe_id FROM ' . $tbl_stats_exercices . '
+                    $sql = 'SELECT exe_id FROM '.$tbl_stats_exercices.'
                              WHERE
                                 exe_exo_id = "'.$exercise_id.'" AND
                                 exe_user_id ="'.$student_id.'" AND
@@ -1111,7 +1111,7 @@ 
                     if (Database :: num_rows($result_last_attempt) > 0) {
                         $id_last_attempt = Database :: result($result_last_attempt, 0, 0);
                         if ($count_attempts > 0)
-                            echo '<a href="../exercice/exercise_show.php?id=' . $id_last_attempt . '&cidReq='.$course_code.'&session_id='.$sessionId.'&student='.$student_id.'&origin='.(empty($origin)?'tracking':$origin).'">
+                            echo '<a href="../exercice/exercise_show.php?id='.$id_last_attempt.'&cidReq='.$course_code.'&session_id='.$sessionId.'&student='.$student_id.'&origin='.(empty($origin) ? 'tracking' : $origin).'">
                             '.Display::return_icon('quiz.gif').'
                          </a>';
                     }
@@ -1119,11 +1119,11 @@ 
 
                     echo '<td>';
                     $all_attempt_url = "../exercice/exercise_report.php?exerciseId=$exercise_id&cidReq=$course_code&filter_by_user=$student_id&id_session=$sessionId";
-                    echo Display::url(Display::return_icon('test_results.png', get_lang('AllAttempts'), array(), ICON_SIZE_SMALL), $all_attempt_url );
+                    echo Display::url(Display::return_icon('test_results.png', get_lang('AllAttempts'), array(), ICON_SIZE_SMALL), $all_attempt_url);
 
                     echo '</td></tr>';
                     $data_exercices[$i][] = $exercices['title'];
-                    $data_exercices[$i][] = $score_percentage . '%';
+                    $data_exercices[$i][] = $score_percentage.'%';
                     $data_exercices[$i][] = $count_attempts;
 
                     $csv_content[] = array(
@@ -1151,7 +1151,7 @@ 
             $survey_list = SurveyManager::get_surveys($course_code, $sessionId);
 
             $survey_data = array();
-            foreach($survey_list as $survey) {
+            foreach ($survey_list as $survey) {
                 $user_list = SurveyManager::get_people_who_filled_survey($survey['survey_id'], false, $courseInfo['real_id']);
                 $survey_done = Display::return_icon("accept_na.png", get_lang('NoAnswer'), array(), ICON_SIZE_SMALL);
                 if (in_array($student_id, $user_list)) {
@@ -1176,7 +1176,7 @@ 
                         $column = 0;
                         $table->setCellContents($row, $column, $data);
                         $class = 'class="row_odd"';
-                        if($row % 2) {
+                        if ($row % 2) {
                             $class = 'class="row_even"';
                         }
                         $table->setRowAttributes($row, $class, true);

Braces +7 added lines, -4 removed lines

@@ -864,7 +864,7 @@ 
 
                     if ($progress === null) {
                         $progress = '0%';
-                    }  else {
+                    } else {
                         $any_result = true;
                     }
 
@@ -894,7 +894,9 @@ 
                         $start_time =  '-';
                     }
 
-                    if (!empty($total_time)) $any_result = true;
+                    if (!empty($total_time)) {
+                        $any_result = true;
+                    }
 
                     // Quiz in lp
                     $score = Tracking::get_avg_student_score(
@@ -1110,10 +1112,11 @@ 
                     $result_last_attempt = Database::query($sql);
                     if (Database :: num_rows($result_last_attempt) > 0) {
                         $id_last_attempt = Database :: result($result_last_attempt, 0, 0);
-                        if ($count_attempts > 0)
-                            echo '<a href="../exercice/exercise_show.php?id=' . $id_last_attempt . '&cidReq='.$course_code.'&session_id='.$sessionId.'&student='.$student_id.'&origin='.(empty($origin)?'tracking':$origin).'">
+                        if ($count_attempts > 0) {
+                                                    echo '<a href="../exercice/exercise_show.php?id=' . $id_last_attempt . '&cidReq='.$course_code.'&session_id='.$sessionId.'&student='.$student_id.'&origin='.(empty($origin)?'tracking':$origin).'">
                             '.Display::return_icon('quiz.gif').'
                          </a>';
+                        }
                     }
                     echo '</td>';