chamilo / chamilo-lms

main/inc/lib/api.lib.php

Spacing +148 added lines, -148 removed lines

@@ -38,19 +38,19 @@ 
 define('PLATFORM_ADMIN', 11);
 define('SESSION_COURSE_COACH', 12);
 define('SESSION_GENERAL_COACH', 13);
-define('COURSE_STUDENT', 14);   //student subscribed in a course
-define('SESSION_STUDENT', 15);  //student subscribed in a session course
+define('COURSE_STUDENT', 14); //student subscribed in a course
+define('SESSION_STUDENT', 15); //student subscribed in a session course
 define('COURSE_TUTOR', 16); // student is tutor of a course (NOT in session)
 define('STUDENT_BOSS', 17); // student is boss
 define('INVITEE', 20);
 
 // Table of status
-$_status_list[COURSEMANAGER] = 'teacher';        // 1
-$_status_list[SESSIONADMIN] = 'session_admin';  // 3
-$_status_list[DRH] = 'drh';            // 4
-$_status_list[STUDENT] = 'user';           // 5
-$_status_list[ANONYMOUS] = 'anonymous';      // 6
-$_status_list[INVITEE] = 'invited';        // 20
+$_status_list[COURSEMANAGER] = 'teacher'; // 1
+$_status_list[SESSIONADMIN] = 'session_admin'; // 3
+$_status_list[DRH] = 'drh'; // 4
+$_status_list[STUDENT] = 'user'; // 5
+$_status_list[ANONYMOUS] = 'anonymous'; // 6
+$_status_list[INVITEE] = 'invited'; // 20
 
 // COURSE VISIBILITY CONSTANTS
 /** only visible for course admin */
@@ -264,14 +264,14 @@ 
 define('IS_WINDOWS_OS', api_is_windows_os());
 
 // Checks for installed optional php-extensions.
-define('INTL_INSTALLED', function_exists('intl_get_error_code'));   // intl extension (from PECL), it is installed by default as of PHP 5.3.0
-define('ICONV_INSTALLED', function_exists('iconv'));                // iconv extension, for PHP5 on Windows it is installed by default.
-define('MBSTRING_INSTALLED', function_exists('mb_strlen'));         // mbstring extension.
+define('INTL_INSTALLED', function_exists('intl_get_error_code')); // intl extension (from PECL), it is installed by default as of PHP 5.3.0
+define('ICONV_INSTALLED', function_exists('iconv')); // iconv extension, for PHP5 on Windows it is installed by default.
+define('MBSTRING_INSTALLED', function_exists('mb_strlen')); // mbstring extension.
 
 // Patterns for processing paths.                                   // Examples:
-define('REPEATED_SLASHES_PURIFIER', '/\/{2,}/');                    // $path = preg_replace(REPEATED_SLASHES_PURIFIER, '/', $path);
-define('VALID_WEB_PATH', '/https?:\/\/[^\/]*(\/.*)?/i');            // $is_valid_path = preg_match(VALID_WEB_PATH, $path);
-define('VALID_WEB_SERVER_BASE', '/https?:\/\/[^\/]*/i');            // $new_path = preg_replace(VALID_WEB_SERVER_BASE, $new_base, $path);
+define('REPEATED_SLASHES_PURIFIER', '/\/{2,}/'); // $path = preg_replace(REPEATED_SLASHES_PURIFIER, '/', $path);
+define('VALID_WEB_PATH', '/https?:\/\/[^\/]*(\/.*)?/i'); // $is_valid_path = preg_match(VALID_WEB_PATH, $path);
+define('VALID_WEB_SERVER_BASE', '/https?:\/\/[^\/]*/i'); // $new_path = preg_replace(VALID_WEB_SERVER_BASE, $new_base, $path);
 
 // Constants for api_get_path() and api_get_path_type(), etc. - registered path types.
 // basic (leaf elements)
@@ -364,19 +364,19 @@ 
 define('LINK_HOTPOTATOES', 9);
 
 // Score display types constants
-define('SCORE_DIV', 1);    // X / Y
-define('SCORE_PERCENT', 2);    // XX %
-define('SCORE_DIV_PERCENT', 3);    // X / Y (XX %)
-define('SCORE_AVERAGE', 4);    // XX %
-define('SCORE_DECIMAL', 5);    // 0.50  (X/Y)
-define('SCORE_BAR', 6);    // Uses the Display::bar_progress function
-define('SCORE_SIMPLE', 7);    // X
-define('SCORE_IGNORE_SPLIT', 8);    //  ??
-define('SCORE_DIV_PERCENT_WITH_CUSTOM', 9);    // X / Y (XX %) - Good!
-define('SCORE_CUSTOM', 10);    // Good!
-define('SCORE_DIV_SIMPLE_WITH_CUSTOM', 11);    // X - Good!
-define('SCORE_DIV_SIMPLE_WITH_CUSTOM_LETTERS', 12);    // X - Good!
-define('SCORE_ONLY_SCORE', 13);    // X - Good!
+define('SCORE_DIV', 1); // X / Y
+define('SCORE_PERCENT', 2); // XX %
+define('SCORE_DIV_PERCENT', 3); // X / Y (XX %)
+define('SCORE_AVERAGE', 4); // XX %
+define('SCORE_DECIMAL', 5); // 0.50  (X/Y)
+define('SCORE_BAR', 6); // Uses the Display::bar_progress function
+define('SCORE_SIMPLE', 7); // X
+define('SCORE_IGNORE_SPLIT', 8); //  ??
+define('SCORE_DIV_PERCENT_WITH_CUSTOM', 9); // X / Y (XX %) - Good!
+define('SCORE_CUSTOM', 10); // Good!
+define('SCORE_DIV_SIMPLE_WITH_CUSTOM', 11); // X - Good!
+define('SCORE_DIV_SIMPLE_WITH_CUSTOM_LETTERS', 12); // X - Good!
+define('SCORE_ONLY_SCORE', 13); // X - Good!
 
 define('SCORE_BOTH', 1);
 define('SCORE_ONLY_DEFAULT', 2);
@@ -561,8 +561,8 @@ 
 define('TIMELINE_STATUS_INACTIVE', '2');
 
 // Event email template class
-define ('EVENT_EMAIL_TEMPLATE_ACTIVE',  1);
-define ('EVENT_EMAIL_TEMPLATE_INACTIVE', 0);
+define('EVENT_EMAIL_TEMPLATE_ACTIVE', 1);
+define('EVENT_EMAIL_TEMPLATE_INACTIVE', 0);
 
 // Course home
 define('SHORTCUTS_HORIZONTAL', 0);
@@ -635,8 +635,8 @@ 
                     : 'localhost')));
                 if (isset($_SERVER['SERVER_PORT']) && !strpos($server_name, ':')
                     && (($server_protocol == 'http'
-                    && $_SERVER['SERVER_PORT'] != 80 ) || ($server_protocol == 'https' && $_SERVER['SERVER_PORT'] != 443 ))) {
-                    $server_name .= ":" . $_SERVER['SERVER_PORT'];
+                    && $_SERVER['SERVER_PORT'] != 80) || ($server_protocol == 'https' && $_SERVER['SERVER_PORT'] != 443))) {
+                    $server_name .= ":".$_SERVER['SERVER_PORT'];
                 }
                 $root_web = $server_protocol.'://'.$server_name.$root_rel;
                 $root_sys = str_replace('\\', '/', realpath(__DIR__.'/../../../')).'/';
@@ -820,7 +820,7 @@ 
                 $sys_course_code =
                     isset($_SESSION['_course']['sysCode'])  // User is inside a course?
                         ? $_SESSION['_course']['sysCode']   // Yes, then use course's directory name.
-                        : '{SYS_COURSE_CODE}';              // No, then use a fake code, it may be processed later.
+                        : '{SYS_COURSE_CODE}'; // No, then use a fake code, it may be processed later.
                 $path = $matches[1].'courses/'.$sys_course_code.'/document/'.str_replace('//', '/', $matches[3].'/'.$matches[2]);
             }
         }
@@ -846,15 +846,15 @@ 
 {
     global $_configuration;
     $web_root = api_get_path(WEB_PATH);
-    $ext = substr($web_path,strrpos($web_path,'.'));
+    $ext = substr($web_path, strrpos($web_path, '.'));
     if (isset($ext[2])) { // faster version of strlen to check if len>2
         // Check for CDN definitions
         if (!empty($_configuration['cdn_enable']) && !empty($ext)) {
             foreach ($_configuration['cdn'] as $host => $exts) {
-                if (in_array($ext,$exts)) {
+                if (in_array($ext, $exts)) {
                     //Use host as defined in $_configuration['cdn'], without
                     // trailing slash
-                    return str_replace($web_root,$host.'/',$web_path);
+                    return str_replace($web_root, $host.'/', $web_path);
                 }
             }
         }
@@ -1295,10 +1295,10 @@ 
 
     if (isset($user['email'])) {
         $result['mail'] = isset($user['email']) ? $user['email'] : null;
-        $result['email'] = isset($user['email'])? $user['email'] : null;
+        $result['email'] = isset($user['email']) ? $user['email'] : null;
     } else {
         $result['mail'] = isset($user['mail']) ? $user['mail'] : null;
-        $result['email'] = isset($user['mail'])? $user['mail'] : null;
+        $result['email'] = isset($user['mail']) ? $user['mail'] : null;
     }
     $user_id = intval($user['user_id']);
     // Maintain the user_id index for backwards compatibility
@@ -1801,7 +1801,7 @@ 
         foreach ($param_list1 as $key => $enreg) {
             list ($param_list1_keys[$key], $param_list1_vals[$key]) = explode('=', $enreg);
         }
-        $param_list1 = array ('keys' => $param_list1_keys, 'vals' => $param_list1_vals);
+        $param_list1 = array('keys' => $param_list1_keys, 'vals' => $param_list1_vals);
         foreach ($param_list2 as $enreg) {
             $enreg = explode('=', $enreg);
             $key = array_search($enreg[0], $param_list1['keys']);
@@ -1831,7 +1831,7 @@ 
         $length = 2;
     }
     $password = '';
-    for ($i = 0; $i < $length; $i ++) {
+    for ($i = 0; $i < $length; $i++) {
         $password .= $characters[rand() % strlen($characters)];
     }
     return $password;
@@ -1858,10 +1858,10 @@ 
     $digits = 0;
     $consequent_characters = 0;
     $previous_character_code = 0;
-    for ($i = 0; $i < $password_length; $i ++) {
+    for ($i = 0; $i < $password_length; $i++) {
         $current_character_code = api_ord(api_substr($password, $i, 1));
         if ($i && abs($current_character_code - $previous_character_code) <= 1) {
-            $consequent_characters ++;
+            $consequent_characters++;
             if ($consequent_characters == 3) {
                 return false;
             }
@@ -1869,9 +1869,9 @@ 
             $consequent_characters = 1;
         }
         if ($current_character_code >= 97 && $current_character_code <= 122) {
-            $letters ++;
+            $letters++;
         } elseif ($current_character_code >= 48 && $current_character_code <= 57) {
-            $digits ++;
+            $digits++;
         } else {
             return false;
         }
@@ -2066,7 +2066,7 @@ 
         if (empty($session_id)) { return null; }
     }
     $t = Database::get_main_table(TABLE_MAIN_SESSION);
-    $s = "SELECT name FROM $t WHERE id = ".(int)$session_id;
+    $s = "SELECT name FROM $t WHERE id = ".(int) $session_id;
     $r = Database::query($s);
     $c = Database::num_rows($r);
     if ($c > 0) {
@@ -2091,7 +2091,7 @@ 
         $sql = "SELECT * FROM $tbl_session WHERE id = $session_id";
         $result = Database::query($sql);
 
-        if (Database::num_rows($result)>0) {
+        if (Database::num_rows($result) > 0) {
             $data = Database::fetch_array($result, 'ASSOC');
         }
     }
@@ -2251,9 +2251,9 @@ 
  */
 function api_get_session_image($session_id, $status_id)
 {
-    $session_id = (int)$session_id;
+    $session_id = (int) $session_id;
     $session_img = '';
-    if ((int)$status_id != 5) { //check whether is not a student
+    if ((int) $status_id != 5) { //check whether is not a student
         if ($session_id > 0) {
             $session_img = "&nbsp;&nbsp;".Display::return_icon(
                 'star.png',
@@ -2318,7 +2318,7 @@ 
         $filename = api_get_path(SYS_PATH).api_get_home_path().'header_extra_content.txt';
         if (file_exists($filename)) {
             $value = file_get_contents($filename);
-            return $value ;
+            return $value;
         } else {
             return '';
         }
@@ -2327,7 +2327,7 @@ 
         $filename = api_get_path(SYS_PATH).api_get_home_path().'footer_extra_content.txt';
         if (file_exists($filename)) {
             $value = file_get_contents($filename);
-            return $value ;
+            return $value;
         } else {
             return '';
         }
@@ -2521,7 +2521,7 @@ 
     }
     $group_id   = api_get_group_id();
     $course_id  = api_get_course_int_id();
-    $course_code= api_get_course_id();
+    $course_code = api_get_course_id();
     $session_id = api_get_session_id();
 
     //Group (in course)
@@ -2529,7 +2529,7 @@ 
         $group_status = array();
         $is_subscribed = GroupManager::is_subscribed($user_id, $group_id);
         if ($is_subscribed) {
-            $group_status = array('id'=> $group_id , 'status' => 'student');
+            $group_status = array('id'=> $group_id, 'status' => 'student');
             $is_tutor = GroupManager::is_tutor_of_group($user_id, $group_id);
             if ($is_tutor) {
                 $group_status['status'] = 'tutor';
@@ -2563,7 +2563,7 @@ 
         }
         $status['session'] = $session_status;
 
-    } elseif($course_id) {
+    } elseif ($course_id) {
         //Course
         $course_status = array();
         if ($course_id) {
@@ -2571,7 +2571,7 @@ 
 
             if ($user_course_status) {
                 $course_status = array('id'=> $course_id);
-                switch($user_course_status) {
+                switch ($user_course_status) {
                     case 1;
                         $course_status['status'] = 'teacher';
                     break;
@@ -2601,7 +2601,7 @@ 
 function api_is_course_session_coach($user_id, $courseId, $session_id)
 {
     $session_table = Database::get_main_table(TABLE_MAIN_SESSION);
-    $session_rel_course_rel_user_table  = Database::get_main_table(TABLE_MAIN_SESSION_COURSE_USER);
+    $session_rel_course_rel_user_table = Database::get_main_table(TABLE_MAIN_SESSION_COURSE_USER);
 
     $user_id = intval($user_id);
     $session_id = intval($session_id);
@@ -2675,7 +2675,7 @@ 
                 ORDER BY access_start_date, access_end_date, name";
         $result = Database::query($sql);
         if (!empty($sessionIsCoach)) {
-            $sessionIsCoach = array_merge($sessionIsCoach , Database::store_result($result));
+            $sessionIsCoach = array_merge($sessionIsCoach, Database::store_result($result));
         } else {
             $sessionIsCoach = Database::store_result($result);
         }
@@ -2852,7 +2852,7 @@ 
             return '';
         }
         $sourceurl = substr($_SERVER['REQUEST_URI'], 0, strpos($_SERVER['REQUEST_URI'], '?'));
-        $sourceurl = str_replace('newscorm/lp_header.php', 'newscorm/lp_controller.php?'.api_get_cidreq().'&action=view&lp_id='.intval($_GET['lp_id']).'&isStudentView='.($_SESSION['studentview']=='studentview' ? 'false' : 'true'), $sourceurl);
+        $sourceurl = str_replace('newscorm/lp_header.php', 'newscorm/lp_controller.php?'.api_get_cidreq().'&action=view&lp_id='.intval($_GET['lp_id']).'&isStudentView='.($_SESSION['studentview'] == 'studentview' ? 'false' : 'true'), $sourceurl);
         //showinframes doesn't handle student view anyway...
         //return '';
         $is_framed = true;
@@ -3254,7 +3254,7 @@ 
         }
         $content .= '<div class="well_login">';
         $content .= $form->return_form();
-        $content .='</div>';
+        $content .= '</div>';
         if (api_is_cas_activated()) {
             $content .= "</div>";
         }
@@ -3273,7 +3273,7 @@ 
         exit;
     }
 
-    if ($user_id !=0 && !api_is_anonymous()) {
+    if ($user_id != 0 && !api_is_anonymous()) {
         $tpl->display_one_col_template();
         exit;
     }
@@ -3304,7 +3304,7 @@ 
         }
         $msg .= '<div class="well">';
         $msg .= $form->return_form();
-        $msg .='</div>';
+        $msg .= '</div>';
         if (api_is_cas_activated()) {
             $msg .= "</div>";
         }
@@ -3340,7 +3340,7 @@ 
     list ($last_post_date, $last_post_time) = explode(' ', $last_post_datetime);
     list ($year, $month, $day) = explode('-', $last_post_date);
     list ($hour, $min, $sec) = explode(':', $last_post_time);
-    return mktime((int)$hour, (int)$min, (int)$sec, (int)$month, (int)$day, (int)$year);
+    return mktime((int) $hour, (int) $min, (int) $sec, (int) $month, (int) $day, (int) $year);
 }
 
 /**
@@ -3796,7 +3796,7 @@ 
                 c_id = $course_id AND
                 tool = '$tool'
                 $session_condition ";
-    $rs  = Database::query($sql);
+    $rs = Database::query($sql);
     $list = array();
     if (Database::num_rows($rs) > 0) {
         while ($row = Database::fetch_array($rs, 'ASSOC')) {
@@ -3876,7 +3876,7 @@ 
                 tool = '$tool' AND
                 ref = $ref
                 $sessionCondition";
-    $rs  = Database::query($sql);
+    $rs = Database::query($sql);
     $item_property_id = '';
     if (Database::num_rows($rs) > 0) {
         $row = Database::fetch_array($rs);
@@ -3934,7 +3934,7 @@ 
             WHERE item_property_id = $item_property_id AND course_id = $course_id
             ORDER BY lastedit_date DESC";
     $result = Database::query($sql);
-    $result = Database::store_result($result,'ASSOC');
+    $result = Database::store_result($result, 'ASSOC');
 
     return $result;
 }
@@ -3985,7 +3985,7 @@ 
     $rs  = Database::query($sql);
     $row = array();
     if (Database::num_rows($rs) > 0) {
-        $row = Database::fetch_array($rs,'ASSOC');
+        $row = Database::fetch_array($rs, 'ASSOC');
     }
 
     return $row;
@@ -4021,7 +4021,7 @@ 
     $languages  = $language_list['name'];
     $folder     = $language_list['folder'];
 
-    $ret .= '<select name="' . $name . '" id="language_chosen" class="selectpicker show-tick form-control">';
+    $ret .= '<select name="'.$name.'" id="language_chosen" class="selectpicker show-tick form-control">';
     foreach ($languages as $key => $value) {
         if ($folder[$key] == $default) {
             $selected = ' selected="selected"';
@@ -4074,8 +4074,8 @@ 
     //-->
     </script>';
     $html .= '<form id="lang_form" name="lang_form" method="post" action="'.api_get_self().'">';
-    $html .= '<label style="display: none;" for="language_list">' . get_lang('Language') . '</label>';
-    $html .=  '<select id="language_list" class="selectpicker show-tick form-control" name="language_list" >';
+    $html .= '<label style="display: none;" for="language_list">'.get_lang('Language').'</label>';
+    $html .= '<select id="language_list" class="selectpicker show-tick form-control" name="language_list" >';
 
     foreach ($original_languages as $key => $value) {
         if ($folder[$key] == $user_selected_language) {
@@ -4083,13 +4083,13 @@ 
         } else {
             $option_end = '>';
         }
-        $html .=  '<option value="'.api_get_self().'?language='.$folder[$key].'"'.$option_end;
+        $html .= '<option value="'.api_get_self().'?language='.$folder[$key].'"'.$option_end;
         //echo substr($value, 0, 16); // Cut string to keep 800x600 aspect.
-        $html .=  $value.'</option>';
+        $html .= $value.'</option>';
     }
-    $html .=  '</select>';
-    $html .=  '<noscript><input type="submit" name="user_select_language" value="'.get_lang('Ok').'" /></noscript>';
-    $html .=  '</form>';
+    $html .= '</select>';
+    $html .= '<noscript><input type="submit" name="user_select_language" value="'.get_lang('Ok').'" /></noscript>';
+    $html .= '</form>';
     return $html;
 }
 
@@ -4215,7 +4215,7 @@ 
     $rs = Database::query($sql);
     $language_info = array();
     if (Database::num_rows($rs)) {
-        $language_info = Database::fetch_array($rs,'ASSOC');
+        $language_info = Database::fetch_array($rs, 'ASSOC');
     }
     return $language_info;
 }
@@ -4293,7 +4293,7 @@ 
  * Note: Directory names (names of themes) in the file system should contain ASCII-characters only.
  */
 function api_get_themes() {
-    $cssdir = api_get_path(SYS_CSS_PATH) . 'themes/';
+    $cssdir = api_get_path(SYS_CSS_PATH).'themes/';
     $list_dir = array();
     $list_name = array();
 
@@ -4470,7 +4470,7 @@ 
     if (is_file($dirname) || is_link($dirname)) {
         $res = unlink($dirname);
         if ($res === false) {
-            error_log(__FILE__.' line '.__LINE__.': '.((bool)ini_get('track_errors') ? $php_errormsg : 'Error not recorded because track_errors is off in your php.ini'), 0);
+            error_log(__FILE__.' line '.__LINE__.': '.((bool) ini_get('track_errors') ? $php_errormsg : 'Error not recorded because track_errors is off in your php.ini'), 0);
         }
         return $res;
     }
@@ -4507,7 +4507,7 @@ 
     if ($delete_only_content_in_folder == false) {
         $res = rmdir($dirname);
         if ($res === false) {
-            error_log(__FILE__.' line '.__LINE__.': '.((bool)ini_get('track_errors') ? $php_errormsg : 'error not recorded because track_errors is off in your php.ini'), 0);
+            error_log(__FILE__.' line '.__LINE__.': '.((bool) ini_get('track_errors') ? $php_errormsg : 'error not recorded because track_errors is off in your php.ini'), 0);
         }
     }
     return $res;
@@ -4592,7 +4592,7 @@ 
 
     $course_id = $course_info['real_id'];
 
-    $folders = explode(DIRECTORY_SEPARATOR,str_replace($base_path_document.DIRECTORY_SEPARATOR,'',$pathname));
+    $folders = explode(DIRECTORY_SEPARATOR, str_replace($base_path_document.DIRECTORY_SEPARATOR, '', $pathname));
 
     $new_pathname = $base_path_document;
     $path = '';
@@ -4610,7 +4610,7 @@ 
                         path = '$path' AND
                         filetype = 'folder' AND
                         session_id = '$session_id'";
-            $rs1  = Database::query($sql);
+            $rs1 = Database::query($sql);
             $num_rows = Database::num_rows($rs1);
 
             if ($num_rows == 0) {
@@ -4770,7 +4770,7 @@ 
             foreach (array('key', 'value1', 'value2', 'value3') as $var) {
                 $$var = isset($match[++$i]) ? $match[$i] : '';
             }
-            $value = stripslashes(substr($value1, 1, -1)) . stripslashes(substr($value2, 1, -1)) . $value3;
+            $value = stripslashes(substr($value1, 1, -1)).stripslashes(substr($value2, 1, -1)).$value3;
 
             // Parse array syntax.
             $keys = preg_split('/\]?\[/', rtrim($key, ']'));
@@ -4810,7 +4810,7 @@ 
  */
 function api_get_version() {
     global $_configuration;
-    return (string)$_configuration['system_version'];
+    return (string) $_configuration['system_version'];
 }
 
 /**
@@ -4937,7 +4937,7 @@ 
     $t_settings = Database::get_main_table(TABLE_MAIN_SETTINGS_CURRENT);
     $var = Database::escape_string($var);
     $value = Database::escape_string($value);
-    $access_url = (int)$access_url;
+    $access_url = (int) $access_url;
     if (empty($access_url)) { $access_url = 1; }
     $select = "SELECT id FROM $t_settings WHERE variable = '$var' ";
     if (!empty($subvar)) {
@@ -4958,7 +4958,7 @@ 
         // Found item for this access_url.
         $row = Database::fetch_array($res);
         $sql = "UPDATE $t_settings SET selected_value = '$value'
-                WHERE id = ".$row['id'] ;
+                WHERE id = ".$row['id'];
         Database::query($sql);
     } else {
         // Item not found for this access_url, we have to check if it exist with access_url = 1
@@ -4978,11 +4978,11 @@ 
                 $row = Database::fetch_array($res);
                 $insert = "INSERT INTO $t_settings (variable, subkey, type,category, selected_value, title, comment, scope, subkeytext, access_url)
                         VALUES
-                        ('".$row['variable']."',".(!empty($row['subkey']) ? "'".$row['subkey']."'" : "NULL")."," .
-                        "'".$row['type']."','".$row['category']."'," .
-                        "'$value','".$row['title']."'," .
-                        "".(!empty($row['comment']) ? "'".$row['comment']."'" : "NULL").",".(!empty($row['scope']) ? "'".$row['scope']."'" : "NULL")."," .
-                        "".(!empty($row['subkeytext'])?"'".$row['subkeytext']."'":"NULL").",$access_url)";
+                        ('".$row['variable']."',".(!empty($row['subkey']) ? "'".$row['subkey']."'" : "NULL").",".
+                        "'".$row['type']."','".$row['category']."',".
+                        "'$value','".$row['title']."',".
+                        "".(!empty($row['comment']) ? "'".$row['comment']."'" : "NULL").",".(!empty($row['scope']) ? "'".$row['scope']."'" : "NULL").",".
+                        "".(!empty($row['subkeytext']) ? "'".$row['subkeytext']."'" : "NULL").",$access_url)";
                 Database::query($insert);
             } else { // Such a setting does not exist.
                 error_log(__FILE__.':'.__LINE__.': Attempting to update setting '.$var.' ('.$subvar.') which does not exist at all', 0);
@@ -5002,16 +5002,16 @@ 
                 if ($row['access_url_changeable'] == 1) {
                     $insert = "INSERT INTO $t_settings (variable,subkey, type,category, selected_value,title, comment,scope, subkeytext,access_url, access_url_changeable) VALUES
                             ('".$row['variable']."',".
-                            (!empty($row['subkey']) ? "'".$row['subkey']."'" : "NULL")."," .
-                            "'".$row['type']."','".$row['category']."'," .
-                            "'$value','".$row['title']."'," .
+                            (!empty($row['subkey']) ? "'".$row['subkey']."'" : "NULL").",".
+                            "'".$row['type']."','".$row['category']."',".
+                            "'$value','".$row['title']."',".
                             "".(!empty($row['comment']) ? "'".$row['comment']."'" : "NULL").",".
-                            (!empty($row['scope']) ? "'".$row['scope']."'" : "NULL")."," .
+                            (!empty($row['scope']) ? "'".$row['scope']."'" : "NULL").",".
                             "".(!empty($row['subkeytext']) ? "'".$row['subkeytext']."'" : "NULL").",$access_url,".$row['access_url_changeable'].")";
                     Database::query($insert);
                 }
             } else { // Such a setting does not exist.
-                error_log(__FILE__.':'.__LINE__.': Attempting to update setting '.$var.' ('.$subvar.') which does not exist at all. The access_url is: '.$access_url.' ',0);
+                error_log(__FILE__.':'.__LINE__.': Attempting to update setting '.$var.' ('.$subvar.') which does not exist at all. The access_url is: '.$access_url.' ', 0);
             }
         }
     }
@@ -5039,10 +5039,10 @@ 
         $value = Database::escape_string($value);
         $sql = "UPDATE $t_s SET selected_value = '$value'
                 WHERE category = '$category' AND access_url = $access_url";
-        if (is_array($fieldtype) && count($fieldtype)>0) {
+        if (is_array($fieldtype) && count($fieldtype) > 0) {
             $sql .= " AND ( ";
             $i = 0;
-            foreach ($fieldtype as $type){
+            foreach ($fieldtype as $type) {
                 if ($i > 0) {
                     $sql .= ' OR ';
                 }
@@ -5057,10 +5057,10 @@ 
     } else {
         $sql = "UPDATE $t_s SET selected_value = NULL
                 WHERE category = '$category' AND access_url = $access_url";
-        if (is_array($fieldtype) && count($fieldtype)>0) {
+        if (is_array($fieldtype) && count($fieldtype) > 0) {
             $sql .= " AND ( ";
             $i = 0;
-            foreach ($fieldtype as $type){
+            foreach ($fieldtype as $type) {
                 if ($i > 0) {
                     $sql .= ' OR ';
                 }
@@ -5205,7 +5205,7 @@ 
 function & api_get_settings_categories($exceptions = array(), $access_url = 1) {
     $access_url = (int) $access_url;
     $t_cs = Database::get_main_table(TABLE_MAIN_SETTINGS_CURRENT);
-    $list = "'".implode("','",$exceptions)."'";
+    $list = "'".implode("','", $exceptions)."'";
     $sql = "SELECT DISTINCT category FROM $t_cs WHERE category is NOT NULL ";
     if ($list != "'',''" && $list != "''" && !empty($list)) {
         $sql .= " AND category NOT IN ($list) ";
@@ -5317,12 +5317,12 @@ 
 
     // Item not found for this access_url, we have to check if the whole thing is missing
     // (in which case we ignore the insert) or if there *is* a record but just for access_url = 1
-    $insert = "INSERT INTO $t_settings " .
-                "(variable,selected_value," .
-                "type,category," .
-                "subkey,title," .
-                "comment,scope," .
-                "subkeytext,access_url,access_url_changeable)" .
+    $insert = "INSERT INTO $t_settings ".
+                "(variable,selected_value,".
+                "type,category,".
+                "subkey,title,".
+                "comment,scope,".
+                "subkeytext,access_url,access_url_changeable)".
                 " VALUES ('$var','$val',";
     if (isset($type)) {
         $type = Database::escape_string($type);
@@ -5488,7 +5488,7 @@ 
             $result = Database::query($sql);
 
             //if ($row = Database::fetch_array($result)) {
-            if (Database::num_rows($result) > 0 ) {
+            if (Database::num_rows($result) > 0) {
                 $is_courseMember = true;
                 $is_courseTutor = true;
                 $is_courseCoach = true;
@@ -5708,8 +5708,8 @@ 
 {
     $tbl_rel_course_user = Database :: get_main_table(TABLE_MAIN_COURSE_USER);
     if (!empty($user_id) && !empty($courseId)) {
-        $user_id        = intval($user_id);
-        $courseId    = intval($courseId);
+        $user_id = intval($user_id);
+        $courseId = intval($courseId);
         $sql = 'SELECT status
                 FROM '.$tbl_rel_course_user.'
                 WHERE user_id='.$user_id.' AND c_id = '.$courseId;
@@ -5821,7 +5821,7 @@ 
     } else {
         return false;
     }
-    return strtolower(substr((string)$os, 0, 3 )) == 'win';
+    return strtolower(substr((string) $os, 0, 3)) == 'win';
 }
 
 /**
@@ -6349,7 +6349,7 @@ 
 function api_get_jquery_ui_js($include_jqgrid = false) {
     $libraries = array();
     if ($include_jqgrid) {
-       $libraries[]='jqgrid';
+       $libraries[] = 'jqgrid';
     }
     return api_get_jquery_libraries_js($libraries);
 }
@@ -6373,12 +6373,12 @@ 
 
     //jqgrid js and css
     if (in_array('jqgrid', $libraries)) {
-        $languaje   = 'en';
+        $languaje = 'en';
         $platform_isocode = strtolower(api_get_language_isocode());
 
         //languages supported by jqgrid see files in main/inc/lib/javascript/jqgrid/js/i18n
         $jqgrid_langs = array(
-            'bg', 'bg1251', 'cat','cn','cs','da','de','el','en','es','fa','fi','fr','gl','he','hu','is','it','ja','nl','no','pl','pt-br','pt','ro','ru','sk','sr','sv','tr','ua'
+            'bg', 'bg1251', 'cat', 'cn', 'cs', 'da', 'de', 'el', 'en', 'es', 'fa', 'fi', 'fr', 'gl', 'he', 'hu', 'is', 'it', 'ja', 'nl', 'no', 'pl', 'pt-br', 'pt', 'ro', 'ru', 'sk', 'sr', 'sv', 'tr', 'ua'
         );
 
         if (in_array($platform_isocode, $jqgrid_langs)) {
@@ -6409,7 +6409,7 @@ 
 
     // jquery datepicker
     if (in_array('datepicker', $libraries)) {
-        $languaje   = 'en-GB';
+        $languaje = 'en-GB';
         $platform_isocode = strtolower(api_get_language_isocode());
 
         // languages supported by jqgrid see files in main/inc/lib/javascript/jqgrid/js/i18n
@@ -6575,7 +6575,7 @@ 
  * @return void
  */
 function api_check_php_version($my_inc_path = null) {
-    if (!function_exists('version_compare') || version_compare( phpversion(), REQUIRED_PHP_VERSION, '<')) {
+    if (!function_exists('version_compare') || version_compare(phpversion(), REQUIRED_PHP_VERSION, '<')) {
         $global_error_code = 1;
         // Incorrect PHP version
         $global_page = $my_inc_path.'global_error_message.inc.php';
@@ -6591,7 +6591,7 @@ 
  */
 function api_check_archive_dir() {
     if (is_dir(api_get_path(SYS_ARCHIVE_PATH)) && !is_writable(api_get_path(SYS_ARCHIVE_PATH))) {
-        $message = Display::return_message(get_lang('ArchivesDirectoryNotWriteableContactAdmin'),'warning');
+        $message = Display::return_message(get_lang('ArchivesDirectoryNotWriteableContactAdmin'), 'warning');
         api_not_allowed(true, $message);
     }
 }
@@ -6656,7 +6656,7 @@ 
  * @author Jorge Frisancho Jibaja <jrfdeft@gmail.com>, USIL - Some changes to allow the use of real IP using reverse proxy
  * @version CEV CHANGE 24APR2012
  */
-function api_get_real_ip(){
+function api_get_real_ip() {
     // Guess the IP if behind a reverse proxy
     global $debug;
     $ip = trim($_SERVER['REMOTE_ADDR']);
@@ -6682,23 +6682,23 @@ 
  * @author Yannick Warnier for improvements and managment of multiple ranges
  * @todo check for IPv6 support
  */
-function api_check_ip_in_range($ip,$range)
+function api_check_ip_in_range($ip, $range)
 {
     if (empty($ip) or empty($range)) {
         return false;
     }
-    $ip_ip = ip2long ($ip);
+    $ip_ip = ip2long($ip);
     // divide range param into array of elements
-    if (strpos($range,',')!==false) {
-        $ranges = explode(',',$range);
+    if (strpos($range, ',') !== false) {
+        $ranges = explode(',', $range);
     } else {
         $ranges = array($range);
     }
     foreach ($ranges as $range) {
         $range = trim($range);
         if (empty($range)) { continue; }
-        if (strpos($range,'/')===false) {
-            if (strcmp($ip,$range)===0) {
+        if (strpos($range, '/') === false) {
+            if (strcmp($ip, $range) === 0) {
                 return true; // there is a direct IP match, return OK
             }
             continue; //otherwise, get to the next range
@@ -6706,7 +6706,7 @@ 
         // the range contains a "/", so analyse completely
         list ($net, $mask) = explode("/", $range);
 
-        $ip_net = ip2long ($net);
+        $ip_net = ip2long($net);
         // mask binary magic
         $ip_mask = ~((1 << (32 - $mask)) - 1);
 
@@ -7068,14 +7068,14 @@ 
  * @assert (0) === true
  * @assert ('1G') === true
  */
-function api_set_memory_limit($mem){
+function api_set_memory_limit($mem) {
     //if ini_set() not available, this function is useless
     if (!function_exists('ini_set') || is_null($mem) || $mem == -1) {
         return false;
     }
 
     $memory_limit = ini_get('memory_limit');
-    if (api_get_bytes_memory_limit($mem) > api_get_bytes_memory_limit($memory_limit)){
+    if (api_get_bytes_memory_limit($mem) > api_get_bytes_memory_limit($memory_limit)) {
         ini_set('memory_limit', $mem);
         return true;
     }
@@ -7092,21 +7092,21 @@ 
  * @assert ('1m')  === 1048576
  * @assert ('100k') === 102400
  */
-function api_get_bytes_memory_limit($mem){
-    $size = strtolower(substr($mem,-1));
+function api_get_bytes_memory_limit($mem) {
+    $size = strtolower(substr($mem, -1));
 
     switch ($size) {
         case 't':
-            $mem = intval(substr($mem,-1))*1024*1024*1024*1024;
+            $mem = intval(substr($mem, -1)) * 1024 * 1024 * 1024 * 1024;
             break;
         case 'g':
-            $mem = intval(substr($mem,0,-1))*1024*1024*1024;
+            $mem = intval(substr($mem, 0, -1)) * 1024 * 1024 * 1024;
             break;
         case 'm':
-            $mem = intval(substr($mem,0,-1))*1024*1024;
+            $mem = intval(substr($mem, 0, -1)) * 1024 * 1024;
             break;
         case 'k':
-            $mem = intval(substr($mem,0,-1))*1024;
+            $mem = intval(substr($mem, 0, -1)) * 1024;
             break;
         default:
             // we assume it's integer only
@@ -7159,7 +7159,7 @@ 
         get_lang('PasswordVeryStrong'),
     );
     $js = api_get_js('strength/strength.js');
-    $js .=  "<script>
+    $js .= "<script>
 
     var verdicts = ['".implode("','", $verdicts)."'];
     var errorMessages = {
@@ -7215,7 +7215,7 @@ 
         return false;
     }
     $minutesToBlock = api_get_setting('captcha_time_to_block');
-    $time = time() + $minutesToBlock*60;
+    $time = time() + $minutesToBlock * 60;
     UserManager::update_extra_field_value(
         $userInfo['user_id'],
         'captcha_blocked_until_date',
@@ -7289,7 +7289,7 @@ 
         $out_res = str_replace('"', "''", $out_res);
     }
     // avoid text stuck together when tags are removed, adding a space after >
-    $out_res = str_replace (">", "> ", $out_res);
+    $out_res = str_replace(">", "> ", $out_res);
     $out_res = strip_tags($out_res);
 
     return $out_res;
@@ -7399,12 +7399,12 @@ 
 {
     // Clean query
     $bt = debug_backtrace();
-    $caller = array_shift($bt);;
+    $caller = array_shift($bt); ;
     if ($dump == 1) {
         $string = print_r($string, 1);
     } else {
         $string = str_replace(array("\r", "\n", "\t", "\10"), '', $string);
-        $string = str_replace('    ',' ', $string);
+        $string = str_replace('    ', ' ', $string);
     }
 
     error_log("-------------------------------------");
@@ -7514,7 +7514,7 @@ 
         $body = get_lang('PortalName').': '.api_get_path(WEB_PATH)." \n ";
         $body .= get_lang('PortalLimitType').': '.$limitName." \n ";
         if (isset($hostingParams[$limitName])) {
-            $body .= get_lang('Value') . ': ' . $hostingParams[$limitName];
+            $body .= get_lang('Value').': '.$hostingParams[$limitName];
         }
         api_mail_html(null, $email, $subject, $body);
     }
@@ -7642,7 +7642,7 @@ 
  */
 function api_set_site_use_cookie_warning_cookie()
 {
-    setcookie("ChamiloUsesCookies", "ok", time()+31556926);
+    setcookie("ChamiloUsesCookies", "ok", time() + 31556926);
 }
 
 /**
@@ -7690,10 +7690,10 @@ 
         return false;
     }
 
-    $fullPath = $parentDirectory . api_replace_dangerous_char($name);
+    $fullPath = $parentDirectory.api_replace_dangerous_char($name);
 
     if (mkdir($fullPath, api_get_permissions_for_new_directories(), true)) {
-        $fp = fopen($fullPath . '/index.html', 'w');
+        $fp = fopen($fullPath.'/index.html', 'w');
 
         if ($fp) {
             if (fwrite($fp, '<html><head></head><body></body></html>')) {
@@ -7758,7 +7758,7 @@ 
             $mail->SMTPSecure = $platform_email['SMTP_SECURE'];
         }
     }
-    $mail->SMTPDebug = isset($platform_email['SMTP_DEBUG'])?$platform_email['SMTP_DEBUG']:0;
+    $mail->SMTPDebug = isset($platform_email['SMTP_DEBUG']) ? $platform_email['SMTP_DEBUG'] : 0;
 
     // 5 = low, 1 = high
     $mail->Priority = 3;
@@ -7910,11 +7910,11 @@ 
         error_log('ERROR: mail not sent to '.$recipient_name.' ('.$recipient_email.') because of '.$mail->ErrorInfo.'<br />');
         if ($mail->SMTPDebug) {
             error_log(
-                "Connection details :: " .
-                "Protocol: " . $mail->Mailer . ' :: ' .
-                "Host/Port: " . $mail->Host . ':' . $mail->Port . ' :: ' .
-                "Authent/Open: " . ($mail->SMTPAuth?'Authent':'Open') . ' :: ' .
-                ($mail->SMTPAuth?"  User/Pass: " . $mail->Username . ':' . $mail->Password:'')
+                "Connection details :: ".
+                "Protocol: ".$mail->Mailer.' :: '.
+                "Host/Port: ".$mail->Host.':'.$mail->Port.' :: '.
+                "Authent/Open: ".($mail->SMTPAuth ? 'Authent' : 'Open').' :: '.
+                ($mail->SMTPAuth ? "  User/Pass: ".$mail->Username.':'.$mail->Password : '')
             );
         }
         return 0;
@@ -7964,7 +7964,7 @@ 
  * @param datetime $currentDate
  * @return bool true if date is in rage, false otherwise
  */
-function apiIsDateInDateRange ($startDate, $endDate, $currentDate = null)
+function apiIsDateInDateRange($startDate, $endDate, $currentDate = null)
 {
     $startDate = strtotime(api_get_local_time($startDate));
     $endDate = strtotime(api_get_local_time($endDate));
@@ -7985,13 +7985,13 @@ 
  * @return array
  *
  */
-function api_unique_multidim_array($array, $key){
+function api_unique_multidim_array($array, $key) {
     $temp_array = [];
     $i = 0;
     $key_array = [];
 
-    foreach($array as $val){
-        if(!in_array($val[$key],$key_array)){
+    foreach ($array as $val) {
+        if (!in_array($val[$key], $key_array)) {
             $key_array[$i] = $val[$key];
             $temp_array[$i] = $val;
         }

main/forum/index.php

Spacing +37 added lines, -37 removed lines

@@ -64,7 +64,7 @@ 
 
 if (!empty($gradebook) && $gradebook == 'view') {
     $interbreadcrumb[] = array(
-        'url' => '../gradebook/' . $_SESSION['gradebook_dest'],
+        'url' => '../gradebook/'.$_SESSION['gradebook_dest'],
         'name' => get_lang('ToolGradebook'),
     );
 }
@@ -79,7 +79,7 @@ 
     switch ($_GET['content']) {
         case 'forum':
             $interbreadcrumb[] = array(
-                'url' => 'index.php?search=' . $search_forum . '&' . api_get_cidreq(),
+                'url' => 'index.php?search='.$search_forum.'&'.api_get_cidreq(),
                 'name' => get_lang('Forum'),
             );
             $interbreadcrumb[] = array(
@@ -89,7 +89,7 @@ 
             break;
         case 'forumcategory':
             $interbreadcrumb[] = array(
-                'url' => 'index.php?search=' . $search_forum . '&' . api_get_cidreq(),
+                'url' => 'index.php?search='.$search_forum.'&'.api_get_cidreq(),
                 'name' => get_lang('Forum'),
             );
             $interbreadcrumb[] = array(
@@ -185,7 +185,7 @@ 
         . "&gradebook=&action=add_item&type=step&lp_id=$lp_id#resource_tab-5\">"
         . Display::return_icon(
             'back.png',
-            get_lang("BackTo") . ' ' . get_lang("LearningPaths"),
+            get_lang("BackTo").' '.get_lang("LearningPaths"),
             '',
             ICON_SIZE_MEDIUM
         )
@@ -197,8 +197,8 @@ 
 
 if (api_is_allowed_to_edit(false, true)) {
     echo '<a href="'
-        . api_get_self() . '?' . api_get_cidreq()
-        . '&action=add&content=forumcategory&lp_id=' . $lp_id . '"> ' .
+        . api_get_self().'?'.api_get_cidreq()
+        . '&action=add&content=forumcategory&lp_id='.$lp_id.'"> '.
         Display::return_icon(
             'new_folder.png', get_lang('AddForumCategory'), '', ICON_SIZE_MEDIUM
         )
@@ -248,7 +248,7 @@ 
         );
 
         if (empty($sessionId) && !empty($forumCategory['session_name'])) {
-            $session_displayed = ' (' . Security::remove_XSS($forumCategory['session_name']) . ')';
+            $session_displayed = ' ('.Security::remove_XSS($forumCategory['session_name']).')';
         } else {
             $session_displayed = '';
         }
@@ -260,7 +260,7 @@ 
         $html = '';
         $iconsEdit = '';
         $idCategory = $forumCategory['cat_id'];
-        $urlCategory = 'viewforumcategory.php?' . api_get_cidreq() . '&forumcategory=' . intval($idCategory);
+        $urlCategory = 'viewforumcategory.php?'.api_get_cidreq().'&forumcategory='.intval($idCategory);
         $titleCategory = Display::tag(
             'a',
             $forumCategory['cat_title'],
@@ -278,9 +278,9 @@ 
                 !($forumCategory['session_id'] == 0 &&
                 intval($sessionId) != 0)
             ) {
-                $iconsEdit .= '<a href="' . api_get_self() . '?' . api_get_cidreq()
-                    . '&action=edit&content=forumcategory&id=' . intval($idCategory)
-                    . '">' . Display::return_icon(
+                $iconsEdit .= '<a href="'.api_get_self().'?'.api_get_cidreq()
+                    . '&action=edit&content=forumcategory&id='.intval($idCategory)
+                    . '">'.Display::return_icon(
                         'edit.png',
                         get_lang('Edit'),
                         array(),
@@ -288,8 +288,8 @@ 
                     )
                     . '</a>';
 
-                $iconsEdit .='<a href="' . api_get_self() . '?' . api_get_cidreq()
-                    . '&action=delete&content=forumcategory&id=' . intval($idCategory)
+                $iconsEdit .= '<a href="'.api_get_self().'?'.api_get_cidreq()
+                    . '&action=delete&content=forumcategory&id='.intval($idCategory)
                     . "\" onclick=\"javascript:if(!confirm('"
                     . addslashes(api_htmlentities(
                         get_lang('DeleteForumCategory'),
@@ -303,7 +303,7 @@ 
                         ICON_SIZE_SMALL
                     )
                     . '</a>';
-                $iconsEdit .=  return_visible_invisible_icon(
+                $iconsEdit .= return_visible_invisible_icon(
                     'forumcategory',
                     strval(intval($idCategory)),
                     strval(intval($forumCategory['visibility']))
@@ -337,7 +337,7 @@ 
             array(),
             ICON_SIZE_MEDIUM
         );
-        $html .= '<h3>' . $icoCategory . $titleCategory . '</h3>';
+        $html .= '<h3>'.$icoCategory.$titleCategory.'</h3>';
 
         if ($descriptionCategory != '' && trim($descriptionCategory) != '&nbsp;') {
             $html .= '<div class="forum-description">'.$descriptionCategory.'</div>';
@@ -408,7 +408,7 @@ 
                         // Showing the image
                         if (!empty($forum['forum_image'])) {
 
-                            $image_path = api_get_path(WEB_COURSE_PATH). api_get_course_path(). '/upload/forum/images/'. $forum['forum_image'];
+                            $image_path = api_get_path(WEB_COURSE_PATH).api_get_course_path().'/upload/forum/images/'.$forum['forum_image'];
                             $image_size = api_getimagesize($image_path);
                             $img_attributes = '';
                             if (!empty($image_size)) {
@@ -455,15 +455,15 @@ 
                                 30
                             );
                             $forum_title_group_addition = ' (<a href="../group/group_space.php?'
-                                . api_get_cidreq() . '&gidReq=' . $forum['forum_of_group']
-                                . '" class="forum_group_link">' . get_lang('GoTo') . ' ' . $group_title . '</a>)'
+                                . api_get_cidreq().'&gidReq='.$forum['forum_of_group']
+                                . '" class="forum_group_link">'.get_lang('GoTo').' '.$group_title.'</a>)'
                                 . $session_img;
                         } else {
                             $forum_title_group_addition = '';
                         }
 
                         if (empty($sessionId) && !empty($forum['session_name'])) {
-                            $session_displayed = ' (' . $forum['session_name'] . ')';
+                            $session_displayed = ' ('.$forum['session_name'].')';
                         } else {
                             $session_displayed = '';
                         }
@@ -475,7 +475,7 @@ 
                         $html .= '<div class="row">';
                         $html .= '<div class="col-md-6">';
                         $html .= '<div class="col-md-3">';
-                        $html .= '<div class="number-post">'.$forum_image.'<p>'.$number_threads.' ' . get_lang('ForumThreads') . '</p>'
+                        $html .= '<div class="number-post">'.$forum_image.'<p>'.$number_threads.' '.get_lang('ForumThreads').'</p>'
                             . '</div>';
                         $html .= '</div>';
 
@@ -491,9 +491,9 @@ 
                             'a',
                             $forum['forum_title'],
                             [
-                                'href' => 'viewforum.php?' . api_get_cidreq()
-                                    . '&gidReq=' . intval($groupid)
-                                    . '&forum=' . intval($forum['forum_id']),
+                                'href' => 'viewforum.php?'.api_get_cidreq()
+                                    . '&gidReq='.intval($groupid)
+                                    . '&forum='.intval($forum['forum_id']),
                                 'class' => return_visible_invisible(strval(intval($forum['visibility'])))
                             ]
                         );
@@ -505,7 +505,7 @@ 
                             }
                         }
 
-                        $html .= '<h3 class="title">' . $iconForum . $linkForum . '</h3>';
+                        $html .= '<h3 class="title">'.$iconForum.$linkForum.'</h3>';
                         $html .= Display::tag(
                             'p',
                             Security::remove_XSS($forum['forum_comment']),
@@ -520,9 +520,9 @@ 
 
                         // The number of topics and posts.
                         if ($forum['forum_of_group'] !== '0') {
-                            $newPost='';
+                            $newPost = '';
                             if (is_array($mywhatsnew_post_info) && !empty($mywhatsnew_post_info)) {
-                                $newPost = ' ' . Display::return_icon(
+                                $newPost = ' '.Display::return_icon(
                                     'alert.png',
                                     get_lang('Forum'),
                                     null,
@@ -533,7 +533,7 @@ 
                             }
                         } else {
                             if (is_array($mywhatsnew_post_info) && !empty($mywhatsnew_post_info)) {
-                                $newPost = ' ' . Display::return_icon(
+                                $newPost = ' '.Display::return_icon(
                                     'alert.png',
                                     get_lang('Forum'),
                                     null,
@@ -575,9 +575,9 @@ 
                                     null,
                                     ICON_SIZE_TINY
                                 )
-                                . ' ' .
+                                . ' '.
                                 api_convert_and_format_date($forum['last_post_date'])
-                                . '<br /> ' . get_lang('By') . ' ' .
+                                . '<br /> '.get_lang('By').' '.
                                 display_user_link(
                                     $poster_id,
                                     $name,
@@ -591,13 +591,13 @@ 
                         if (api_is_allowed_to_edit(false, true) &&
                             !($forum['session_id'] == 0 && intval($sessionId) != 0)
                         ) {
-                            $html .= '<a href="'.api_get_self() . '?' . api_get_cidreq()
-                                . '&action=edit&content=forum&id=' . $forum['forum_id'] . '">'
+                            $html .= '<a href="'.api_get_self().'?'.api_get_cidreq()
+                                . '&action=edit&content=forum&id='.$forum['forum_id'].'">'
                                 . Display::return_icon('edit.png', get_lang('Edit'), array(), ICON_SIZE_SMALL)
                                 . '</a>';
-                            $html .= '<a href="' . api_get_self() . '?' . api_get_cidreq()
-                                . '&action=delete&content=forum&id=' . $forum['forum_id']
-                                . "\" onclick=\"javascript:if(!confirm('" . addslashes(
+                            $html .= '<a href="'.api_get_self().'?'.api_get_cidreq()
+                                . '&action=delete&content=forum&id='.$forum['forum_id']
+                                . "\" onclick=\"javascript:if(!confirm('".addslashes(
                                     api_htmlentities(get_lang('DeleteForum'), ENT_QUOTES)
                                 )
                                 . "')) return false;\">"
@@ -638,8 +638,8 @@ 
                             !api_is_anonymous() &&
                             api_is_allowed_to_session_edit(false, true)
                         ) {
-                            $html .= '<a href="' . api_get_self() . '?' . api_get_cidreq()
-                                . '&action=notify&content=forum&id=' . $forum['forum_id'] . '">'
+                            $html .= '<a href="'.api_get_self().'?'.api_get_cidreq()
+                                . '&action=notify&content=forum&id='.$forum['forum_id'].'">'
                                 . Display::return_icon($iconnotify, get_lang('NotifyMe'), null, ICON_SIZE_SMALL)
                                 . '</a>';
                         }
@@ -656,7 +656,7 @@ 
                 }
             }
         } else {
-            echo '<div class="alert alert-warning">' . get_lang('NoForumInThisCategory') . '</div>'
+            echo '<div class="alert alert-warning">'.get_lang('NoForumInThisCategory').'</div>'
                 . (api_is_allowed_to_edit(false, true) ? '<div>' : '</div>')
                 . '</div>';
         }