BlockTypeAbstract::__construct() - Code Metrics - chadanuk/mini-cms - Measure and Improve Code Quality continuously with Scrutinizer

BlockTypeAbstract::__construct() A
last analyzed 2019-08-16 09:57 UTC

↳ Parent: BlockTypeAbstract

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	3

<?php

namespace Chadanuk\MiniCms\Blocks;

use Chadanuk\MiniCms\Blocks\Block;
use Illuminate\Support\Facades\View;
use Chadanuk\MiniCms\Blocks\BlockContent;

abstract class BlockTypeAbstract
{
    protected static $blockType = 'markdown';

    public $block;
    public $blockContent;
    public $pageId;

    public function __construct(Block $block, BlockContent $blockContent, int $pageId = null)
    {
        $this->block = $block;
        $this->blockContent = $blockContent;
        $this->pageId = $pageId;

        return $this;

    }

    abstract public function render();

    public function renderInput()
    {
        if (View::exists('mini-cms.admin.blocks.' . static::$blockType)) {
            return View::make(View::exists('mini-cms.admin.blocks.' . static::$blockType, ['block' => $this]));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return View::make('mini-cms::admin.blocks.' . static::$blockType, ['block' => $this]);
    }
}


1			<?php
2
3			namespace Chadanuk\MiniCms\Blocks;
4
5			use Chadanuk\MiniCms\Blocks\Block;
6			use Illuminate\Support\Facades\View;
7			use Chadanuk\MiniCms\Blocks\BlockContent;
8
9			abstract class BlockTypeAbstract
10			{
11			protected static $blockType = 'markdown';
12
13			public $block;
14			public $blockContent;
15			public $pageId;
16
17			public function __construct(Block $block, BlockContent $blockContent, int $pageId = null)
18			{
19			$this->block = $block;
20			$this->blockContent = $blockContent;
21			$this->pageId = $pageId;
22
23			return $this;
			0 ignored issues – show Bug introduced 2019-08-07 20:18 UTC by Report Bug Copy Issue Report Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct? Loading history...
24			}
25
26			abstract public function render();
27
28			public function renderInput()
29			{
30			if (View::exists('mini-cms.admin.blocks.' . static::$blockType)) {
31			return View::make(View::exists('mini-cms.admin.blocks.' . static::$blockType, ['block' => $this]));
			0 ignored issues – show Unused Code introduced 2019-08-07 20:18 UTC by Report Bug Copy Issue Report The call to `View::exists()` has too many arguments starting with `array('block' => $this)`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history... Documentation introduced 2019-08-07 20:18 UTC by Report Bug Copy Issue Report `\Illuminate\Support\Faca...rray('block' => $this))` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32			}
33
34			return View::make('mini-cms::admin.blocks.' . static::$blockType, ['block' => $this]);
35			}
36			}
37

chadanuk / mini-cms

GitHub Access Token became invalid

BlockTypeAbstract::__construct() A last analyzed 2019-08-16 09:57 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

BlockTypeAbstract::__construct() A
last analyzed 2019-08-16 09:57 UTC