Chadanuk\MiniCms\Blocks\BlockTypeAbstract

Complexity

Total Complexity

3

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
	render()	0	1	?
A	renderInput()	0	8	2

<?php

namespace Chadanuk\MiniCms\Blocks;

use Chadanuk\MiniCms\Blocks\Block;
use Illuminate\Support\Facades\View;
use Chadanuk\MiniCms\Blocks\BlockContent;

abstract class BlockTypeAbstract
{
    protected static $blockType = 'markdown';

    public $block;
    public $blockContent;
    public $pageId;

    public function __construct(Block $block, BlockContent $blockContent, int $pageId = null)
    {
        $this->block = $block;
        $this->blockContent = $blockContent;
        $this->pageId = $pageId;

        return $this;

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

    }

    abstract public function render();

    public function renderInput()
    {
        if (View::exists('mini-cms.admin.blocks.' . static::$blockType)) {
            return View::make(View::exists('mini-cms.admin.blocks.' . static::$blockType, ['block' => $this]));

The call to View::exists() has too many arguments starting with array('block' => $this).

\Illuminate\Support\Facades\View::exists('mini-cms.admin.blocks.' . static::$blockType, array('block' => $this)) is of type boolean, but the function expects a string.

        }

        return View::make('mini-cms::admin.blocks.' . static::$blockType, ['block' => $this]);
    }
}