ValidatesInput::getFormattedErrors() - Code Metrics - Inspection of "Merge branch 'feature/skip-optional-input' into de..." - cerbero90/command-validator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 2755c8...49b860 )

by Andrea Marco

created 2016-09-29 03:40 UTC

ValidatesInput::getFormattedErrors() A

↳ Parent: ValidatesInput

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	0

<?php

namespace Cerbero\CommandValidator;

use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Validate input submitted to console commands.
 *
 * @author    Andrea Marco Sartori
 */
trait ValidatesInput
{
    /**
     * @author    Andrea Marco Sartori
     * @var        Illuminate\Validation\Validator    $validator    Input validator.
     */
    protected $validator;

    /**
     * Execute the console command.
     *
     * @param  \Symfony\Component\Console\Input\InputInterface  $input
     * @param  \Symfony\Component\Console\Output\OutputInterface  $output
     * @return mixed
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        if ($this->validator()->passes()) {
            return parent::execute($input, $output);
        }

        return $this->error($this->getFormattedErrors());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Retrieve the input validator.
     *
     * @author    Andrea Marco Sartori
     * @return    Illuminate\Validation\Validator
     */
    protected function validator()
    {
        return $this->validator = $this->validator ?: $this->laravel['validator']->make(
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->filteredInput(), $this->rules(), $this->messages(), $this->attributes()
        );
    }

    /**
     * Filter the input to avoid the validation of optional values.
     *
     * @author    Andrea Marco Sartori
     * @return    array
     */
    private function filteredInput()
    {
        $input = array_merge($this->argument(), $this->option());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return array_filter($input, function ($value) {
            return $value !== null;
        });
    }

    /**
     * Retrieve and format the validation errors.
     *
     * @author    Andrea Marco Sartori
     * @return    string
     */
    protected function getFormattedErrors()
    {
        $errors = implode("\n", $this->validator()->errors()->all());

        return "\n\n{$errors}\n";
    }

    /**
     * Retrieve the validation rules.
     *
     * @author    Andrea Marco Sartori
     * @return    array
     */
    abstract protected function rules();

    /**
     * Retrieve the custom error messages.
     *
     * @author    Andrea Marco Sartori
     * @return    array
     */
    protected function messages()
    {
        return [];
    }

    /**
     * Retrieve the custom attributes for error messages.
     *
     * @author    Andrea Marco Sartori
     * @return    array
     */
    protected function attributes()
    {
        return [];
    }
}


1			<?php
2
3			namespace Cerbero\CommandValidator;
4
5			use Symfony\Component\Console\Input\InputInterface;
6			use Symfony\Component\Console\Output\OutputInterface;
7
8			/**
9			* Validate input submitted to console commands.
10			*
11			* @author Andrea Marco Sartori
12			*/
13			trait ValidatesInput
14			{
15			/**
16			* @author Andrea Marco Sartori
17			* @var Illuminate\Validation\Validator $validator Input validator.
18			*/
19			protected $validator;
20
21			/**
22			* Execute the console command.
23			*
24			* @param \Symfony\Component\Console\Input\InputInterface $input
25			* @param \Symfony\Component\Console\Output\OutputInterface $output
26			* @return mixed
27			*/
28			protected function execute(InputInterface $input, OutputInterface $output)
29			{
30			if ($this->validator()->passes()) {
31			return parent::execute($input, $output);
32			}
33
34			return $this->error($this->getFormattedErrors());
			0 ignored issues – show Bug introduced 2016-04-11 14:20 UTC by Report Bug Copy Issue Report It seems like `error()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
35			}
36
37			/**
38			* Retrieve the input validator.
39			*
40			* @author Andrea Marco Sartori
41			* @return Illuminate\Validation\Validator
42			*/
43			protected function validator()
44			{
45			return $this->validator = $this->validator ?: $this->laravel['validator']->make(
			0 ignored issues – show Bug introduced 2016-04-11 14:20 UTC by Report Bug Copy Issue Report The property `laravel` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
46			$this->filteredInput(), $this->rules(), $this->messages(), $this->attributes()
47			);
48			}
49
50			/**
51			* Filter the input to avoid the validation of optional values.
52			*
53			* @author Andrea Marco Sartori
54			* @return array
55			*/
56			private function filteredInput()
57			{
58			$input = array_merge($this->argument(), $this->option());
			0 ignored issues – show Bug introduced 2016-09-29 03:41 UTC by Report Bug Copy Issue Report It seems like `argument()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2016-09-29 03:41 UTC by Report Bug Copy Issue Report It seems like `option()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
59
60			return array_filter($input, function ($value) {
61			return $value !== null;
62			});
63			}
64
65			/**
66			* Retrieve and format the validation errors.
67			*
68			* @author Andrea Marco Sartori
69			* @return string
70			*/
71			protected function getFormattedErrors()
72			{
73			$errors = implode("\n", $this->validator()->errors()->all());
74
75			return "\n\n{$errors}\n";
76			}
77
78			/**
79			* Retrieve the validation rules.
80			*
81			* @author Andrea Marco Sartori
82			* @return array
83			*/
84			abstract protected function rules();
85
86			/**
87			* Retrieve the custom error messages.
88			*
89			* @author Andrea Marco Sartori
90			* @return array
91			*/
92			protected function messages()
93			{
94			return [];
95			}
96
97			/**
98			* Retrieve the custom attributes for error messages.
99			*
100			* @author Andrea Marco Sartori
101			* @return array
102			*/
103			protected function attributes()
104			{
105			return [];
106			}
107			}
108

cerbero90 / command-validator

Push — develop ( 2755c8...49b860 )

ValidatesInput::getFormattedErrors() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like