Cerbero\CommandValidator\ValidatesInput

Complexity

Total Complexity

8

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	execute()	0	8	2
A	validator()	0	6	2
A	filteredInput()	0	8	1
A	getFormattedErrors()	0	6	1
	rules()	0	1	?
A	messages()	0	4	1
A	attributes()	0	4	1

<?php

namespace Cerbero\CommandValidator;

use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Validate input submitted to console commands.
 *
 * @author    Andrea Marco Sartori
 */
trait ValidatesInput
{
    /**
     * @author    Andrea Marco Sartori
     * @var        Illuminate\Validation\Validator    $validator    Input validator.
     */
    protected $validator;

    /**
     * Execute the console command.
     *
     * @param  \Symfony\Component\Console\Input\InputInterface  $input
     * @param  \Symfony\Component\Console\Output\OutputInterface  $output
     * @return mixed
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        if ($this->validator()->passes()) {
            return parent::execute($input, $output);
        }

        return $this->error($this->getFormattedErrors());

It seems like error() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Retrieve the input validator.
     *
     * @author    Andrea Marco Sartori
     * @return    Illuminate\Validation\Validator
     */
    protected function validator()
    {
        return $this->validator = $this->validator ?: $this->laravel['validator']->make(

The property laravel does not exist. Did you maybe forget to declare it?

            $this->filteredInput(), $this->rules(), $this->messages(), $this->attributes()
        );
    }

    /**
     * Filter the input to avoid the validation of optional values.
     *
     * @author    Andrea Marco Sartori
     * @return    array
     */
    private function filteredInput()
    {
        $input = array_merge($this->argument(), $this->option());

It seems like argument() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like option() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return array_filter($input, function ($value) {
            return $value !== null;
        });
    }

    /**
     * Retrieve and format the validation errors.
     *
     * @author    Andrea Marco Sartori
     * @return    string
     */
    protected function getFormattedErrors()
    {
        $errors = implode("\n", $this->validator()->errors()->all());

        return "\n\n{$errors}\n";
    }

    /**
     * Retrieve the validation rules.
     *
     * @author    Andrea Marco Sartori
     * @return    array
     */
    abstract protected function rules();

    /**
     * Retrieve the custom error messages.
     *
     * @author    Andrea Marco Sartori
     * @return    array
     */
    protected function messages()
    {
        return [];
    }

    /**
     * Retrieve the custom attributes for error messages.
     *
     * @author    Andrea Marco Sartori
     * @return    array
     */
    protected function attributes()
    {
        return [];
    }
}