caxy / php-htmldiff

lib/Caxy/HtmlDiff/Table/TableDiff.php

Doc Comments +4 added lines, -4 removed lines

@@ -229,8 +229,8 @@ 
 
     /**
      * @param Operation $operation
-     * @param array     $oldRows
-     * @param array     $newRows
+     * @param TableRow[]     $oldRows
+     * @param TableRow[]     $newRows
      * @param array     $appliedRowSpans
      */
     protected function processEqualOperation(Operation $operation, $oldRows, $newRows, &$appliedRowSpans)
@@ -249,8 +249,8 @@ 
 
     /**
      * @param Operation $operation
-     * @param array     $oldRows
-     * @param array     $newRows
+     * @param TableRow[]     $oldRows
+     * @param TableRow[]     $newRows
      * @param array     $appliedRowSpans
      */
     protected function processReplaceOperation(Operation $operation, $oldRows, $newRows, &$appliedRowSpans)

lib/Caxy/HtmlDiff/HtmlDiffConfig.php

Doc Comments +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
     /**
      * @param int $matchThreshold
      *
-     * @return AbstractDiff
+     * @return HtmlDiffConfig
      */
     public function setMatchThreshold($matchThreshold)
     {

lib/Caxy/HtmlDiff/HtmlDiff.php

Doc Comments +8 added lines, -2 removed lines

@@ -387,6 +387,12 @@ 
         return $diff->build();
     }
 
+    /**
+     * @param string $oldText
+     * @param string $newText
+     * @param string $attribute
+     * @param string $element
+     */
     protected function diffElementsByAttribute($oldText, $newText, $attribute, $element)
     {
         $oldAttribute = $this->getAttributeFromTag($oldText, $attribute);
@@ -662,7 +668,7 @@ 
     /**
      * @param string $item
      *
-     * @return bool
+     * @return integer
      */
     protected function isOpeningTag($item)
     {
@@ -672,7 +678,7 @@ 
     /**
      * @param string $item
      *
-     * @return bool
+     * @return integer
      */
     protected function isClosingTag($item)
     {

Spacing +18 added lines, -18 removed lines

@@ -130,10 +130,10 @@ 
             if ($this->isTag($word)) {
                 $word = $this->stripTagAttributes($word);
             }
-            if (isset($this->wordIndices[ $word ])) {
-                $this->wordIndices[ $word ][] = $i;
+            if (isset($this->wordIndices[$word])) {
+                $this->wordIndices[$word][] = $i;
             } else {
-                $this->wordIndices[ $word ] = array($i);
+                $this->wordIndices[$word] = array($i);
             }
         }
     }
@@ -549,7 +549,7 @@ 
             } else {
                 $firstOrDefault = false;
                 foreach ($this->config->getSpecialCaseOpeningTags() as $x) {
-                    if (preg_match($x, $words[ 0 ])) {
+                    if (preg_match($x, $words[0])) {
                         $firstOrDefault = $x;
                         break;
                     }
@@ -557,13 +557,13 @@ 
                 if ($firstOrDefault) {
                     $specialCaseTagInjection = '<ins class="mod">';
                     if ($tag == 'del') {
-                        unset($words[ 0 ]);
+                        unset($words[0]);
                     }
-                } elseif (array_search($words[ 0 ], $this->config->getSpecialCaseClosingTags()) !== false) {
+                } elseif (array_search($words[0], $this->config->getSpecialCaseClosingTags()) !== false) {
                     $specialCaseTagInjection = '</ins>';
                     $specialCaseTagInjectionIsBefore = true;
                     if ($tag == 'del') {
-                        unset($words[ 0 ]);
+                        unset($words[0]);
                     }
                 }
             }
@@ -574,12 +574,12 @@ 
                 $this->content .= $specialCaseTagInjection.implode('', $this->extractConsecutiveWords($words, 'tag'));
             } else {
                 $workTag = $this->extractConsecutiveWords($words, 'tag');
-                if (isset($workTag[ 0 ]) && $this->isOpeningTag($workTag[ 0 ]) && !$this->isClosingTag($workTag[ 0 ])) {
-                    if ($this->stringUtil->strpos($workTag[ 0 ], 'class=')) {
-                        $workTag[ 0 ] = str_replace('class="', 'class="diffmod ', $workTag[ 0 ]);
-                        $workTag[ 0 ] = str_replace("class='", 'class="diffmod ', $workTag[ 0 ]);
+                if (isset($workTag[0]) && $this->isOpeningTag($workTag[0]) && !$this->isClosingTag($workTag[0])) {
+                    if ($this->stringUtil->strpos($workTag[0], 'class=')) {
+                        $workTag[0] = str_replace('class="', 'class="diffmod ', $workTag[0]);
+                        $workTag[0] = str_replace("class='", 'class="diffmod ', $workTag[0]);
                     } else {
-                        $workTag[ 0 ] = str_replace('>', ' class="diffmod">', $workTag[ 0 ]);
+                        $workTag[0] = str_replace('>', ' class="diffmod">', $workTag[0]);
                     }
                 }
 
@@ -772,7 +772,7 @@ 
         $space = $this->stringUtil->strpos($word, ' ', 1);
 
         if ($space) {
-            return '<' . $this->stringUtil->substr($word, 1, $space) . '>';
+            return '<'.$this->stringUtil->substr($word, 1, $space).'>';
         }
 
         return trim($word, '<>');
@@ -796,15 +796,15 @@ 
 
         for ($indexInOld = $startInOld; $indexInOld < $endInOld; ++$indexInOld) {
             $newMatchLengthAt = array();
-            $index = $this->oldWords[ $indexInOld ];
+            $index = $this->oldWords[$indexInOld];
             if ($this->isTag($index)) {
                 $index = $this->stripTagAttributes($index);
             }
-            if (!isset($this->wordIndices[ $index ])) {
+            if (!isset($this->wordIndices[$index])) {
                 $matchLengthAt = $newMatchLengthAt;
                 continue;
             }
-            foreach ($this->wordIndices[ $index ] as $indexInNew) {
+            foreach ($this->wordIndices[$index] as $indexInNew) {
                 if ($indexInNew < $startInNew) {
                     continue;
                 }
@@ -812,8 +812,8 @@ 
                     break;
                 }
 
-                $newMatchLength = (isset($matchLengthAt[ $indexInNew - 1 ]) ? $matchLengthAt[ $indexInNew - 1 ] : 0) + 1;
-                $newMatchLengthAt[ $indexInNew ] = $newMatchLength;
+                $newMatchLength = (isset($matchLengthAt[$indexInNew - 1]) ? $matchLengthAt[$indexInNew - 1] : 0) + 1;
+                $newMatchLengthAt[$indexInNew] = $newMatchLength;
 
                 if ($newMatchLength > $bestMatchSize ||
                     (

lib/Caxy/HtmlDiff/AbstractDiff.php

Braces +3 added lines, -1 removed lines

@@ -527,7 +527,9 @@
                     $mode = 'tag';
                 } elseif (preg_match("/\s/u", $character)) {
                     $current_word .= $character;
-                    if (!$keepNewLines) $current_word = preg_replace('/\s+/Su', ' ', $current_word);
+                    if (!$keepNewLines) {
+                        $current_word = preg_replace('/\s+/Su', ' ', $current_word);
+                    }
                 } else {
                     if ($current_word != '') {
                         $words[] = $current_word;

Spacing +1 added lines, -1 removed lines

@@ -127,7 +127,7 @@
     public function initPurifier($defaultPurifierSerializerCache = null)
     {
         if (null !== $this->purifierConfig) {
-            $HTMLPurifierConfig  = $this->purifierConfig;
+            $HTMLPurifierConfig = $this->purifierConfig;
         } else {
             $HTMLPurifierConfig = \HTMLPurifier_Config::createDefault();
         }

lib/Caxy/HtmlDiff/Preprocessor.php

Doc Comments +10 added lines

@@ -4,6 +4,11 @@ 
 
 class Preprocessor
 {
+    /**
+     * @param string $old
+     * @param string $new
+     * @param Util\MbStringUtil $stringUtil
+     */
     public static function diffCommonPrefix($old, $new, $stringUtil)
     {
         // Quick check for common null cases.
@@ -34,6 +39,11 @@ 
         return $pointerMid;
     }
 
+    /**
+     * @param string $old
+     * @param string $new
+     * @param Util\MbStringUtil $stringUtil
+     */
     public static function diffCommonSuffix($old, $new, $stringUtil)
     {
         // Quick check for common null cases.

lib/Caxy/HtmlDiff/MatchingBlock.php

Spacing +1 added lines, -1 removed lines

@@ -30,6 +30,6 @@
 
     public function count() : int
     {
-        return (int)$this->size;
+        return (int) $this->size;
     }
 }

lib/Caxy/HtmlDiff/LcsService.php

Doc Comments +4 added lines, -4 removed lines

@@ -27,8 +27,8 @@ 
     }
 
     /**
-     * @param array $a
-     * @param array $b
+     * @param string[] $a
+     * @param string[] $b
      *
      * @return array
      */
@@ -70,8 +70,8 @@ 
      * @param $c
      * @param $a
      * @param $b
-     * @param $i
-     * @param $j
+     * @param integer $i
+     * @param integer $j
      * @param $matches
      */
     protected function compileMatches($c, $a, $b, $i, $j, &$matches)

lib/Caxy/HtmlDiff/ListDiffLines.php

Unused Use Statements -3 removed lines

@@ -4,12 +4,9 @@
 
 use Caxy\HtmlDiff\Strategy\ListItemMatchStrategy;
 use DOMDocument;
-use DOMDocumentFragment;
 use DOMElement;
 use DOMNode;
-use DOMNodeList;
 use DOMText;
-use KubAT\PhpSimple\HtmlDomParser;
 use LogicException;
 
 class ListDiffLines extends AbstractDiff

Spacing +2 added lines, -2 removed lines

@@ -384,7 +384,7 @@ 
     {
         $bufferDom = new DOMDocument();
 
-        foreach($node->childNodes as $child)
+        foreach ($node->childNodes as $child)
         {
             $bufferDom->appendChild($bufferDom->importNode($child, true));
         }
@@ -394,7 +394,7 @@ 
 
     private function setInnerText(DOMNode $node, string $html) : void
     {
-        $html = trim($html);/*
+        $html = trim($html); /*
         echo "\r\n" . '------------------------' . "\r\n";
         echo $html . "\r\n";
         echo '------------------------' . "\r\n";