Passed
Pull Request — master (#102)
by Sven
02:57
created
lib/Caxy/HtmlDiff/AbstractDiff.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -421,8 +421,8 @@
 block discarded – undo
421 421
     }
422 422
 
423 423
     /**
424
-     * @param array $characterString
425 424
      *
425
+     * @param string $text
426 426
      * @return array
427 427
      */
428 428
     protected function convertHtmlToListOfWords($text)
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
     public function initPurifier($defaultPurifierSerializerCache = null)
130 130
     {
131 131
         if (null !== $this->purifierConfig) {
132
-            $HTMLPurifierConfig  = $this->purifierConfig;
132
+            $HTMLPurifierConfig = $this->purifierConfig;
133 133
         } else {
134 134
             $HTMLPurifierConfig = HTMLPurifier_Config::createDefault();
135 135
         }
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
         $specialCharacters = '';
434 434
 
435 435
         foreach ($this->config->getSpecialCaseChars() as $char) {
436
-            $specialCharacters .= '\\' . $char;
436
+            $specialCharacters .= '\\'.$char;
437 437
         }
438 438
 
439 439
         // Normalize no-break-spaces to regular spaces
@@ -459,11 +459,11 @@  discard block
 block discarded – undo
459 459
             $lastCharacter  = $sentenceOrHtmlTag[$this->stringUtil->strlen($sentenceOrHtmlTag) - 1];
460 460
 
461 461
             if ($firstCharacter === ' ' || $firstCharacter === "\r" || $firstCharacter === "\n") {
462
-                $sentenceOrHtmlTag = ' ' . ltrim($sentenceOrHtmlTag);
462
+                $sentenceOrHtmlTag = ' '.ltrim($sentenceOrHtmlTag);
463 463
             }
464 464
 
465 465
             if ($lastCharacter === ' ' || $lastCharacter === "\r" || $lastCharacter === "\n") {
466
-                $sentenceOrHtmlTag = rtrim($sentenceOrHtmlTag) . ' ';
466
+                $sentenceOrHtmlTag = rtrim($sentenceOrHtmlTag).' ';
467 467
             }
468 468
 
469 469
             $sentenceSplitIntoWords = [];
@@ -477,8 +477,8 @@  discard block
 block discarded – undo
477 477
             // Third group is alpha numeric words including special characters
478 478
             // Fourth group is a catch all of everything else.
479 479
             preg_match_all(
480
-                '/\s|[a-zA-Z0-9' . $specialCharacters . '\pL]+(?=[' . $specialCharacters . '][\s\r\n])|[a-zA-Z0-9' . $specialCharacters . '\pL]+|[^\s]/mu',
481
-                $sentenceOrHtmlTag . ' ', // Inject a space at the end to make sure the second regex always hits.
480
+                '/\s|[a-zA-Z0-9'.$specialCharacters.'\pL]+(?=['.$specialCharacters.'][\s\r\n])|[a-zA-Z0-9'.$specialCharacters.'\pL]+|[^\s]/mu',
481
+                $sentenceOrHtmlTag.' ', // Inject a space at the end to make sure the second regex always hits.
482 482
                 $sentenceSplitIntoWords,
483 483
                 PREG_SPLIT_NO_EMPTY
484 484
             );
Please login to merge, or discard this patch.
lib/Caxy/HtmlDiff/HtmlDiff.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -545,7 +545,7 @@  discard block
 block discarded – undo
545 545
             } else {
546 546
                 $firstOrDefault = false;
547 547
                 foreach ($this->config->getSpecialCaseOpeningTags() as $x) {
548
-                    if (preg_match($x, $words[ 0 ])) {
548
+                    if (preg_match($x, $words[0])) {
549 549
                         $firstOrDefault = $x;
550 550
                         break;
551 551
                     }
@@ -553,13 +553,13 @@  discard block
 block discarded – undo
553 553
                 if ($firstOrDefault) {
554 554
                     $specialCaseTagInjection = '<ins class="mod">';
555 555
                     if ($tag === 'del') {
556
-                        unset($words[ 0 ]);
556
+                        unset($words[0]);
557 557
                     }
558
-                } elseif (array_search($words[ 0 ], $this->config->getSpecialCaseClosingTags()) !== false) {
558
+                } elseif (array_search($words[0], $this->config->getSpecialCaseClosingTags()) !== false) {
559 559
                     $specialCaseTagInjection = '</ins>';
560 560
                     $specialCaseTagInjectionIsBefore = true;
561 561
                     if ($tag === 'del') {
562
-                        unset($words[ 0 ]);
562
+                        unset($words[0]);
563 563
                     }
564 564
                 }
565 565
             }
@@ -567,7 +567,7 @@  discard block
 block discarded – undo
567 567
                 break;
568 568
             }
569 569
             if ($specialCaseTagInjectionIsBefore) {
570
-                $this->content .= $specialCaseTagInjection . implode('', $this->extractConsecutiveWords($words, 'tag'));
570
+                $this->content .= $specialCaseTagInjection.implode('', $this->extractConsecutiveWords($words, 'tag'));
571 571
             } else {
572 572
                 $workTag = $this->extractConsecutiveWords($words, 'tag');
573 573
 
@@ -589,7 +589,7 @@  discard block
 block discarded – undo
589 589
                     }
590 590
                 }
591 591
 
592
-                $appendContent = implode('', $workTag) . $specialCaseTagInjection;
592
+                $appendContent = implode('', $workTag).$specialCaseTagInjection;
593 593
 
594 594
                 if (isset($workTag[0]) === true && $this->stringUtil->stripos($workTag[0], '<img') !== false) {
595 595
                     $appendContent = $this->wrapText($appendContent, $tag, $cssClass);
@@ -765,7 +765,7 @@  discard block
 block discarded – undo
765 765
         $space = $this->stringUtil->strpos($word, ' ', 1);
766 766
 
767 767
         if ($space > 0) {
768
-            return '<' . $this->stringUtil->substr($word, 1, $space) . '>';
768
+            return '<'.$this->stringUtil->substr($word, 1, $space).'>';
769 769
         }
770 770
 
771 771
         return trim($word, '<>');
@@ -782,7 +782,7 @@  discard block
 block discarded – undo
782 782
         for ($indexInOld = $startInOld; $indexInOld < $endInOld; ++$indexInOld) {
783 783
             $newMatchLengthAt = [];
784 784
 
785
-            $index = $this->oldWords[ $indexInOld ];
785
+            $index = $this->oldWords[$indexInOld];
786 786
 
787 787
             if ($this->isTag($index) === true) {
788 788
                 $index = $this->stripTagAttributes($index);
Please login to merge, or discard this patch.