caseyamcl / phpoaipmh

example/src/ExampleCommand.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -19,10 +19,10 @@
 namespace Phpoaipmh\Example;
 
 use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
-use Symfony\Component\Console\Helper\Table;
 
 /**
  * A symfony 2 console command.

Indentation +4 added lines, -4 removed lines

@@ -53,8 +53,8 @@ 
      */
     public function __construct(Example $example)
     {
-      $this->example = $example;
-      parent::__construct();
+        $this->example = $example;
+        parent::__construct();
     }
 
     /**
@@ -79,8 +79,8 @@ 
             $data = $this->example->getBasicInformation();
             $output->writeln("Basic information: ");
             foreach ($data as $key => $value) {
-              $line = $formatter->formatSection($key, $value);
-              $output->writeln($line);
+                $line = $formatter->formatSection($key, $value);
+                $output->writeln($line);
             }
         }
 

src/Phpoaipmh/HttpAdapter/CurlAdapter.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
      */
     public function __construct(array $curlOpts = [])
     {
-        if (! is_callable('curl_exec')) {
+        if (!is_callable('curl_exec')) {
             throw new \Exception("OAI-PMH CurlAdapter HTTP HttpAdapterInterface requires the CURL PHP Extension");
         }
 

example/src/Example.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
      */
     public function __construct()
     {
-        $oaiUrl   = 'http://openscholarship.wustl.edu/do/oai/';
+        $oaiUrl = 'http://openscholarship.wustl.edu/do/oai/';
         $client = new Client($oaiUrl);
         $this->endpoint = new Endpoint($client);
     }

src/Phpoaipmh/Client.php

Spacing +2 added lines, -2 removed lines

@@ -87,13 +87,13 @@
      */
     public function request($verb, array $params = array())
     {
-        if (! $this->url) {
+        if (!$this->url) {
             throw new RuntimeException("Cannot perform request when URL not set.  Use setUrl() method");
         }
 
         //Build the URL
         $params = array_merge(array('verb' => $verb), $params);
-        $url = $this->url . (parse_url($this->url, PHP_URL_QUERY) ? '&' : '?') . http_build_query($params);
+        $url = $this->url.(parse_url($this->url, PHP_URL_QUERY) ? '&' : '?').http_build_query($params);
 
         //Do the request
         try {

src/Phpoaipmh/RecordIterator.php

Spacing +3 added lines, -3 removed lines

@@ -96,8 +96,8 @@ 
         $this->resumptionToken  = $resumptionToken;
 
         //Node name error?
-        if (! $this->getItemNodeName()) {
-            throw new BaseOaipmhException('Cannot determine item name for verb: ' . $this->verb);
+        if (!$this->getItemNodeName()) {
+            throw new BaseOaipmhException('Cannot determine item name for verb: '.$this->verb);
         }
     }
 
@@ -201,7 +201,7 @@ 
         $this->numRequests++;
 
         //Result format error?
-        if (! isset($resp->$verb->$nodeName)) {
+        if (!isset($resp->$verb->$nodeName)) {
             throw new MalformedResponseException(sprintf("Expected XML element list '%s' missing for verb '%s'", $nodeName, $verb));
         }
 

Doc Comments +3 added lines, -2 removed lines

@@ -84,6 +84,7 @@ 
      * @param ClientInterface $client  The client to use
      * @param string          $verb    The verb to use when retrieving results from the client
      * @param array           $params  Optional parameters passed to OAI-PMH
+     * @param string $resumptionToken
      */
     public function __construct(ClientInterface $client, $verb, array $params = array(), $resumptionToken = null)
     {
@@ -102,7 +103,7 @@ 
     /**
      * Get the total number of requests made during this run
      *
-     * @return int The number of HTTP requests made
+     * @return boolean The number of HTTP requests made
      */
     public function getNumRequests()
     {
@@ -259,7 +260,7 @@ 
      *
      * Map the item node name based on the verb
      *
-     * @return string|boolean The element name for the mapping, or false if unmapped
+     * @return string|false The element name for the mapping, or false if unmapped
      */
     private function getItemNodeName()
     {

src/Phpoaipmh/Exception/OaipmhException.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
     public function __toString()
     {
         $refl = new \ReflectionClass($this);
-        return $refl->getShortName() . ": [{$this->code}]: ({$this->oaiErrorCode}) {$this->message}";
+        return $refl->getShortName().": [{$this->code}]: ({$this->oaiErrorCode}) {$this->message}";
     }
 
     public function getOaiErrorCode()