GetRequest::exec() - Code Metrics - Inspection of "Merge pull request #24 from carpenstar/v.5.0.0.2" - carpenstar/bybitapi-sdk-core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a67e0e...5a6b87 )

by Vladislav

created 2024-07-27 23:57 UTC

GetRequest::exec() A

↳ Parent: GetRequest

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
c	1
b	0
f	0
dl	0
loc	12
rs	10
cc	2
nc	2
nop	2

<?php

namespace Carpenstar\ByBitAPI\Core\Request;

use Carpenstar\ByBitAPI\Core\Enums\EnumHttpMethods;
use Carpenstar\ByBitAPI\Core\Interfaces\IResponseHandlerInterface;

class GetRequest extends Curl
{
    /**
     * @param string $endpoint
     * @param array $queryParams
     * @return IResponseHandlerInterface
     */
    public function execute(string $endpoint, array $queryParams): array
    {
        $queryString = $this->buildRequestParams($queryParams);

        $this->addCurlOpt(CURLOPT_URL, $this->credentials->getHost() . $endpoint . '?' . $queryString)
             ->addCurlOpt(CURLOPT_CUSTOMREQUEST, EnumHttpMethods::GET);

        $this->auth($queryString);


        return $this->query();

    }

    /**
     * @param array $queryParams
     * @return string
     */
    private function buildRequestParams(array $queryParams): ?string
    {
        return http_build_query($queryParams);
    }
}


1			<?php
2
3			namespace Carpenstar\ByBitAPI\Core\Request;
4
5			use Carpenstar\ByBitAPI\Core\Enums\EnumHttpMethods;
6			use Carpenstar\ByBitAPI\Core\Interfaces\IResponseHandlerInterface;
7
8			class GetRequest extends Curl
9			{
10			/**
11			* @param string $endpoint
12			* @param array $queryParams
13			* @return IResponseHandlerInterface
14			*/
15			public function execute(string $endpoint, array $queryParams): array
16			{
17			$queryString = $this->buildRequestParams($queryParams);
18
19			$this->addCurlOpt(CURLOPT_URL, $this->credentials->getHost() . $endpoint . '?' . $queryString)
20			->addCurlOpt(CURLOPT_CUSTOMREQUEST, EnumHttpMethods::GET);
21
22			$this->auth($queryString);
23
24
25			return $this->query();
			0 ignored issues – show Bug Best Practice introduced 2024-07-28 00:04 UTC by Report Bug Copy Issue Report The expression `return $this->query()` returns the type `array` which is incompatible with the documented return type `Carpenstar\ByBitAPI\Core...esponseHandlerInterface`. Loading history...
26			}
27
28			/**
29			* @param array $queryParams
30			* @return string
31			*/
32			private function buildRequestParams(array $queryParams): ?string
33			{
34			return http_build_query($queryParams);
35			}
36			}
37

carpenstar / bybitapi-sdk-core

Push — master ( a67e0e...5a6b87 )

GetRequest::exec() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like