Carpenstar\ByBitAPI\Core\Request\GetRequest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	execute()	0	11	1
A	buildRequestParams()	0	3	1

<?php

namespace Carpenstar\ByBitAPI\Core\Request;

use Carpenstar\ByBitAPI\Core\Enums\EnumHttpMethods;
use Carpenstar\ByBitAPI\Core\Interfaces\IResponseHandlerInterface;

class GetRequest extends Curl
{
    /**
     * @param string $endpoint
     * @param array $queryParams
     * @return IResponseHandlerInterface
     */
    public function execute(string $endpoint, array $queryParams): array
    {
        $queryString = $this->buildRequestParams($queryParams);

        $this->addCurlOpt(CURLOPT_URL, $this->credentials->getHost() . $endpoint . '?' . $queryString)
             ->addCurlOpt(CURLOPT_CUSTOMREQUEST, EnumHttpMethods::GET);

        $this->auth($queryString);


        return $this->query();

The expression return $this->query() returns the type array which is incompatible with the documented return type Carpenstar\ByBitAPI\Core\Interfaces\IResponseHandlerInterface.

    }

    /**
     * @param array $queryParams
     * @return string
     */
    private function buildRequestParams(array $queryParams): ?string
    {
        return http_build_query($queryParams);
    }
}