Carpenstar\ByBitAPI\Core\Builders\ResponseHandlerBuilder::make()

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function make(string $data, string $curlResponse = null, string $dto = null): IResponseInterface
    {
        if (!in_array(IResponseHandlerInterface::class, class_implements($curlResponse))) {
            throw new \Exception("{$dto} must be implements the interface " . IResponseHandlerInterface::class . "!");
        }

        if (!in_array(IResponseDataInterface::class, class_implements($dto))) {
            throw new \Exception("{$dto} must be implements the interface " . IResponseDataInterface::class . "!");
        }

        /**
         * @var IResponseHandlerInterface $curlResponse
         */
        $curlResponse = new $curlResponse();

        return $curlResponse->build($data, $dto);

$data of type string is incompatible with the type array expected by parameter $apiData of Carpenstar\ByBitAPI\Core\Interfaces\IResponseHandlerInterface::build().

It seems like $dto can also be of type null; however, parameter $dto of Carpenstar\ByBitAPI\Core\Interfaces\IResponseHandlerInterface::build() does only seem to accept string, maybe add an additional type check?

    }