Carpenstar\ByBitAPI\Core\Builders\ResponseHandlerBuilder

Complexity

Total Complexity

3

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	make()	0	16	3

<?php

namespace Carpenstar\ByBitAPI\Core\Builders;

use Carpenstar\ByBitAPI\Core\Enums\EnumOutputMode;
use Carpenstar\ByBitAPI\Core\Interfaces\IResponseInterface;
use Carpenstar\ByBitAPI\Core\Interfaces\ISuccessCurlResponseDtoInterface;
use Carpenstar\ByBitAPI\Core\Interfaces\IFabricInterface;
use Carpenstar\ByBitAPI\Core\Interfaces\IResponseDataInterface;
use Carpenstar\ByBitAPI\Core\Interfaces\IResponseHandlerInterface;

class ResponseHandlerBuilder implements IFabricInterface
{
    /**
     * @param string $data
     * @param string|null $curlResponse
     * @param string|null $dto
     * @param int $resultMode
     * @return IResponseInterface
     * @throws \Exception
     */
    public static function make(string $data, string $curlResponse = null, string $dto = null): IResponseInterface
    {
        if (!in_array(IResponseHandlerInterface::class, class_implements($curlResponse))) {
            throw new \Exception("{$dto} must be implements the interface " . IResponseHandlerInterface::class . "!");
        }

        if (!in_array(IResponseDataInterface::class, class_implements($dto))) {
            throw new \Exception("{$dto} must be implements the interface " . IResponseDataInterface::class . "!");
        }

        /**
         * @var IResponseHandlerInterface $curlResponse
         */
        $curlResponse = new $curlResponse();

        return $curlResponse->build($data, $dto);

$data of type string is incompatible with the type array expected by parameter $apiData of Carpenstar\ByBitAPI\Core\Interfaces\IResponseHandlerInterface::build().

It seems like $dto can also be of type null; however, parameter $dto of Carpenstar\ByBitAPI\Core\Interfaces\IResponseHandlerInterface::build() does only seem to accept string, maybe add an additional type check?

    }
}