Carno\Socket\Powered\Swoole\Chips\Porting::porting()

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function porting(SWServer $master, SWPorted $ported, Events $events, Options $options = null) : TServer
    {
        $this->server = $master;

The property server does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->events = $events;

The property events does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->registerEvs($ported, ['bufferFull', 'bufferEmpty']);

It seems like registerEvs() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->registerEvs($ported, $this->k2evs($events->keys(), [
            Events\Socket::CONNECTED => 'connect',
            Events\Socket::RECEIVED => 'receive',
            Events\Socket::CLOSED => 'close',
        ]));

        $options && $this->serverConfig($ported, $options->config());

It seems like serverConfig() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this;

The expression return $this returns the type Carno\Socket\Powered\Swoole\Chips\Porting which is incompatible with the type-hinted return Carno\Socket\Contracts\TServer.

    }