Carno\Socket\Powered\Swoole\Chips\Porting

Complexity

Total Complexity

5

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	k2evs()	0	9	3
A	porting()	0	16	2

<?php
/**
 * Server porting
 * User: moyo
 * Date: 2018/8/27
 * Time: 10:49 AM
 */

namespace Carno\Socket\Powered\Swoole\Chips;

use Carno\Net\Events;
use Carno\Socket\Contracts\TServer;
use Carno\Socket\Options;
use Swoole\Server as SWServer;

The type Swoole\Server was not found. Maybe you did not declare it correctly or list all dependencies?

use Swoole\Server\Port as SWPorted;

The type Swoole\Server\Port was not found. Maybe you did not declare it correctly or list all dependencies?

trait Porting
{
    /**
     * @param SWServer $master
     * @param SWPorted $ported
     * @param Events $events
     * @param Options $options
     * @return TServer
     */
    public function porting(SWServer $master, SWPorted $ported, Events $events, Options $options = null) : TServer
    {
        $this->server = $master;

The property server does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->events = $events;

The property events does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->registerEvs($ported, ['bufferFull', 'bufferEmpty']);

It seems like registerEvs() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->registerEvs($ported, $this->k2evs($events->keys(), [
            Events\Socket::CONNECTED => 'connect',
            Events\Socket::RECEIVED => 'receive',
            Events\Socket::CLOSED => 'close',
        ]));

        $options && $this->serverConfig($ported, $options->config());

It seems like serverConfig() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this;

The expression return $this returns the type Carno\Socket\Powered\Swoole\Chips\Porting which is incompatible with the type-hinted return Carno\Socket\Contracts\TServer.

    }

    /**
     * @param array $keys
     * @param array $map
     * @return array
     */
    private function k2evs(array $keys, array $map)
    {
        $evs = [];

        foreach ($keys as $key) {
            isset($map[$key]) && $evs[] = $map[$key];
        }

        return $evs;
    }
}