cardinity / cardinity-sdk-php

src/Method/Payment/Payment.php

Doc Comments +14 added lines, -14 removed lines

@@ -90,7 +90,7 @@ 
 
     /**
      * Gets the value of id.
-     * @return mixed
+     * @return string
      */
     public function getId()
     {
@@ -109,7 +109,7 @@ 
 
     /**
      * Gets the value of amount.
-     * @return mixed
+     * @return double
      */
     public function getAmount()
     {
@@ -128,7 +128,7 @@ 
 
     /**
      * Gets the value of currency.
-     * @return mixed
+     * @return string
      */
     public function getCurrency()
     {
@@ -147,7 +147,7 @@ 
 
     /**
      * Gets the value of created.
-     * @return mixed
+     * @return string
      */
     public function getCreated()
     {
@@ -166,7 +166,7 @@ 
 
     /**
      * Gets the value of type.
-     * @return mixed
+     * @return string
      */
     public function getType()
     {
@@ -185,7 +185,7 @@ 
 
     /**
      * Gets the value of live.
-     * @return mixed
+     * @return boolean
      */
     public function getLive()
     {
@@ -204,7 +204,7 @@ 
 
     /**
      * Gets the value of settle.
-     * @return mixed
+     * @return boolean
      */
     public function getSettle()
     {
@@ -223,7 +223,7 @@ 
 
     /**
      * Gets the value of status.
-     * @return mixed
+     * @return string
      */
     public function getStatus()
     {
@@ -242,7 +242,7 @@ 
 
     /**
      * Gets the value of error.
-     * @return mixed
+     * @return string
      */
     public function getError()
     {
@@ -261,7 +261,7 @@ 
 
     /**
      * Gets the value of orderId.
-     * @return mixed
+     * @return string
      */
     public function getOrderId()
     {
@@ -280,7 +280,7 @@ 
 
     /**
      * Gets the value of description.
-     * @return mixed
+     * @return string
      */
     public function getDescription()
     {
@@ -299,7 +299,7 @@ 
 
     /**
      * Gets the value of country.
-     * @return mixed
+     * @return string
      */
     public function getCountry()
     {
@@ -318,7 +318,7 @@ 
 
     /**
      * Gets the value of paymentMethod.
-     * @return mixed
+     * @return string
      */
     public function getPaymentMethod()
     {
@@ -357,7 +357,7 @@ 
     /**
      * @deprecated method is deprecated and shouldn't be used.
      * Gets the value of authorizeData.
-     * @return mixed
+     * @return string
      */
     public function getAuthorizeData()
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Cardinity\Method\Payment;
 
 use Cardinity\Method\ResultObject;
-use Cardinity\Method\Payment\ThreeDS2Data;
 use Cardinity\Method\Payment\ThreeDS2AuthorizationInformation;
 
 class Payment extends ResultObject

Spacing +2 added lines, -2 removed lines

@@ -408,7 +408,7 @@ 
      */
     public function setThreeds2data(
         ThreeDS2AuthorizationInformation $threeDS2AuthorizationInformation
-    ){
+    ) {
         $this->threeDS2AuthorizationInformation = $threeDS2AuthorizationInformation;
     }
 
@@ -426,7 +426,7 @@ 
      */
     public function setThreeDS2AuthorizationInformation(
         ThreeDS2AuthorizationInformation $threeDS2AuthorizationInformation
-    ){
+    ) {
         $this->threeDS2AuthorizationInformation = $threeDS2AuthorizationInformation;
     }
 

src/Method/Payment/Create.php

Spacing +5 added lines, -5 removed lines

@@ -43,11 +43,11 @@ 
     {
         return new Assert\Collection([
             'amount' =>  $this->buildElement('float', 1),
-            'currency' => $this->buildElement('string', 1, ['min' => 3,'max' => 3]),
+            'currency' => $this->buildElement('string', 1, ['min' => 3, 'max' => 3]),
             'settle' => $this->buildElement('bool'),
-            'order_id' => $this->buildElement('string', 0, ['min' => 2,'max' => 50]),
+            'order_id' => $this->buildElement('string', 0, ['min' => 2, 'max' => 50]),
             'description' => $this->buildElement('string', 0, ['max' => 255]),
-            'country' => $this->buildElement('string', 1, ['min' => 2,'max' => 2]),
+            'country' => $this->buildElement('string', 1, ['min' => 2, 'max' => 2]),
             'payment_method' => new Assert\Required([
                 new Assert\Type([
                     'type' => 'string',
@@ -80,7 +80,7 @@ 
                     ]),
                     'exp_year' => $this->buildElement(
                         'integer', 1, 
-                        ['min' => 4,'max' => 4],
+                        ['min' => 4, 'max' => 4],
                         new Assert\Range(['min' => date('Y')]),
                     ),
                     'exp_month' => $this->buildElement('integer', 1),
@@ -166,7 +166,7 @@ 
         ]); 
     }
 
-    private function buildElement($typeValue, bool $isRequired=false, $length=0, $args=0)
+    private function buildElement($typeValue, bool $isRequired = false, $length = 0, $args = 0)
     {
         $inside_array = [
             new Assert\Type([

Braces +9 added lines, -3 removed lines

@@ -174,9 +174,15 @@
                 'message' => 'The value {{ value }} is not a valid {{ type }}.'
             ]),
         ];
-        if ($isRequired) array_unshift($inside_array, new Assert\NotBlank());
-        if ($length) array_push($inside_array, new Assert\Length($length));
-        if ($args) array_push($inside_array, $args);
+        if ($isRequired) {
+            array_unshift($inside_array, new Assert\NotBlank());
+        }
+        if ($length) {
+            array_push($inside_array, new Assert\Length($length));
+        }
+        if ($args) {
+            array_push($inside_array, $args);
+        }
         
         return $isRequired 
             ? new Assert\Required($inside_array)

src/Method/Payment/Finalize.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
     private $authorizeData;
     private $finalizeKey;
 
-    public function __construct(string $paymentId, string $authorizeData, $isV2=false)
+    public function __construct(string $paymentId, string $authorizeData, $isV2 = false)
     {
         $this->paymentId = $paymentId;
         $this->authorizeData = $authorizeData;