bytic / router

src/Route/Traits/HasRequestTrait.php

<?php

namespace Nip\Router\Route\Traits;

/**
 * Trait HasRequestTrait
 * @package Nip\Router\Route\Traits
 */
trait HasRequestTrait
{
    protected $request = null;

    public function populateRequest()
    {
        $params = $this->getParams();

It seems like getParams() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        foreach ($params as $param => $value) {
            switch ($param) {
                case 'module':
                    $this->getRequest()->setModuleName($value);
                    break;
                case 'controller':
                    $this->getRequest()->setControllerName($value);
                    break;
                case 'action':
                    $this->getRequest()->setActionName($value);
                    break;
                default:
                    $this->getRequest()->attributes->set($param, $value);
                    break;
            }
        }
        $this->getRequest()->attributes->add($this->getMatches());

It seems like getMatches() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @return \Nip\Request
     */
    public function getRequest()
    {
        return $this->request;
    }

    /**
     * @param \Nip\Request $request
     */
    public function setRequest($request)
    {
        $this->request = $request;
    }
}