Nip\Router\Route\Traits\HasRequestTrait::populateRequest()

Complexity

Conditions	5
Paths	5

Size

Total Lines	20
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function populateRequest()
    {
        $params = $this->getParams();

It seems like getParams() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        foreach ($params as $param => $value) {
            switch ($param) {
                case 'module':
                    $this->getRequest()->setModuleName($value);
                    break;
                case 'controller':
                    $this->getRequest()->setControllerName($value);
                    break;
                case 'action':
                    $this->getRequest()->setActionName($value);
                    break;
                default:
                    $this->getRequest()->attributes->set($param, $value);
                    break;
            }
        }
        $this->getRequest()->attributes->add($this->getMatches());

It seems like getMatches() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }