bytic / payments-mobilpay

src/Form.php

<?php

namespace ByTIC\Payments\Mobilpay;

use ByTIC\Payments\Gateways\Providers\AbstractGateway\Form as AbstractForm;
use ByTIC\Payments\Models\Methods\Types\CreditCards;
use Symfony\Component\HttpFoundation\File\UploadedFile;

/**
 * Class Form
 * @package ByTIC\Payments\Mobilpay
 */
class Form extends AbstractForm
{
    public function initElements()
    {
        parent::initElements();
        $this->initElementSandbox();
        $this->addInput('signature', 'Signature', false);
        $this->addInput('sellerId', 'Seller ID', false);
        $this->addInput('username', 'Username', false);

        $this->addFile('file', 'Certificate', false);
        $this->addTextarea('certificate', 'Certificate', false);
        $element = $this->getForm()->getElement('mobilpay[certificate]');
        $element->setAttrib('readonly', 'readonly');

        $this->addFile('private-key', 'Private key', false);
        $this->addTextarea('privateKey', 'Private key', false);
        $element = $this->getForm()->getElement('mobilpay[privateKey]');
        $element->setAttrib('readonly', 'readonly');
    }

    public function getDataFromModel()
    {
        $type = $this->getForm()->getModel()->getType();
        if ($type instanceof CreditCards) {

$type is never a sub-type of ByTIC\Payments\Models\Methods\Types\CreditCards.

            $type->getGateway();
        }
        parent::getDataFromModel();
    }

    /**
     * @return bool
     */
    public function processValidation()
    {
        parent::processValidation();

        if (isset($_FILES['mobilpay'])) {
            $files = ['file', 'private-key'];
            foreach ($files as $fileType) {
                $element = $this->getForm()->getElement('mobilpay['.$fileType.']');

                /** @var UploadedFile $uploadedFile */
                $uploadedFile = $element->getValue();

Are you sure the assignment to $uploadedFile is correct as $element->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

                if ($uploadedFile instanceof UploadedFile) {
                    if ($uploadedFile->isValid()) {
                        $extension = $fileType == 'file' ? 'cer' : 'key';
                        if ($uploadedFile->getClientOriginalExtension() != $extension) {
                            $element->addError(
                                'Invalid extension ['.$extension.']['.$uploadedFile->getClientOriginalName().']'
                            );
                        }
                    } else {
                        $element->addError($uploadedFile->getErrorMessage());
                    }
                }
            }
        }

        return true;
    }

    /**
     * @inheritdoc
     */
    protected function generateModelOptions()
    {
        $options = parent::generateModelOptions();

The assignment to $options is dead and can be removed.

        $files = ['certificate', 'privateKey'];

The assignment to $files is dead and can be removed.

        return $this->files[$type];

The property files does not exist on ByTIC\Payments\Mobilpay\Form. Did you maybe forget to declare it?

The variable $type seems to be never defined.

    }

    /**
     * @return array
     */
    public function getOptionsForSaveToModel()
    {
        $options = parent::getOptionsForSaveToModel();
        unset($options['file'], $options['private-key']);
        return $options;
    }

    /**
     * @return bool
     */
    public function process()
    {
        parent::process();

        $model = $this->getForm()->getModel();
        $options = $model->getPaymentGatewayOptions();

        $files = ['file' => 'certificate', 'private-key' => 'privateKey'];
        foreach ($files as $file => $variable) {
            $fileData = $this->getForm()->getElement('mobilpay[' . $file . ']')->getValue();

Are you sure the assignment to $fileData is correct as $this->getForm()->getElement('mobilpay[' . $file . ']')->getValue() targeting Nip\Form\Elements\AbstractElement::getValue() seems to always return null.

            if (is_array($fileData) && $fileData['tmp_name']) {
                $content = file_get_contents($fileData["tmp_name"]);
                $options[$variable] = $content;
            }
        }

        $model->setPaymentGatewayOptions($options);
        $model->saveRecord();

        return $options;

The expression return $options returns the type Nip_Form which is incompatible with the documented return type boolean.

    }
}