Form::processValidation() - Code Metrics - bytic/payments-mobilpay - Measure and Improve Code Quality continuously with Scrutinizer

Form::processValidation() B
last analyzed 2021-07-08 19:23 UTC

↳ Parent: Form

Complexity

Conditions	7
Paths	2

Size

Total Lines	27
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	7
eloc	15
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	27
ccs	0
cts	14
cp	0
crap	56
rs	8.8333

<?php

namespace ByTIC\Payments\Mobilpay;

use ByTIC\Payments\Gateways\Providers\AbstractGateway\Form as AbstractForm;
use ByTIC\Payments\Models\Methods\Types\CreditCards;
use Symfony\Component\HttpFoundation\File\UploadedFile;

/**
 * Class Form
 * @package ByTIC\Payments\Mobilpay
 */
class Form extends AbstractForm
{
    public function initElements()
    {
        parent::initElements();
        $this->initElementSandbox();
        $this->addInput('signature', 'Signature', false);
        $this->addInput('sellerId', 'Seller ID', false);
        $this->addInput('username', 'Username', false);

        $this->addFile('file', 'Certificate', false);
        $this->addTextarea('certificate', 'Certificate', false);
        $element = $this->getForm()->getElement('mobilpay[certificate]');
        $element->setAttrib('readonly', 'readonly');

        $this->addFile('private-key', 'Private key', false);
        $this->addTextarea('privateKey', 'Private key', false);
        $element = $this->getForm()->getElement('mobilpay[privateKey]');
        $element->setAttrib('readonly', 'readonly');
    }

    public function getDataFromModel()
    {
        $type = $this->getForm()->getModel()->getType();
        if ($type instanceof CreditCards) {

            $type->getGateway();
        }
        parent::getDataFromModel();
    }

    /**
     * @return bool
     */
    public function processValidation()
    {
        parent::processValidation();

        if (isset($_FILES['mobilpay'])) {
            $files = ['file', 'private-key'];
            foreach ($files as $fileType) {
                $element = $this->getForm()->getElement('mobilpay['.$fileType.']');

                /** @var UploadedFile $uploadedFile */
                $uploadedFile = $element->getValue();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
                if ($uploadedFile instanceof UploadedFile) {
                    if ($uploadedFile->isValid()) {
                        $extension = $fileType == 'file' ? 'cer' : 'key';
                        if ($uploadedFile->getClientOriginalExtension() != $extension) {
                            $element->addError(
                                'Invalid extension ['.$extension.']['.$uploadedFile->getClientOriginalName().']'
                            );
                        }
                    } else {
                        $element->addError($uploadedFile->getErrorMessage());
                    }
                }
            }
        }

        return true;
    }

    /**
     * @inheritdoc
     */
    protected function generateModelOptions()
    {
        $options = parent::generateModelOptions();


        $files = ['certificate', 'privateKey'];


        return $this->files[$type];

    }

    /**
     * @return array
     */
    public function getOptionsForSaveToModel()
    {
        $options = parent::getOptionsForSaveToModel();
        unset($options['file'], $options['private-key']);
        return $options;
    }

    /**
     * @return bool
     */
    public function process()
    {
        parent::process();

        $model = $this->getForm()->getModel();
        $options = $model->getPaymentGatewayOptions();

        $files = ['file' => 'certificate', 'private-key' => 'privateKey'];
        foreach ($files as $file => $variable) {
            $fileData = $this->getForm()->getElement('mobilpay[' . $file . ']')->getValue();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            if (is_array($fileData) && $fileData['tmp_name']) {
                $content = file_get_contents($fileData["tmp_name"]);
                $options[$variable] = $content;
            }
        }

        $model->setPaymentGatewayOptions($options);
        $model->saveRecord();

        return $options;

    }
}


1			<?php
2
3			namespace ByTIC\Payments\Mobilpay;
4
5			use ByTIC\Payments\Gateways\Providers\AbstractGateway\Form as AbstractForm;
6			use ByTIC\Payments\Models\Methods\Types\CreditCards;
7			use Symfony\Component\HttpFoundation\File\UploadedFile;
8
9			/**
10			* Class Form
11			* @package ByTIC\Payments\Mobilpay
12			*/
13			class Form extends AbstractForm
14			{
15			public function initElements()
16			{
17			parent::initElements();
18			$this->initElementSandbox();
19			$this->addInput('signature', 'Signature', false);
20			$this->addInput('sellerId', 'Seller ID', false);
21			$this->addInput('username', 'Username', false);
22
23			$this->addFile('file', 'Certificate', false);
24			$this->addTextarea('certificate', 'Certificate', false);
25			$element = $this->getForm()->getElement('mobilpay[certificate]');
26			$element->setAttrib('readonly', 'readonly');
27
28			$this->addFile('private-key', 'Private key', false);
29			$this->addTextarea('privateKey', 'Private key', false);
30			$element = $this->getForm()->getElement('mobilpay[privateKey]');
31			$element->setAttrib('readonly', 'readonly');
32			}
33
34			public function getDataFromModel()
35			{
36			$type = $this->getForm()->getModel()->getType();
37			if ($type instanceof CreditCards) {
			0 ignored issues – show introduced 2020-11-27 18:32 UTC by Report Bug Copy Issue Report `$type` is never a sub-type of `ByTIC\Payments\Models\Methods\Types\CreditCards`. Loading history...
38			$type->getGateway();
39			}
40			parent::getDataFromModel();
41			}
42
43			/**
44			* @return bool
45			*/
46			public function processValidation()
47			{
48			parent::processValidation();
49
50			if (isset($_FILES['mobilpay'])) {
51			$files = ['file', 'private-key'];
52			foreach ($files as $fileType) {
53			$element = $this->getForm()->getElement('mobilpay['.$fileType.']');
54
55			/** @var UploadedFile $uploadedFile */
56			$uploadedFile = $element->getValue();
			0 ignored issues – show Bug introduced 2020-11-27 18:32 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$uploadedFile` is correct as `$element->getValue()` targeting `Nip\Form\Elements\AbstractElement::getValue()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
57			if ($uploadedFile instanceof UploadedFile) {
58			if ($uploadedFile->isValid()) {
59			$extension = $fileType == 'file' ? 'cer' : 'key';
60			if ($uploadedFile->getClientOriginalExtension() != $extension) {
61			$element->addError(
62			'Invalid extension ['.$extension.']['.$uploadedFile->getClientOriginalName().']'
63			);
64			}
65			} else {
66			$element->addError($uploadedFile->getErrorMessage());
67			}
68			}
69			}
70			}
71
72			return true;
73			}
74
75			/**
76			* @inheritdoc
77			*/
78			protected function generateModelOptions()
79			{
80			$options = parent::generateModelOptions();
			0 ignored issues – show Unused Code introduced 2020-11-27 18:32 UTC by Report Bug Copy Issue Report The assignment to `$options` is dead and can be removed. Loading history...
81
82			$files = ['certificate', 'privateKey'];
			0 ignored issues – show Unused Code introduced 2020-11-27 18:32 UTC by Report Bug Copy Issue Report The assignment to `$files` is dead and can be removed. Loading history...
83
84			return $this->files[$type];
			0 ignored issues – show Bug Best Practice introduced 2020-11-27 18:32 UTC by Report Bug Copy Issue Report The property `files` does not exist on `ByTIC\Payments\Mobilpay\Form`. Did you maybe forget to declare it? Loading history... Comprehensibility Best Practice introduced 2020-11-27 18:32 UTC by Report Bug Copy Issue Report The variable `$type` seems to be never defined. Loading history...
85			}
86
87			/**
88			* @return array
89			*/
90			public function getOptionsForSaveToModel()
91			{
92			$options = parent::getOptionsForSaveToModel();
93			unset($options['file'], $options['private-key']);
94			return $options;
95			}
96
97			/**
98			* @return bool
99			*/
100			public function process()
101			{
102			parent::process();
103
104			$model = $this->getForm()->getModel();
105			$options = $model->getPaymentGatewayOptions();
106
107			$files = ['file' => 'certificate', 'private-key' => 'privateKey'];
108			foreach ($files as $file => $variable) {
109			$fileData = $this->getForm()->getElement('mobilpay[' . $file . ']')->getValue();
			0 ignored issues – show Bug introduced 2020-11-27 18:32 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$fileData` is correct as `$this->getForm()->getEle...file . ']')->getValue()` targeting `Nip\Form\Elements\AbstractElement::getValue()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
110			if (is_array($fileData) && $fileData['tmp_name']) {
111			$content = file_get_contents($fileData["tmp_name"]);
112			$options[$variable] = $content;
113			}
114			}
115
116			$model->setPaymentGatewayOptions($options);
117			$model->saveRecord();
118
119			return $options;
			0 ignored issues – show Bug Best Practice introduced 2020-11-27 18:32 UTC by Report Bug Copy Issue Report The expression `return $options` returns the type `Nip_Form` which is incompatible with the documented return type `boolean`. Loading history...
120			}
121			}
122

bytic / payments-mobilpay

Form::processValidation() B last analyzed 2021-07-08 19:23 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Form::processValidation() B
last analyzed 2021-07-08 19:23 UTC