ByTIC\Hello\Models\Users\Logins\Traits\LoginsTrait::getUserByProvider()

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function getUserByProvider($provider, $uid)
    {
        $params = [
            'where' => [
                ['provider_name = ?', $provider],
                ['provider_uid = ?', $uid]
            ]
        ];

        $item = $this->findOneByParams($params);

It seems like findOneByParams() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($item) {
            /** @var UsersTrait|RecordManager $userManager */
            $userManager = $this->getRelation('User')->getWith();

It seems like getRelation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $userManager->findOne($item->id_user);

The expression return $userManager->findOne($item->id_user) returns the type Nip\Records\AbstractModels\Record which is incompatible with the documented return type ByTIC\Hello\Models\Users\Traits\UserTrait|boolean.

The method findOne() does not exist on ByTIC\Hello\Models\Users\Traits\UsersTrait. Did you maybe mean findOneByEmail()?

        }
        return false;
    }