ByTIC\Hello\Models\Users\Logins\Traits\LoginsTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	initRelations()	0	4	1
A	getUserByProvider()	0	17	2
A	createForProvider()	0	9	1
A	initRelationsTrait()	0	3	1

<?php

namespace ByTIC\Hello\Models\Users\Logins\Traits;

use ByTIC\Hello\Models\Users\Logins\UsersLogin;
use ByTIC\Hello\Models\Users\Traits\UsersTrait;
use ByTIC\Hello\Models\Users\Traits\UserTrait;
use Nip\Records\Locator\ModelLocator;
use Nip\Records\RecordManager;

/**
 * Trait LoginsTrait
 * @package ByTIC\Hello\Models\Users\Logins\Traits
 *
 * @method LoginTrait|UsersLogin getNew
 */
trait LoginsTrait
{
    protected function initRelations()
    {
        parent::initRelations();
        $this->initRelationsTrait();
    }

    protected function initRelationsTrait()
    {
        $this->belongsTo('User');

It seems like belongsTo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param $providerName
     * @param $user
     * @param $userProfile
     * @return LoginTrait
     */
    public function createForProvider($providerName, $user, $userProfile)
    {
        $userLogin = $this->getNew();
        $userLogin->populateFromUser($user);
        $userLogin->populateFromUserProfile($userProfile);
        $userLogin->provider_name = $providerName;
        $userLogin->insert();

It seems like insert() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $userLogin;
    }

    /**
     * @param $provider
     * @param $uid
     * @return bool|UserTrait
     */
    public function getUserByProvider($provider, $uid)
    {
        $params = [
            'where' => [
                ['provider_name = ?', $provider],
                ['provider_uid = ?', $uid]
            ]
        ];

        $item = $this->findOneByParams($params);

It seems like findOneByParams() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($item) {
            /** @var UsersTrait|RecordManager $userManager */
            $userManager = $this->getRelation('User')->getWith();

It seems like getRelation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $userManager->findOne($item->id_user);

The expression return $userManager->findOne($item->id_user) returns the type Nip\Records\AbstractModels\Record which is incompatible with the documented return type ByTIC\Hello\Models\Users\Traits\UserTrait|boolean.

The method findOne() does not exist on ByTIC\Hello\Models\Users\Traits\UsersTrait. Did you maybe mean findOneByEmail()?

        }
        return false;
    }
}