bytic / MediaLibrary

src/Loaders/Database.php

<?php

namespace ByTIC\MediaLibrary\Loaders;

use ByTIC\MediaLibrary\Support\MediaModels;
use Nip\Filesystem\File;

/**
 * Class Database
 */
class Database extends AbstractLoader
{
    /**
     * @return File[]
     */
    public function getMediaFiles()
    {
        $files = $this->tryDatabase();
        if (is_array($files)) {
            return $files;
        }
        $files = $this->tryFilesystem();

        $model = $this->getCollection()->getRecord();

        foreach ($files as $file) {
            MediaModels::records()->createFor(
                $file,
                $model,

It seems like $model can also be of type ByTIC\MediaLibrary\HasMedia\HasMediaTrait; however, parameter $model of ByTIC\MediaLibrary\Models\MediaRecords\MediaRecords::createFor() does only seem to accept Nip\Records\AbstractModels\Record, maybe add an additional type check?

                $this->getCollection()
            );
        }

        $model->mediaProperties($this->getCollection())->saveDbLoaded(true);

The method saveDbLoaded() does not exist on Nip\Records\Collections\Collection.

        return $files;
    }

    /**
     * @return array|false
     */
    protected function tryDatabase()
    {
        $propertiesRecord = MediaModels::properties()->forCollection($this->getCollection());

        if (!is_object($propertiesRecord) || $propertiesRecord->dbLoaded() === false) {
            return false;
        }

        $mediaRecords = MediaModels::records()->for(
            $this->getCollection()->getRecord(),

It seems like $this->getCollection()->getRecord() can also be of type ByTIC\MediaLibrary\HasMedia\HasMediaTrait; however, parameter $model of ByTIC\MediaLibrary\Models\MediaRecords\MediaRecords::for() does only seem to accept Nip\Records\AbstractModels\Record, maybe add an additional type check?

            $this->getCollection()->getName()
        );
        $files = [];
        foreach ($mediaRecords as $mediaRecord) {
            $files[] = new File($this->getFilesystem(), $mediaRecord->path);

The property path does not exist on ByTIC\MediaLibrary\Models\MediaProperties\MediaProperty. Since you implemented __get, consider adding a @property annotation.

        }
        return $files;
    }

    /**
     * @return array|false
     */
    protected function tryFilesystem()
    {
        $loader = $this->initFromSibling(Filesystem::class);
        return $loader->getMediaFiles();
    }
}